swc-installation-test-2.py: Don't override Popen's 'close_fds'

Or 'shell'.  The support for these options can be flaky, and the
defaults change with Python version depending on what is best
supported [1].

[1]: http://docs.python.org/2/library/subprocess.html#subprocess.Popen

Reported-by: Ethan White <ethan@weecology.org>

diff --git a/setup/swc-installation-test-2.py b/setup/swc-installation-test-2.py
index 89d6d46b39ec57f8012b7294737a8ce3f78313db..6da7ce7e47bd864037aaa7c5ccc30923ee076161 100755 (executable)
--- a/setup/swc-installation-test-2.py
+++ b/setup/swc-installation-test-2.py
@@ -416,7 +416,7 @@ class CommandDependency (Dependency):
             p = _subprocess.Popen(
                 [command] + list(self.version_options), stdin=popen_stdin,
                 stdout=_subprocess.PIPE, stderr=_subprocess.PIPE,
             p = _subprocess.Popen(
                 [command] + list(self.version_options), stdin=popen_stdin,
                 stdout=_subprocess.PIPE, stderr=_subprocess.PIPE,

-                close_fds=True, shell=False, universal_newlines=True)
+                universal_newlines=True)

         except OSError as e:
             raise DependencyError(
                 checker=self,
         except OSError as e:
             raise DependencyError(
                 checker=self,