install_qa_check: adjust "poor programming" msgs

Refer to "severe warnings" rather than "poor programming", in order to
be more politically correct, as discussed in bug #374233.

diff --git a/bin/misc-functions.sh b/bin/misc-functions.sh
index 8c191ff8cce1bc9fcf1fcd0f974fdd80bafe2a0a..30244a74b27f29ac9b7e5a9410793a2d382ad599 100755 (executable)
--- a/bin/misc-functions.sh
+++ b/bin/misc-functions.sh
@@ -621,8 +621,8 @@ install_qa_check() {
                                #esac
                                if [[ $always_overflow = yes ]] ; then
                                        eerror
-                                       eerror "QA Notice: Package has poor programming practices which may compile"
-                                       eerror "           fine but exhibit random runtime failures."
+                                       eerror "QA Notice: Package triggers severe warnings which indicate that it"
+                                       eerror "           may exhibit random runtime failures."
                                        eerror
                                        eerror "${f}"
                                        eerror
@@ -631,8 +631,8 @@ install_qa_check() {
                                        eerror
                                else
                                        vecho -ne '\n'
-                                       eqawarn "QA Notice: Package has poor programming practices which may compile"
-                                       eqawarn "           fine but exhibit random runtime failures."
+                                       eqawarn "QA Notice: Package triggers severe warnings which indicate that it"
+                                       eqawarn "           may exhibit random runtime failures."
                                        eqawarn "${f}"
                                        vecho -ne '\n'
                                fi
@@ -658,8 +658,8 @@ install_qa_check() {
 
                        if [[ $gentoo_bug = yes ]] ; then
                                eerror
-                               eerror "QA Notice: Package has poor programming practices which may compile"
-                               eerror "           but will almost certainly crash on 64bit architectures."
+                               eerror "QA Notice: Package triggers severe warnings which indicate that it"
+                               eerror "           will almost certainly crash on 64bit architectures."
                                eerror
                                eerror "${f}"
                                eerror
@@ -668,8 +668,8 @@ install_qa_check() {
                                eerror
                        else
                                vecho -ne '\n'
-                               eqawarn "QA Notice: Package has poor programming practices which may compile"
-                               eqawarn "           but will almost certainly crash on 64bit architectures."
+                               eqawarn "QA Notice: Package triggers severe warnings which indicate that it"
+                               eqawarn "           will almost certainly crash on 64bit architectures."
                                eqawarn "${f}"
                                vecho -ne '\n'
                        fi
@@ -678,7 +678,7 @@ install_qa_check() {
                if [[ ${abort} == "yes" ]] ; then
                        if [[ $gentoo_bug = yes || $always_overflow = yes ]] ; then
                                die "install aborted due to" \
-                                       "poor programming practices shown above"
+                                       "severe warnings shown above"
                        else
                                echo "Please do not file a Gentoo bug and instead" \
                                "report the above QA issues directly to the upstream" \
@@ -686,7 +686,7 @@ install_qa_check() {
                                while read -r line ; do eqawarn "${line}" ; done
                                eqawarn "Homepage: ${HOMEPAGE}"
                                has stricter ${FEATURES} && die "install aborted due to" \
-                                       "poor programming practices shown above"
+                                       "severe warnings shown above"
                        fi
                fi
        fi