new: Don't report version after upgrade
authorAustin Clements <amdragon@mit.edu>
Mon, 25 Aug 2014 17:25:59 +0000 (13:25 -0400)
committerDavid Bremner <david@tethera.net>
Sat, 30 Aug 2014 17:40:41 +0000 (10:40 -0700)
The version number has always been pretty meaningless to the user and
it's about to become even more meaningless with the introduction of
"features".  Hopefully, the database will remain on version 3 for some
time to come; however, the introduction of new features over time in
version 3 will necessitate upgrades within version 3.  It would be
confusing if we always tell the user they've been "upgraded to version
3".  If the user wants to know what's new, they should read the news.

notmuch-new.c
test/T530-upgrade.sh

index 569100560accbc393a52b124d14f55178fb6e63d..ddf42c140802225078dce5a7316609404a439930 100644 (file)
@@ -1031,8 +1031,7 @@ notmuch_new_command (notmuch_config_t *config, int argc, char *argv[])
                return EXIT_FAILURE;
            }
            if (add_files_state.verbosity >= VERBOSITY_NORMAL)
-               printf ("Your notmuch database has now been upgraded to database format version %u.\n",
-                   notmuch_database_get_version (notmuch));
+               printf ("Your notmuch database has now been upgraded.\n");
        }
 
        add_files_state.total_files = 0;
index 7d5d5aa88e0150af3b95897143cc760b8c445c1f..c4c4ac8b64475955b91d07ca188102d3d626c82b 100755 (executable)
@@ -33,7 +33,7 @@ test_expect_equal "$output" "\
 Welcome to a new version of notmuch! Your database will now be upgraded.
 This process is safe to interrupt.
 Backing up tags to FILENAME
-Your notmuch database has now been upgraded to database format version 2.
+Your notmuch database has now been upgraded.
 No new mail."
 
 test_begin_subtest "tag backup matches pre-upgrade dump"