Re: [PATCH 2/4] cli: add --remove-all option to "notmuch tag"

diff --git a/2f/ed1e081223d130fd87f48d6f1a3d76e5e54d0c b/2f/ed1e081223d130fd87f48d6f1a3d76e5e54d0c
new file mode 100644 (file)
index 0000000..86713f4
--- /dev/null
+++ b/2f/ed1e081223d130fd87f48d6f1a3d76e5e54d0c
@@ -0,0 +1,81 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 76BB1431FB6\r
+       for <notmuch@notmuchmail.org>; Mon, 25 Feb 2013 13:53:33 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id QEqz0QHELaqa for <notmuch@notmuchmail.org>;\r
+       Mon, 25 Feb 2013 13:53:33 -0800 (PST)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id EF033431FAF\r
+       for <notmuch@notmuchmail.org>; Mon, 25 Feb 2013 13:53:32 -0800 (PST)\r
+Received: from convex-new.cs.unb.ca ([131.202.245.35])\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1UA5zA-000129-Mn; Mon, 25 Feb 2013 17:53:27 -0400\r
+Received: from bremner by convex-new.cs.unb.ca with local (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1UA5z3-0007kX-92; Mon, 25 Feb 2013 17:53:17 -0400\r
+From: David Bremner <david@tethera.net>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/4] cli: add --remove-all option to "notmuch tag"\r
+In-Reply-To: <87obf8ur0u.fsf@nikula.org>\r
+References:\r
+ <1a2c09adc1c963f1aa209c09143f85dca7634e11.1358876448.git.jani@nikula.org>\r
+       <e9dd76463809998cdb68bb5078a8d679e98560c2.1358876448.git.jani@nikula.org>\r
+       <87obf8ur0u.fsf@nikula.org>\r
+User-Agent: Notmuch/0.14+257~ge43e0af (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 25 Feb 2013 17:53:17 -0400\r
+Message-ID: <87a9qs6oxe.fsf@convex-new.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 25 Feb 2013 21:53:33 -0000\r
+\r
+Jani Nikula <jani@nikula.org> writes:\r
+\r
+>>\r
+>> $ notmuch tag $(notmuch search --output=tags '*' | sed 's/^/-/') \\r
+>>   id:foo@example.com\r
+>> $ notmuch tag $(notmuch search --output=tags '*' | sed 's/^/-/') \\r
+>>   +foo +bar id:foo@example.com\r
+\r
+In the special case that the query really is a message-id, the following\r
+should work\r
+\r
+echo "-- id:foo@example" | notmuch restore --format=batch-tag\r
+\r
+should work.\r
+\r
+Weirdly, that seems to even remove that attachment tag, I'm not sure if\r
+that is a bug.\r
+\r
+Anyway your patches are more general.\r
+\r
+Sorry, that's not a review yet.\r
+\r
+d\r