Re: [PATCH 3/7] py3k: All strings are unicode strings in py3k

diff --git a/94/c827e98be85ed9de4854dd3698fb4486a33757 b/94/c827e98be85ed9de4854dd3698fb4486a33757
new file mode 100644 (file)
index 0000000..ee34378
--- /dev/null
+++ b/94/c827e98be85ed9de4854dd3698fb4486a33757
@@ -0,0 +1,105 @@
+Return-Path: <tomi.ollila@nixu.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8E331429E27\r
+       for <notmuch@notmuchmail.org>; Wed, 14 Dec 2011 04:17:57 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id a5m0KbMX1QL5 for <notmuch@notmuchmail.org>;\r
+       Wed, 14 Dec 2011 04:17:56 -0800 (PST)\r
+Received: from mail-gw3.nixu.fi (mail-gw3.nixu.fi [193.209.237.7])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 6E7B2429E26\r
+       for <notmuch@notmuchmail.org>; Wed, 14 Dec 2011 04:17:56 -0800 (PST)\r
+Received: from pps.filterd (mail-gw3 [127.0.0.1])\r
+       by mail-gw3.nixu.fi (8.14.4/8.14.4) with SMTP id pBECFJmQ029996;\r
+       Wed, 14 Dec 2011 14:17:42 +0200\r
+Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])\r
+       by mail-gw3.nixu.fi with ESMTP id 114cs0t9ep-1\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Wed, 14 Dec 2011 14:17:41 +0200\r
+Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])\r
+       by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id\r
+       pBECHfnl015798; Wed, 14 Dec 2011 14:17:41 +0200\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Justus Winter <4winter@informatik.uni-hamburg.de>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 3/7] py3k: All strings are unicode strings in py3k\r
+In-Reply-To:\r
+ <1323860305-15802-4-git-send-email-4winter@informatik.uni-hamburg.de>\r
+References:\r
+ <1323860305-15802-1-git-send-email-4winter@informatik.uni-hamburg.de>\r
+       <1323860305-15802-4-git-send-email-4winter@informatik.uni-hamburg.de>\r
+User-Agent: Notmuch/0.10.2+93~g631d290 (http://notmuchmail.org) Emacs/23.3.1\r
+       (i686-pc-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 14 Dec 2011 14:17:41 +0200\r
+Message-ID: <yf6r507s5y2.fsf@taco2.nixu.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.5.7110,\r
+ 1.0.211,      0.0.0000        definitions=2011-12-14_05:2011-12-14, 2011-12-14,\r
+       1970-01-01 signatures=0\r
+X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0\r
+       ipscore=0 suspectscore=0\r
+       phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0\r
+       reason=mlx\r
+       scancount=1 engine=6.0.2-1012030000 definitions=main-1112140071\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 14 Dec 2011 12:17:57 -0000\r
+\r
+On Wed, 14 Dec 2011 11:58:21 +0100, Justus Winter <4winter@informatik.uni-hamburg.de> wrote:\r
+> ---\r
+>  bindings/python/notmuch/globals.py |    4 ++--\r
+>  1 files changed, 2 insertions(+), 2 deletions(-)\r
+> \r
+> diff --git a/bindings/python/notmuch/globals.py b/bindings/python/notmuch/globals.py\r
+> index 54a49b2..99e6a10 100644\r
+> --- a/bindings/python/notmuch/globals.py\r
+> +++ b/bindings/python/notmuch/globals.py\r
+> @@ -51,7 +51,7 @@ class Status(Enum):\r
+>          """Get a (unicode) string representation of a notmuch_status_t value."""\r
+>          # define strings for custom error messages\r
+>          if status == STATUS.NOT_INITIALIZED:\r
+> -            return u"Operation on uninitialized object impossible."\r
+> +            return "Operation on uninitialized object impossible."\r
+>          return unicode(Status._status2str(status))\r
+>  \r
+>  STATUS = Status(['SUCCESS',\r
+> @@ -142,7 +142,7 @@ class NotmuchError(Exception):\r
+>          elif self.status is not None:\r
+>              return STATUS.status2str(self.status)\r
+>          else:\r
+> -            return u'Unknown error'\r
+> +            return 'Unknown error'\r
+\r
+Is this u -prefix unnecessary in python 2 too ? Grepping\r
+'u"' and "u'" in **/*.py in puthon bindings source resulted\r
+some more u-prefixed strings in docs/source/conf.py. Should\r
+these be changed in some future patch ?\r
+\r
+>  # List of Subclassed exceptions that correspond to STATUS values and are\r
+> -- \r
+> 1.7.7.3\r
+\r
+Tomi\r