--- /dev/null
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 9EFC4403E3E\r
+ for <notmuch@notmuchmail.org>; Fri, 24 Feb 2012 02:48:57 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 2tfC4MufaMCG for <notmuch@notmuchmail.org>;\r
+ Fri, 24 Feb 2012 02:48:56 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+ [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id CB9AC40BC64\r
+ for <notmuch@notmuchmail.org>; Fri, 24 Feb 2012 02:48:55 -0800 (PST)\r
+Received: by bkcit16 with SMTP id it16so2026518bkc.26\r
+ for <notmuch@notmuchmail.org>; Fri, 24 Feb 2012 02:48:54 -0800 (PST)\r
+Received-SPF: pass (google.com: domain of dmitry.kurochkin@gmail.com\r
+ designates 10.205.137.4 as permitted sender)\r
+ client-ip=10.205.137.4; \r
+Authentication-Results: mr.google.com; spf=pass (google.com: domain of\r
+ dmitry.kurochkin@gmail.com designates 10.205.137.4 as permitted\r
+ sender) smtp.mail=dmitry.kurochkin@gmail.com;\r
+ dkim=pass header.i=dmitry.kurochkin@gmail.com\r
+Received: from mr.google.com ([10.205.137.4])\r
+ by 10.205.137.4 with SMTP id im4mr798946bkc.136.1330080534423 (num_hops\r
+ = 1); Fri, 24 Feb 2012 02:48:54 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+ h=from:to:cc:subject:in-reply-to:references:user-agent:date\r
+ :message-id:mime-version:content-type;\r
+ bh=Kc4HyIXOqwcMKjafbL9sl4PYrI8qnOfsZfyTHIIEwrM=;\r
+ b=wXPC+kshF/QywXsrYSF3YxmflWWQxslMLP/cr6HsDbOdnYgzVCheOV882J0o4/ux8P\r
+ jgEPlfsG+n8kt7WZzxQuUlJ9oq2E7tYU/FHiZRfKKHIXhPXkWrh4ECxtyg9R7y9KNXdh\r
+ 7Ra5Fzg6VwCb51+1EauxxneQ+4xcuA64mh9Vk=\r
+Received: by 10.205.137.4 with SMTP id im4mr664982bkc.136.1330080534343;\r
+ Fri, 24 Feb 2012 02:48:54 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+ by mx.google.com with ESMTPS id jd17sm7920907bkb.4.2012.02.24.02.48.53\r
+ (version=TLSv1/SSLv3 cipher=OTHER);\r
+ Fri, 24 Feb 2012 02:48:53 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: Pieter Praet <pieter@praet.org>, David Bremner <david@tethera.net>\r
+Subject: Re: [PATCH 6/6] emacs: `notmuch-show-tag-all' sans prefix arg only\r
+ tags open messages\r
+In-Reply-To: <1330038554-10347-6-git-send-email-pieter@praet.org>\r
+References: <878vjtqhcg.fsf@praet.org>\r
+ <1330038554-10347-6-git-send-email-pieter@praet.org>\r
+User-Agent: Notmuch/0.11.1+188~ga5674c2 (http://notmuchmail.org) Emacs/23.3.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Fri, 24 Feb 2012 14:47:30 +0400\r
+Message-ID: <87aa48jynx.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 24 Feb 2012 10:48:58 -0000\r
+\r
+On Fri, 24 Feb 2012 00:09:14 +0100, Pieter Praet <pieter@praet.org> wrote:\r
+> * emacs/notmuch-show.el\r
+> \r
+> (notmuch-show-get-messages-ids):\r
+> New optional argument ONLY-OPEN. If non-nil, only return\r
+> Message-Id's for messages which are currently visible.\r
+> \r
+> (notmuch-show-tag-all):\r
+> New optional argument IGNORE-VISIBILITY, of which the inverse is\r
+> passed as ONLY-OPEN argument to `notmuch-show-get-messages-ids':\r
+> If called with a prefix arg, affect *all* messages in the current\r
+> buffer. Otherwise, only change tags of visible messages.\r
+> \r
+> (notmuch-show-archive-thread):\r
+> Update wrt changes to `notmuch-show-tag-all'.\r
+> \r
+> * test/emacs\r
+> \r
+> - Subtest "notmuch-show: change tags of open messages in current buffer"\r
+> is no longer broken.\r
+> ---\r
+> emacs/notmuch-show.el | 28 ++++++++++++++++++++--------\r
+> test/emacs | 1 -\r
+> 2 files changed, 20 insertions(+), 9 deletions(-)\r
+> \r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index 4b37c77..4499fcd 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -1334,13 +1334,17 @@ (defun notmuch-show-get-message-id ()\r
+> "Return the message id of the current message."\r
+> (concat "id:\"" (notmuch-show-get-prop :id) "\""))\r
+> \r
+> -(defun notmuch-show-get-messages-ids (&optional separator)\r
+> +(defun notmuch-show-get-messages-ids (&optional only-open separator)\r
+> "Return a list of Message-Id's of all messages in the current buffer.\r
+> \r
+> +If optional argument ONLY-OPEN is non-nil, only return\r
+> +Message-Id's for messages which are currently visible.\r
+> +\r
+> If provided with optional argument SEPARATOR, return a string\r
+> instead, consisting of all Message-Id's separated by SEPARATOR."\r
+> (let ((message-ids))\r
+> - (notmuch-show-mapc t\r
+> + (notmuch-show-mapc\r
+> + `(if only-open (notmuch-show-message-visible-p) t)\r
+\r
+How about changing ONLY-OPEN to a general optional PREDICATE argument\r
+and pass it as is to `notmuch-show-mapc'? Please make it the last\r
+argument.\r
+\r
+Regards,\r
+ Dmitry\r
+\r
+> (lambda () (push (notmuch-show-get-message-id) message-ids)))\r
+> (if separator\r
+> (mapconcat 'identity message-ids separator)\r
+> @@ -1628,13 +1632,21 @@ (defun notmuch-show-tag (&optional initial-input)\r
+> initial-input (notmuch-show-get-message-id))))\r
+> (apply 'notmuch-show-tag-message tag-changes)))\r
+> \r
+> -(defun notmuch-show-tag-all (&rest tag-changes)\r
+> - "Change tags for all messages in the current thread.\r
+> +(defun notmuch-show-tag-all (&optional ignore-visibility &rest tag-changes)\r
+> + "Change tags of all open messages in the current buffer.\r
+> +\r
+> +If optional arg IGNORE-VISIBILITY is non-nil, change tags of\r
+> +*all* messages in the current buffer, independent of their\r
+> +visibility.\r
+> \r
+> TAG-CHANGES is a list of tag operations for `notmuch-tag'."\r
+> - (interactive (notmuch-read-tag-changes nil notmuch-show-thread-id))\r
+> - (apply 'notmuch-tag (notmuch-show-get-messages-ids " or ") tag-changes)\r
+> - (notmuch-show-mapc t\r
+> + (interactive (cons current-prefix-arg\r
+> + (notmuch-read-tag-changes nil notmuch-show-thread-id)))\r
+> + (apply 'notmuch-tag\r
+> + (notmuch-show-get-messages-ids (not ignore-visibility) " or ")\r
+> + tag-changes)\r
+> + (notmuch-show-mapc\r
+> + `(if ignore-visibility t (notmuch-show-message-visible-p))\r
+> (lambda ()\r
+> (let* ((current-tags (notmuch-show-get-tags))\r
+> (new-tags (notmuch-update-tags current-tags tag-changes)))\r
+> @@ -1719,7 +1731,7 @@ (defun notmuch-show-archive-thread (&optional unarchive)\r
+> buffer."\r
+> (interactive "P")\r
+> (let ((op (if unarchive "+" "-")))\r
+> - (notmuch-show-tag-all (concat op "inbox"))))\r
+> + (notmuch-show-tag-all t (concat op "inbox"))))\r
+> \r
+> (defun notmuch-show-archive-thread-then-next ()\r
+> "Archive each message in thread, then show next thread from search."\r
+> diff --git a/test/emacs b/test/emacs\r
+> index 644ef59..c286ff5 100755\r
+> --- a/test/emacs\r
+> +++ b/test/emacs\r
+> @@ -152,7 +152,6 @@ notmuch tag +"$del_tag" -"$add_tag" -- "$query" # revert tag changes\r
+> test_expect_equal "$count_changed" "$count_total" # assert that CHANGED == TOTAL\r
+> \r
+> test_begin_subtest "notmuch-show: change tags of open messages in current buffer"\r
+> -test_subtest_known_broken\r
+> query="$os_x_darwin_thread"\r
+> filter="from:Jiang"\r
+> add_tag="notmuch-show-tag-all"\r
+> -- \r
+> 1.7.8.1\r
+> \r
projects / notmuch-archives.git / commitdiff