Re: [BUG/PATCH v4 0/4] Bug fixes for reply, rebased

diff --git a/73/3bfef114f7c12e122f59427236d71b4b634425 b/73/3bfef114f7c12e122f59427236d71b4b634425
new file mode 100644 (file)
index 0000000..ce90b82
--- /dev/null
+++ b/73/3bfef114f7c12e122f59427236d71b4b634425
@@ -0,0 +1,111 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id E7812431FC0\r
+       for <notmuch@notmuchmail.org>; Sun,  1 Apr 2012 15:17:15 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.29\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 6sbDT-Ukplam for <notmuch@notmuchmail.org>;\r
+       Sun,  1 Apr 2012 15:17:15 -0700 (PDT)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id 4FDB7431FAF\r
+       for <notmuch@notmuchmail.org>; Sun,  1 Apr 2012 15:17:15 -0700 (PDT)\r
+Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by fire-doxen-postvirus (Postfix) with ESMTP id D549E328018;\r
+       Sun,  1 Apr 2012 15:17:12 -0700 (PDT)\r
+X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new\r
+Received: from finestructure.net (unknown [76.89.193.65])\r
+       (Authenticated sender: jrollins)\r
+       by fire-doxen-submit (Postfix) with ESMTP id 8A79732800C;\r
+       Sun,  1 Apr 2012 15:17:09 -0700 (PDT)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id EA352906; Sun,  1 Apr 2012 15:17:06 -0700 (PDT)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Adam Wolfe Gordon <awg+notmuch@xvx.ca>, notmuch@notmuchmail.org\r
+Subject: Re: [BUG/PATCH v4 0/4] Bug fixes for reply, rebased\r
+In-Reply-To: <1333293863-14361-1-git-send-email-awg+notmuch@xvx.ca>\r
+References: <1333240404-13076-1-git-send-email-awg+notmuch@xvx.ca>\r
+       <1333293863-14361-1-git-send-email-awg+notmuch@xvx.ca>\r
+User-Agent: Notmuch/0.12+93~g9442054 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 01 Apr 2012 15:17:04 -0700\r
+Message-ID: <87398nm71b.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 01 Apr 2012 22:17:16 -0000\r
+\r
+--=-=-=\r
+\r
+On Sun, Apr 01 2012, Adam Wolfe Gordon <awg+notmuch@xvx.ca> wrote:\r
+> This series is the same as the one from yesterday [1], rebased onto the\r
+> current master to resolve some conflicts with Austin's chnages.\r
+>\r
+> [1] id:"1333240404-13076-1-git-send-email-awg+notmuch@xvx.ca"\r
+\r
+This series applies cleanly against the current master and all tests\r
+pass and it seems to fix all the issues it's meant to address.  The code\r
+all looks good to me as well (given my pidgin lisp).\r
+\r
+> Adam Wolfe Gordon (4):\r
+>   test: Tests for reply from alternate addresses in emacs\r
+>   emacs: Fix two bugs in reply\r
+>   test: Show all headers in emacs reply tests\r
+\r
+I really like your justification for the changes to the tests here.\r
+Smart move.\r
+\r
+>   emacs: Fix the References header in reply\r
+>\r
+>  emacs/notmuch-lib.el |    7 +++-\r
+>  emacs/notmuch-mua.el |   36 +++++++++++++++++----\r
+>  test/emacs           |   84 +++++++++++++++++++++++++++++++++++++++++++++-----\r
+>  3 files changed, 110 insertions(+), 17 deletions(-)\r
+\r
+LGTM.\r
+\r
+Thanks so much for fixing the remaining issues here, Adam.  Good work.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.12 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJPeNPgAAoJEO00zqvie6q8mzAP/2RRfhKE3L9Rss/iXIzPqh5W\r
+i08WNUQ5t2LwG1Gj+Opx5on9JiABvlZnwk1A0zpgUFpC/GRRD1uGaik/iJLzU4gE\r
+m4/U0VA+8C7a749FsMkQ5v51Qys5HumEvvWiXeCPJ2SwpV64QRnsFvzIYuXCS8aA\r
+KcvUXe2wAgx8DEBMIIWGuoZ73jVOneiJbBQeGYa+VU+mmRi0WlogKPBwTHWlUBlw\r
+aeJPfCgXvVPWYJqYNsu4sYXEGhUAOluhAuP/OD0T+oQx455v37K0O32Bdpym9fzt\r
+KV+z/8ftROJkwfC6R64M8tLMxeySoKYC8/HytMxXMkL6qaKFmGXEDGoAiWkTJzbT\r
+4p06SPiX0Bh8vabKZyoFN0JZAMAe3bg0a2ocA0Xtow3wchwByXmZvMxeemJneXgy\r
+E4ptSNDMrQTZIwX5gPEqB29rJMk6mhHqLovXiBeWrbs3BD5GFT15t+ipPQOymwil\r
+FZAlmyC5bjmvun5umWrMrt0x4j+z1Nh+T4/WI65DC6nw9q/RY3U5J1zcI02DNE89\r
+T1xTNWwUd4v29V/8MEj9EKfdd7Wb3rF+Y5HoS19OYeHeEUe3iVHMaNR2AnkKPZ2o\r
+dL+umiUKCvKS9WzpA7FODqSNPc/rcdni1aD1yAvOH8yN7lbfsejJZm7yoS0dmqr6\r
+qxnvCAeMi2rdGDXZhm93\r
+=csfQ\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r