--- /dev/null
+Return-Path: <dme@dme.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 21761431FC9\r
+ for <notmuch@notmuchmail.org>; Fri, 31 Oct 2014 00:01:14 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.699\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7, UNPARSEABLE_RELAY=0.001]\r
+ autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id yZvfCLMXopdh for <notmuch@notmuchmail.org>;\r
+ Fri, 31 Oct 2014 00:01:06 -0700 (PDT)\r
+Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com\r
+ [74.125.82.50]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client\r
+ certificate requested) by olra.theworths.org (Postfix) with ESMTPS id\r
+ 69C72431FC2 for <notmuch@notmuchmail.org>; Fri, 31 Oct 2014 00:01:06 -0700\r
+ (PDT)\r
+Received: by mail-wg0-f50.google.com with SMTP id z12so5777796wgg.23\r
+ for <notmuch@notmuchmail.org>; Fri, 31 Oct 2014 00:01:02 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=1e100.net; s=20130820;\r
+ h=x-gm-message-state:to:subject:in-reply-to:references:user-agent\r
+ :from:date:message-id:mime-version:content-type;\r
+ bh=YKyBdwCkqVFbwz9RANAMLYFjUhNBx3Ei4YfzhB1p9jQ=;\r
+ b=HZpm+iUR3i2BLXW60YoQwU0LHWjF6HJ5CGERvfQRFrUws4F7ZZGULwHUFw9yySpvsT\r
+ rBm1o0FgB3fc6G3ZM2pLlXOrpBgYLiJ25/9g0DoV6Hu3HHxTZjZIG/ncNenu7g1W2QYI\r
+ lvW9/3DK5Qv2Uh64QQrq6LLVfzyHpoMuCcwsEjSrar+vAta12LR7Ekd+0KHCIQDOIi9R\r
+ uRtWD4sOXCYL/pt7DtxhJpocUir772QDBeVed1bPUtQ105PFV5aOYpVcZdATie6d9Ppp\r
+ zqqvta1VT4m8Ho3hT7lWTMU5RcsyD/SjckzGYTl7W6Qc+CM4aFVxPKqDLCffO83eDY3U\r
+ sGIQ==\r
+X-Gm-Message-State:\r
+ ALoCoQledRWN3Inqmfr1Qyf34wGqVU1D99hjPYqHU7YFp/VbaOKEJwoakNrnyHt0fSKLjkWQ+fqo\r
+X-Received: by 10.195.13.114 with SMTP id ex18mr780235wjd.111.1414738861766;\r
+ Fri, 31 Oct 2014 00:01:01 -0700 (PDT)\r
+Received: from disaster-area.hh.sledj.net\r
+ ([2a01:348:1a2:1:ea39:35ff:fe2c:a227])\r
+ by mx.google.com with ESMTPSA id\r
+ vm6sm11057399wjc.16.2014.10.31.00.01.00 for <multiple recipients>\r
+ (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+ Fri, 31 Oct 2014 00:01:00 -0700 (PDT)\r
+Received: from localhost (30000@localhost [local]);\r
+ by localhost (OpenSMTPD) with ESMTPA id e4eaf20c;\r
+ Fri, 31 Oct 2014 07:00:59 +0000 (UTC)\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v1] emacs: Improved header display.\r
+In-Reply-To: <874mul8fe1.fsf@nikula.org>\r
+References: <1414692196-12550-1-git-send-email-dme@dme.org>\r
+ <874mul8fe1.fsf@nikula.org>\r
+User-Agent: Notmuch/0.18.1 (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-apple-darwin14.0.0)\r
+From: David Edmondson <dme@dme.org>\r
+Date: Fri, 31 Oct 2014 07:00:59 +0000\r
+Message-ID: <m2bnos67v8.fsf@heart-of-gold.hh.sledj.net>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 31 Oct 2014 07:01:14 -0000\r
+\r
+On Thu, Oct 30 2014, Jani Nikula wrote:\r
+> On Thu, 30 Oct 2014, David Edmondson <dme@dme.org> wrote:\r
+>> Truncate the displayed headers to the window width. Show an ellipsis\r
+>> if the displayed header is truncated. Add a binding 'T' to toggle the\r
+>> truncation of headers. Add the not-displayed section of the header as\r
+>> a tooltip to the displayed section.\r
+>\r
+> Thanks for your efforts, David - I hate it that I'm going to sound\r
+> ungrateful since I asked for something like this. But not quite like\r
+> this...\r
+>\r
+> I think more header lines than just one should be displayed untruncated\r
+> by default. I think it's okay to show, say, five lines of To: or Cc: and\r
+> that'll probably cover most emails without truncation. And when the\r
+> header does get truncated, I'd really like to see the indication more\r
+> predominantly displayed than just ellipsis.\r
+>\r
+> I'm thinking of something like this, similar to notmuch-wash:\r
+>\r
+> ---\r
+> To: user@example.com, user@example.com, user@example.com,\r
+> user@example.com, user@example.com, user@example.com, user@example.com,\r
+> user@example.com, user@example.com, user@example.com, user@example.com,\r
+> user@example.com, user@example.com, user@example.com, user@example.com,\r
+> [ 42 more header lines. Click/Enter to show. ]\r
+> Cc: user@example.com\r
+> ---\r
+\r
+Hmm. That seems pretty ugly to me :-)\r
+\r
+As you mentioned in #notmuch, the implementation below is also not quite\r
+correct - it assumes that it is splitting addresses but is also used on\r
+the non-address headers. There are also some oddities when the header\r
+lines of collapsed messages are compressed.\r
+\r
+If anyone else is particularly interested then I may come back to it,\r
+but otherwise will leave it alone.\r
+\r
+> BR,\r
+> Jani.\r
+>\r
+>\r
+>> ---\r
+>> emacs/notmuch-show.el | 54 ++++++++++++++++++++++++++++++++++++++++++++++++---\r
+>> 1 file changed, 51 insertions(+), 3 deletions(-)\r
+>>\r
+>> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+>> index a997482..523cef5 100644\r
+>> --- a/emacs/notmuch-show.el\r
+>> +++ b/emacs/notmuch-show.el\r
+>> @@ -443,9 +443,56 @@ message at DEPTH in the current thread."\r
+>> ")\n")\r
+>> (overlay-put (make-overlay start (point)) 'face 'notmuch-message-summary-face)))\r
+>> \r
+>> +(defun notmuch-truncate-nicely (addresses target-length)\r
+>> + ;; If it fits, everything is easy.\r
+>> + (if (< (length addresses) target-length)\r
+>> + (cons addresses nil)\r
+>> + (let* ((visible-length (- target-length (length "...")))\r
+>> + (visible (substring addresses 0 visible-length))\r
+>> + (invisible (substring addresses visible-length)))\r
+>> + ;; Try to terminate the visible string at a good break point.\r
+>> + (when (string-match "\\(.+\\),\\([^,]*\\)" visible)\r
+>> + ;; Order is important (second clause is destructive on\r
+>> + ;; `visible'.\r
+>> + (setq invisible (concat (match-string 2 visible) invisible)\r
+>> + visible (match-string 1 visible)))\r
+>> + ;; `invisible' can end up with a leading space or\r
+>> + ;; comma-space, because the list of addresses is\r
+>> + ;; seperated with ", ", but we split on ",".\r
+>> + (setq invisible (replace-regexp-in-string "^[, ]*\\(.*\\)$" "\\1" invisible))\r
+>> + (cons visible invisible))))\r
+>> +\r
+>> +(defun notmuch-show-toggle-header-truncation ()\r
+>> + (interactive)\r
+>> + (let ((invisibility-spec-member (cons 'notmuch-show-mode t)))\r
+>> + (if (member invisibility-spec-member buffer-invisibility-spec)\r
+>> + (remove-from-invisibility-spec invisibility-spec-member)\r
+>> + (add-to-invisibility-spec invisibility-spec-member)))\r
+>> + ;; Required to have the change in visibility take effect.\r
+>> + (force-window-update))\r
+>> +\r
+>> (defun notmuch-show-insert-header (header header-value)\r
+>> "Insert a single header."\r
+>> - (insert header ": " (notmuch-sanitize header-value) "\n"))\r
+>> + (let* ((header-value (notmuch-sanitize header-value))\r
+>> + (header-colon (concat header ": "))\r
+>> + (available-width (- (window-width) (length header-colon)))\r
+>> + (v-i (notmuch-truncate-nicely header-value available-width)))\r
+>> +\r
+>> + (insert header-colon)\r
+>> + (let ((visible (car v-i))\r
+>> + (invisible (cdr v-i)))\r
+>> + (when invisible\r
+>> + (setq visible (propertize visible 'help-echo (concat "..." invisible))))\r
+>> + (insert visible)\r
+>> + (when invisible\r
+>> + (insert ", ")\r
+>> + (let ((start (point))\r
+>> + overlay)\r
+>> + (insert invisible)\r
+>> + (setq overlay (make-overlay start (point)))\r
+>> + (overlay-put overlay 'invisible 'notmuch-show-mode)\r
+>> + (overlay-put overlay 'isearch-open-invisible #'delete-overlay))))\r
+>> + (insert "\n")))\r
+>> \r
+>> (defun notmuch-show-insert-headers (headers)\r
+>> "Insert the headers of the current message."\r
+>> @@ -1328,6 +1375,7 @@ reset based on the original query."\r
+>> (define-key map "$" 'notmuch-show-toggle-process-crypto)\r
+>> (define-key map "<" 'notmuch-show-toggle-thread-indentation)\r
+>> (define-key map "t" 'toggle-truncate-lines)\r
+>> + (define-key map "T" 'notmuch-show-toggle-header-truncation)\r
+>> (define-key map "." 'notmuch-show-part-map)\r
+>> map)\r
+>> "Keymap for \"notmuch show\" buffers.")\r
+>> @@ -1367,8 +1415,8 @@ All currently available key bindings:\r
+>> (use-local-map notmuch-show-mode-map)\r
+>> (setq major-mode 'notmuch-show-mode\r
+>> mode-name "notmuch-show")\r
+>> - (setq buffer-read-only t\r
+>> - truncate-lines t))\r
+>> + (add-to-invisibility-spec (cons 'notmuch-show-mode t))\r
+>> + (setq buffer-read-only t))\r
+>> \r
+>> (defun notmuch-tree-from-show-current-query ()\r
+>> "Call notmuch tree with the current query"\r
+>> -- \r
+>> 2.1.1\r
+>>\r
+>> _______________________________________________\r
+>> notmuch mailing list\r
+>> notmuch@notmuchmail.org\r
+>> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff