Re: [PATCH v2 0/5] emacs: notmuch-hello status message refresh hook, etc

diff --git a/07/49278f6514948522fffd552611221c0c61d3a9 b/07/49278f6514948522fffd552611221c0c61d3a9
new file mode 100644 (file)
index 0000000..ddc1698
--- /dev/null
+++ b/07/49278f6514948522fffd552611221c0c61d3a9
@@ -0,0 +1,113 @@
+Return-Path: <sojkam1@fel.cvut.cz>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5FC16431FAF\r
+       for <notmuch@notmuchmail.org>; Wed,  5 Sep 2012 14:08:27 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id C+hZfBsIjx0j for <notmuch@notmuchmail.org>;\r
+       Wed,  5 Sep 2012 14:08:26 -0700 (PDT)\r
+Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36])\r
+       by olra.theworths.org (Postfix) with ESMTP id 22608431FAE\r
+       for <notmuch@notmuchmail.org>; Wed,  5 Sep 2012 14:08:26 -0700 (PDT)\r
+Received: from localhost (unknown [192.168.200.4])\r
+       by max.feld.cvut.cz (Postfix) with ESMTP id 8FA2C19F3375;\r
+       Wed,  5 Sep 2012 23:08:20 +0200 (CEST)\r
+X-Virus-Scanned: IMAP AMAVIS\r
+Received: from max.feld.cvut.cz ([192.168.200.1])\r
+       by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new,\r
+       port 10044)\r
+       with ESMTP id yCeIwZZ819CH; Wed,  5 Sep 2012 23:08:19 +0200 (CEST)\r
+Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34])\r
+       by max.feld.cvut.cz (Postfix) with ESMTP id 3E46A19F3367;\r
+       Wed,  5 Sep 2012 23:08:14 +0200 (CEST)\r
+Received: from steelpick.2x.cz (unknown [213.29.198.144])\r
+       (Authenticated sender: sojkam1)\r
+       by imap.feld.cvut.cz (Postfix) with ESMTPSA id 4D39F660904;\r
+       Wed,  5 Sep 2012 23:08:12 +0200 (CEST)\r
+Received: from wsh by steelpick.2x.cz with local (Exim 4.80)\r
+       (envelope-from <sojkam1@fel.cvut.cz>)\r
+       id 1T9MpX-000675-QZ; Wed, 05 Sep 2012 23:08:11 +0200\r
+From: Michal Sojka <sojkam1@fel.cvut.cz>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 0/5] emacs: notmuch-hello status message refresh hook,\r
+       etc\r
+In-Reply-To: <877gs9msy8.fsf@nikula.org>\r
+References: <cover.1346596156.git.jani@nikula.org>\r
+       <87vcftbtmw.fsf@steelpick.2x.cz> <877gs9msy8.fsf@nikula.org>\r
+User-Agent: Notmuch/0.14+3~g608c52f (http://notmuchmail.org) Emacs/24.1.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 05 Sep 2012 23:08:11 +0200\r
+Message-ID: <87zk54yy84.fsf@steelpick.2x.cz>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 05 Sep 2012 21:08:27 -0000\r
+\r
+On Tue, Sep 04 2012, Jani Nikula wrote:\r
+> On Tue, 04 Sep 2012, Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+>> On Sun, Sep 02 2012, Jani Nikula wrote:\r
+>>> Hi all, v2 of [1] addressing review comments: added NEWS, improved\r
+>>> documentation, made the query customizable.\r
+>>>\r
+>>> [1]\r
+>>>     id:"37899e28dbf67e4620a53279a869be3174c02d6f.1339775602.git.jani@nikula.org"\r
+>>\r
+>> Hello Jani,\r
+>>\r
+>> if I understand correctly, the goal of this patchset is to display the\r
+>> message with the difference in the number of messages before and after\r
+>> refresh of notmuch-hello.\r
+>\r
+> Difference between two refreshes of notmuch-hello to be specific.\r
+>\r
+>> I think the current implementation is unnecessarily complicated. It\r
+>> would be sufficient to implement this directly in `notmuch-hello'\r
+>> without any hook. If `notmuch-hello-refresh-status-query' is nil\r
+>> (default) no message would be shown. If it is configured to something\r
+>> else, the message would be shown provided that no-display is nil. This\r
+>> way you don't have to break existing user's hooks and achieve the same\r
+>> behavior, don't you?\r
+>\r
+> I think it would be useful to pass no-display to hooks anyway,\r
+> regardless of the use here.\r
+\r
+I'm strongly against breaking existing user's setups without a good\r
+reason. The meaning of no-display parameter, as I understand it, is only\r
+to tells whether the refresh should happen in background or foreground.\r
+Isn't there any other method for hooks to check for this conditions? For\r
+example something like checking whether notmuch-hello buffer is shown in\r
+a window of the active frame? Or a simple (perhaps buffer-local)\r
+variable can contain this information.\r
+\r
+I don't know what people use notmuch-hello-refresh-hook for. I suppose\r
+that your use case (displaying a message outside of hello buffer) is\r
+rather an exception than a typical use.\r
+\r
+> I don't see that as a big reason to do this one way or the other.\r
+> Having this implemented directly in notmuch-hello does not make this\r
+> less complicated either.\r
+\r
+That's true, but it would be simpler for users to set it up. With your\r
+patches, users would have to configure the variable (query) as well as\r
+the hook. I propose to have only one place to configure this feature.\r
+\r
+-Michal\r