--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id BF286431FB6\r
+ for <notmuch@notmuchmail.org>; Wed, 18 Jul 2012 14:54:58 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id JpBIvdJ4azrD for <notmuch@notmuchmail.org>;\r
+ Wed, 18 Jul 2012 14:54:58 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 1ABF3431FAF\r
+ for <notmuch@notmuchmail.org>; Wed, 18 Jul 2012 14:54:58 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1SrcCn-00024F-Ea; Wed, 18 Jul 2012 22:54:49 +0100\r
+Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]\r
+ helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1SrcCn-0001bQ-4l; Wed, 18 Jul 2012 22:54:49 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: Make moving to the previous message move to the\r
+ previous boundary\r
+In-Reply-To: <1342237668-2489-1-git-send-email-amdragon@mit.edu>\r
+References: <1342237668-2489-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.13.2+90~g84fa1ef (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Wed, 18 Jul 2012 22:54:48 +0100\r
+Message-ID: <87sjcod9av.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 94.192.233.223\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: 4648ca5fd1a1c0bef1bbd607d0bab38e (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -1.8 points.\r
+ Summary of the scoring: \r
+ * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+ * medium trust\r
+ * [138.37.6.40 listed in list.dnswl.org]\r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay\r
+ * domain\r
+ * 0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 18 Jul 2012 21:54:58 -0000\r
+\r
+On Sat, 14 Jul 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> Previously, notmuch-show-previous-message would move to the beginning\r
+> of the message before the message containing point. This patch makes\r
+> it instead move to the previous message *boundary*. That is, if point\r
+> isn't already at the beginning of the message, it moves to the\r
+> beginning of the current message. This is consistent with\r
+> notmuch-show-next-message, which can be thought of as moving to the\r
+> next message boundary. Several people have expressed a preference for\r
+> this.\r
+\r
+I like this change: the current behaviour has mildly confused/annoyed me\r
+in the past.\r
+\r
+>\r
+> This patch accompanies the series in [0] (though they're independent\r
+> and can be applied in either order). This makes the behavior of 'p'\r
+> and 'P' in show-mode conceptually similar to the new behavior of 'p'\r
+> in search-mode.\r
+>\r
+> [0] 1342140319-19859-1-git-send-email-amdragon@mit.edu\r
+>\r
+> emacs/notmuch-show.el | 10 +++++++---\r
+> 1 file changed, 7 insertions(+), 3 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index 6335d45..02e319f 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -1525,9 +1525,11 @@ thread, navigate to the next thread in the parent search buffer."\r
+> (goto-char (point-max)))))\r
+> \r
+> (defun notmuch-show-previous-message ()\r
+> - "Show the previous message."\r
+> + "Show the previous message or the start of the current message."\r
+> (interactive)\r
+> - (notmuch-show-goto-message-previous)\r
+> + (if (= (point) (notmuch-show-message-top))\r
+> + (notmuch-show-goto-message-previous)\r
+> + (notmuch-show-move-to-message-top))\r
+> (notmuch-show-mark-read)\r
+> (notmuch-show-message-adjust))\r
+> \r
+> @@ -1587,7 +1589,9 @@ to show, nil otherwise."\r
+> (defun notmuch-show-previous-open-message ()\r
+> "Show the previous open message."\r
+> (interactive)\r
+> - (while (and (notmuch-show-goto-message-previous)\r
+> + (while (and (if (= (point) (notmuch-show-message-top))\r
+> + (notmuch-show-goto-message-previous)\r
+> + (notmuch-show-move-to-message-top))\r
+> (not (notmuch-show-message-visible-p))))\r
+> (notmuch-show-mark-read)\r
+> (notmuch-show-message-adjust))\r
+\r
+I would mildly prefer taking the testing for top of message out of the\r
+loop (I know it's one line longer) as\r
+\r
+ (if (= (point) (notmuch-show-message-top))\r
+ (notmuch-show-goto-message-previous)\r
+ (notmuch-show-move-to-message-top))\r
+ (while (and (not (notmuch-show-message-visible-p))\r
+ (notmuch-show-goto-message-previous)))\r
+\r
+but its obviously fine as is.\r
+\r
+Best wishes\r
+\r
+Mark\r
projects / notmuch-archives.git / commitdiff