Re: Strings vs symbols in notmuch-search-result-format

diff --git a/6f/b7b4f810af6cf297c9b5c53b0736cd05ab8439 b/6f/b7b4f810af6cf297c9b5c53b0736cd05ab8439
new file mode 100644 (file)
index 0000000..c72981d
--- /dev/null
+++ b/6f/b7b4f810af6cf297c9b5c53b0736cd05ab8439
@@ -0,0 +1,88 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0A46F40DBE4\r
+       for <notmuch@notmuchmail.org>; Thu, 11 Nov 2010 17:35:02 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.89\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5\r
+       tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01]\r
+       autolearn=ham\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 0MYP9APYVqhu; Thu, 11 Nov 2010 17:34:50 -0800 (PST)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id A111940DBE8;\r
+       Thu, 11 Nov 2010 17:34:50 -0800 (PST)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+       id 4BF7925412B; Thu, 11 Nov 2010 17:34:50 -0800 (PST)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Rob Browning <rlb@defaultvalue.org>, notmuch@notmuchmail.org\r
+Subject: Re: Strings vs symbols in notmuch-search-result-format\r
+In-Reply-To: <87mxrnn964.fsf@raven.defaultvalue.org>\r
+References: <87mxrnn964.fsf@raven.defaultvalue.org>\r
+User-Agent: Notmuch/0.4 (http://notmuchmail.org) Emacs/23.2.1\r
+       (i486-pc-linux-gnu)\r
+Date: Thu, 11 Nov 2010 17:34:50 -0800\r
+Message-ID: <878w0zmiit.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 12 Nov 2010 01:35:02 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Sat, 11 Sep 2010 18:37:55 -0500, Rob Browning <rlb@defaultvalue.org> wro=\r
+te:\r
+> I've started to look at the elisp, and wondered why\r
+> notmuch-search-result-format expected strings rather than symbols for\r
+> the field names, i.e.:\r
+...\r
+> Perhaps there's a good argument for strings, but if not, the latter is\r
+> more idiomatic, and a bit more efficient too (comparisons will just be\r
+> pointer compares (via assq) rather than something like a strcmp (assoc)).\r
+\r
+\r
+I'm not sure that this is my code. But I do know that most of the emacs\r
+lisp code I've written is very non-idiomatic and without good\r
+justification.\r
+\r
+Please don't look at my elisp code and assume it is sane at all. I'm\r
+looking forward to the day where "git blame -- emacs/*.el" doesn't show\r
+my name at all...\r
+\r
+Said another way, please feel free to post improvements for any strange\r
+elisp you see, (C code too, of course).\r
+\r
+=2DCarl\r
+\r
+=2D-=20\r
+carl.d.worth@intel.com\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.10 (GNU/Linux)\r
+\r
+iD8DBQFM3Jm66JDdNq8qSWgRAnpwAKCTsvGL91PmrD1T2XYyqvxMkJn85QCfZyvd\r
+ALZ0nGS5M9PoOT47eebSvgk=\r
+=5hjE\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r