Re: [PATCH] test: fix test_require_external_prereq gdb in insert test

diff --git a/76/8361a6e5bc485d69fd6ae7c1fe659da4930065 b/76/8361a6e5bc485d69fd6ae7c1fe659da4930065
new file mode 100644 (file)
index 0000000..02561cb
--- /dev/null
+++ b/76/8361a6e5bc485d69fd6ae7c1fe659da4930065
@@ -0,0 +1,85 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 18A83431FBF\r
+       for <notmuch@notmuchmail.org>; Tue, 28 Oct 2014 13:57:01 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id yvJ9FgB-SU+w for <notmuch@notmuchmail.org>;\r
+       Tue, 28 Oct 2014 13:56:53 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 13F83431FB6\r
+       for <notmuch@notmuchmail.org>; Tue, 28 Oct 2014 13:56:53 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1XjDox-0003db-UB; Tue, 28 Oct 2014 17:56:51 -0300\r
+Received: (nullmailer pid 2918 invoked by uid 1000); Tue, 28 Oct 2014\r
+       20:56:46 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] test: fix test_require_external_prereq gdb in insert test\r
+In-Reply-To: <877fzk0ylr.fsf@nikula.org>\r
+References: <1414518754-16344-1-git-send-email-jani@nikula.org>\r
+       <87a94g2h7t.fsf@maritornes.cs.unb.ca> <877fzk0ylr.fsf@nikula.org>\r
+User-Agent: Notmuch/0.18.1+131~gdd8373f (http://notmuchmail.org) Emacs/24.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 28 Oct 2014 21:56:46 +0100\r
+Message-ID: <87y4rz29rl.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 28 Oct 2014 20:57:01 -0000\r
+\r
+Jani Nikula <jani@nikula.org> writes:\r
+\r
+\r
+>> Of course you're right that moving it forward to only skip the gdb\r
+>> requiring tests is the right thing to do, and in that setting having a\r
+>> skipped message for all 10 skipped tests is a bit ugly. OTOHO your\r
+>> version doesn't give any output at all, which seems not perfect either.\r
+>\r
+> How does it work if you just move the prereq test forward?\r
+>\r
+\r
+Then we get one message per skipped test. So twenty lines it total.\r
+\r
+ missing prerequisites: gdb(1)\r
+ SKIP   error exit when add_message returns OUT_OF_MEMORY\r
+ missing prerequisites: gdb(1)\r
+ SKIP   success exit with --keep when add_message returns OUT_OF_MEMORY\r
+ missing prerequisites: gdb(1)\r
+ SKIP   error exit when add_message returns XAPIAN_EXCEPTION\r
+ missing prerequisites: gdb(1)\r
+ SKIP   success exit with --keep when add_message returns XAPIAN_EXCEPTION\r
+ missing prerequisites: gdb(1)\r
+ SKIP   error exit when add_message returns FILE_NOT_EMAIL\r
+ missing prerequisites: gdb(1)\r
+ SKIP   success exit with --keep when add_message returns FILE_NOT_EMAIL\r
+ missing prerequisites: gdb(1)\r
+ SKIP   error exit when add_message returns READ_ONLY_DATABASE\r
+ missing prerequisites: gdb(1)\r
+ SKIP   success exit with --keep when add_message returns READ_ONLY_DATABASE\r
+ missing prerequisites: gdb(1)\r
+ SKIP   error exit when add_message returns UPGRADE_REQUIRED\r
+ missing prerequisites: gdb(1)\r
+ SKIP   success exit with --keep when add_message returns UPGRADE_REQUIRED\r