Re: [PATCH] _notmuch_message_index_file: unref (free) address lists from gmime.

diff --git a/7c/3e3aa44b1889c8163b89f5ed657d8d0c1088de b/7c/3e3aa44b1889c8163b89f5ed657d8d0c1088de
new file mode 100644 (file)
index 0000000..650a0d6
--- /dev/null
+++ b/7c/3e3aa44b1889c8163b89f5ed657d8d0c1088de
@@ -0,0 +1,126 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0A4DE431FAF\r
+       for <notmuch@notmuchmail.org>; Mon, 24 Dec 2012 12:32:54 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Tz2Cug1cLpnP for <notmuch@notmuchmail.org>;\r
+       Mon, 24 Dec 2012 12:32:52 -0800 (PST)\r
+Received: from dmz-mailsec-scanner-5.mit.edu (DMZ-MAILSEC-SCANNER-5.MIT.EDU\r
+       [18.7.68.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 92296431FAE\r
+       for <notmuch@notmuchmail.org>; Mon, 24 Dec 2012 12:32:52 -0800 (PST)\r
+X-AuditID: 12074422-b7f616d000000e7c-4d-50d8bbf3b157\r
+Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
+       by dmz-mailsec-scanner-5.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id B4.AF.03708.3FBB8D05; Mon, 24 Dec 2012 15:32:51 -0500 (EST)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id qBOKWojZ012582; \r
+       Mon, 24 Dec 2012 15:32:50 -0500\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id qBOKWlIe027329\r
+       (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
+       Mon, 24 Dec 2012 15:32:48 -0500 (EST)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1TnEhb-0008LK-59; Mon, 24 Dec 2012 15:32:47 -0500\r
+From: Austin Clements <aclements@csail.mit.edu>\r
+To: david@tethera.net, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] _notmuch_message_index_file: unref (free) address lists\r
+       from gmime.\r
+In-Reply-To: <1355196820-29734-1-git-send-email-david@tethera.net>\r
+References: <1355188740-6663-1-git-send-email-david@tethera.net>\r
+       <1355196820-29734-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.14+236~gf64406d (http://notmuchmail.org) Emacs/23.4.1\r
+       (i486-pc-linux-gnu)\r
+Date: Mon, 24 Dec 2012 15:32:46 -0500\r
+Message-ID: <87txrbkx75.fsf@awakening.csail.mit.edu>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFvrGIsWRmVeSWpSXmKPExsUixCmqrft5940Ag47XfBYbl/1ktrjR2s1o\r
+       cf3mTGYHZo9fbXOZPZ6tusXsseXQe+YA5igum5TUnMyy1CJ9uwSujIbLp9gKmngrXt/cwNrA\r
+       eICri5GTQ0LARGLHjytMELaYxIV769m6GLk4hAT2MUpMmX2VGcLZwCjRf3onVOYik8Snyc+Z\r
+       IJwljBI9bbdYQfrZBPQlVqydBGRzcIgI6Eks3CoDEmYWUJOYtOYMO4gtLBAhcb1rHpjNKeAk\r
+       0dF9kxnEFhIok5h1cTqYLSoQL/H83jcWEJtFQFXi1+KpYCN5gU69OgEszCsgKHFy5hMWiPFa\r
+       Ejf+vWSawCg4C0lqFpLUAkamVYyyKblVurmJmTnFqcm6xcmJeXmpRbqmermZJXqpKaWbGEHB\r
+       y+6itIPx50GlQ4wCHIxKPLwFk28ECLEmlhVX5h5ilORgUhLl9d0FFOJLyk+pzEgszogvKs1J\r
+       LT7EKMHBrCTCy70OKMebklhZlVqUD5OS5mBREue9lnLTX0ggPbEkNTs1tSC1CCYrw8GhJMF7\r
+       EWSoYFFqempFWmZOCUKaiYMTZDgP0PBlIDW8xQWJucWZ6RD5U4yKUuK8LSAJAZBERmkeXC8s\r
+       ubxiFAd6RZi3HqSKB5iY4LpfAQ1mAhocywc2uCQRISXVwNg584nWnqan9+ZbnDr95+05gfOv\r
+       vLUuPLCqS/64+OkTuzfO3+bMKpLb4asjIHbgpJaphrZpfsAcjq5/K+xMJHyNkzMD3zzK9Mj6\r
+       UZTkX152VniVTlLb/KDYy8/uqc1xrulqCU7P3u2Z/+PMrt8dLlo+Zhfuzdpjyyby9+/mljDu\r
+       lTf+3HpyS1KJpTgj0VCLuag4EQDfwg6GCQMAAA==\r
+Cc: David Bremner <bremner@debian.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 24 Dec 2012 20:32:54 -0000\r
+\r
+This patch LGTM.\r
+\r
+On Mon, 10 Dec 2012, david@tethera.net wrote:\r
+> From: David Bremner <bremner@debian.org>\r
+>\r
+> Apparently as of GMime 2.4, you don't need to call\r
+> internet_address_list_destroy anymore, but you still need to call\r
+> g_object_unref (from the GMime Changelog).\r
+>\r
+> On the medium performance corpus, valgrind shows "possibly lost"\r
+> leakage in "notmuch new" dropping from 7M to 300k.\r
+> ---\r
+>  lib/index.cc |   12 +++++++++---\r
+>  1 file changed, 9 insertions(+), 3 deletions(-)\r
+>\r
+> diff --git a/lib/index.cc b/lib/index.cc\r
+> index da0e6ce..a2edd6d 100644\r
+> --- a/lib/index.cc\r
+> +++ b/lib/index.cc\r
+> @@ -484,12 +484,18 @@ mboxes is deprecated and may be removed in the future.\n", filename);\r
+>      }\r
+>  \r
+>      from = g_mime_message_get_sender (mime_message);\r
+> -    addresses = internet_address_list_parse_string (from);\r
+>  \r
+> -    _index_address_list (message, "from", addresses);\r
+> +    addresses = internet_address_list_parse_string (from);\r
+> +    if (addresses) {\r
+> +    _index_address_list (message, "from", addresses);\r
+> +    g_object_unref (addresses);\r
+> +    }\r
+>  \r
+>      addresses = g_mime_message_get_all_recipients (mime_message);\r
+> -    _index_address_list (message, "to", addresses);\r
+> +    if (addresses) {\r
+> +    _index_address_list (message, "to", addresses);\r
+> +    g_object_unref (addresses);\r
+> +    }\r
+>  \r
+>      subject = g_mime_message_get_subject (mime_message);\r
+>      _notmuch_message_gen_terms (message, "subject", subject);\r
+> -- \r
+> 1.7.10.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r