Re: [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the...

diff --git a/67/a4bc75a33c2c742f3cbedaa963cc3f25e96ce9 b/67/a4bc75a33c2c742f3cbedaa963cc3f25e96ce9
new file mode 100644 (file)
index 0000000..c792029
--- /dev/null
+++ b/67/a4bc75a33c2c742f3cbedaa963cc3f25e96ce9
@@ -0,0 +1,121 @@
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 537B5429E34\r
+       for <notmuch@notmuchmail.org>; Tue, 31 Jan 2012 00:25:47 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id PQi8AoQPDUnq for <notmuch@notmuchmail.org>;\r
+       Tue, 31 Jan 2012 00:25:46 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+       [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 8605B431E64\r
+       for <notmuch@notmuchmail.org>; Tue, 31 Jan 2012 00:25:46 -0800 (PST)\r
+Received: by bke11 with SMTP id 11so2276244bke.26\r
+       for <notmuch@notmuchmail.org>; Tue, 31 Jan 2012 00:25:45 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type;\r
+       bh=oha9sH6fopClXRnD8kIgbDt1DvmCCZss5LxVp2+xnjg=;\r
+       b=MrjcOWgeGhEqIG41njW1VGTgBy2XC2TafFZ8qX6VO8gfz8FOklok0PS7j/HtrKP2di\r
+       /9qXmJkSHpr7JvVHR5fhz8pD5Ww0HObS70adpN0b11xCm335yZeURc+8zrUEbNBI9Fd2\r
+       tfnihs92KLNV/QtXpNAndijPsHNUmVphsUqFo=\r
+Received: by 10.205.132.138 with SMTP id hu10mr9950153bkc.117.1327998345194;\r
+       Tue, 31 Jan 2012 00:25:45 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+       by mx.google.com with ESMTPS id bw9sm43487518bkb.8.2012.01.31.00.25.42\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Tue, 31 Jan 2012 00:25:43 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/2] emacs: Don't move to the next thread unless the\r
+       cursor is at the end of the buffer.\r
+In-Reply-To: <cunaa54b7sz.fsf@hotblack-desiato.hh.sledj.net>\r
+References: <1327996914-9644-1-git-send-email-dme@dme.org>\r
+       <1327996914-9644-3-git-send-email-dme@dme.org>\r
+       <87bopknvct.fsf@gmail.com>\r
+       <cunaa54b7sz.fsf@hotblack-desiato.hh.sledj.net>\r
+User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 31 Jan 2012 12:24:27 +0400\r
+Message-ID: <877h08nutg.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 31 Jan 2012 08:25:47 -0000\r
+\r
+On Tue, 31 Jan 2012 08:22:20 +0000, David Edmondson <dme@dme.org> wrote:\r
+> On Tue, 31 Jan 2012 12:12:50 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
+> > On Tue, 31 Jan 2012 08:01:54 +0000, David Edmondson <dme@dme.org> wrote:\r
+> > > When using the spacebar to scroll through a thread, hitting 'space'\r
+> > > when the bottom of the last message is visible should take the cursor\r
+> > > to the end of the buffer rather than immediately archiving the thread\r
+> > > and moving to the next thread.\r
+> > > ---\r
+> > \r
+> > I did not notice this change yet, so +0\r
+> > \r
+> > A style comment below.\r
+> > \r
+> > >  emacs/notmuch-show.el |    5 +++++\r
+> > >  1 files changed, 5 insertions(+), 0 deletions(-)\r
+> > > \r
+> > > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> > > index ec72ff8..3f54de0 100644\r
+> > > --- a/emacs/notmuch-show.el\r
+> > > +++ b/emacs/notmuch-show.el\r
+> > > @@ -1319,6 +1319,11 @@ current window), advance to the next open message."\r
+> > >        ;; This is not the last message - move to the next visible one.\r
+> > >        (notmuch-show-next-open-message))\r
+> > >  \r
+> > > +     ((not (= (point) (point-max)))\r
+> > > +      ;; This is the last message, but the cursor is not at the end of\r
+> > > +      ;; the buffer. Move it there.\r
+> > > +      (goto-char (point-max)))\r
+> > \r
+> > Perhaps `unless' would be better here?\r
+> \r
+> It's the CONDITION clause of `cond', so that wouldn't be appropriate.\r
+> \r
+\r
+oh\r
+\r
+This is why I like big diff contexts...\r
+\r
+Regards,\r
+  Dmitry\r
+\r
+> > Regards,\r
+> >   Dmitry\r
+> > \r
+> > > +\r
+> > >       (t\r
+> > >        ;; This is the last message - change the return value\r
+> > >        (setq ret t)))\r
+> > > -- \r
+> > > 1.7.8.3\r
+> > > \r
+> > > _______________________________________________\r
+> > > notmuch mailing list\r
+> > > notmuch@notmuchmail.org\r
+> > > http://notmuchmail.org/mailman/listinfo/notmuch\r