--- /dev/null
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 228B3431E64\r
+ for <notmuch@notmuchmail.org>; Thu, 1 Mar 2012 00:48:19 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+ autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id yBhCNYRrLTOx for <notmuch@notmuchmail.org>;\r
+ Thu, 1 Mar 2012 00:48:18 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])\r
+ by olra.theworths.org (Postfix) with ESMTP id 3C310431FAE\r
+ for <notmuch@notmuchmail.org>; Thu, 1 Mar 2012 00:48:18 -0800 (PST)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+ id 007F968055; Thu, 1 Mar 2012 10:48:16 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 0/5] Disable search.exclude_tags for 0.12\r
+In-Reply-To: <1330539189-16593-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1330539189-16593-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.11.1+246~gbf28c60 (http://notmuchmail.org) Emacs/23.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 01 Mar 2012 10:48:16 +0200\r
+Message-ID: <m27gz4emgf.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 01 Mar 2012 08:48:19 -0000\r
+\r
+On Wed, 29 Feb 2012 18:13:04 +0000, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> As requested by David (Bremner) on irc here is a patch series\r
+> disabling the search.exclude_tags feature as a temporary measure for\r
+> the 0.12 release.\r
+> \r
+> There are two options:\r
+> \r
+> The first is to disable the addition of the new search.exclude_tags\r
+> item to the config file and stop setup from asking for it.\r
+> \r
+> The second is to do the above and also disable the functionality in\r
+> notmuch-search.c and notmuch-count.c.\r
+\r
+I first thought that "full" revert would be best in order to reduce\r
+confusion, but now I'd vote for just disabling the addition but leaving\r
+the feature there.\r
+This way the bleeding edge users who already use this feature could\r
+test the release branch version in daily use. As the feature is there\r
+some brave future 0.12 users can start experimenting with it earlyer\r
+and potentially provide feedback. Finally, as the delta is smaller\r
+there is less management activities to be done.\r
+Marking the feature as 'experimental' in namual page & other documentation\r
+would be good idea.\r
+\r
+Tomi\r
+\r
+> The idea is that this these are minimal (and thus relatively safe)\r
+> changes to make. With the first option users who have configured the\r
+> functionality for themselves (while using git) will still get the\r
+> feature: it just won't be pushed on users. With the second option the\r
+> festure will be completely disabled.\r
+> \r
+> Essentially patch 1 implements the first option and patch 4 the second\r
+> option. The other patches in the series update the NEWS file, the man\r
+> page and the tests. If going for the first option then I would suggest\r
+> applying (in addition to patch 1) patch 2 (NEWS) and probably patch 3\r
+> (man) although as the functionality remains the latter is not strictly\r
+> necessary. The test patch (patch 5) is not necessary as the tests set\r
+> search.exclude_tags directly.\r
+> \r
+> If going for the second option then all the patches are needed.\r
+> \r
+> Finally, please could someone familiar with the config/setup code\r
+> check patch 1 carefully. I have never looked at that code before and\r
+> could easily have done something stupid.\r
+> \r
+> Best wishes\r
+> \r
+> Mark\r
+> \r
+> Mark Walters (5):\r
+> config: disable addition of exclude tags for 0.12\r
+> NEWS: revert NEWS item for exclude tags for 0.12\r
+> man: remove search.exclude_tags from notmuch-config.1 for 0.12\r
+> cli: temporarily remove exclude tag support for 0.12\r
+> test: mark exclude tests broken for 0.12\r
+> \r
+> NEWS | 18 ------------------\r
+> man/man1/notmuch-config.1 | 8 --------\r
+> notmuch-config.c | 3 +--\r
+> notmuch-count.c | 8 +-------\r
+> notmuch-search.c | 8 +-------\r
+> notmuch-setup.c | 19 +------------------\r
+> test/search | 2 ++\r
+> 7 files changed, 6 insertions(+), 60 deletions(-)\r
+> \r
+> -- \r
+> 1.7.2.3\r
+> \r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
+> \r
projects / notmuch-archives.git / commitdiff