[PATCH 2/4] notmuch-dump: convert to command-line-arguments

diff --git a/78/977922b70415aabcfe0d4200439161422f49f3 b/78/977922b70415aabcfe0d4200439161422f49f3
new file mode 100644 (file)
index 0000000..6955008
--- /dev/null
+++ b/78/977922b70415aabcfe0d4200439161422f49f3
@@ -0,0 +1,116 @@
+Return-Path: <bremner@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 752AE431FD0\r
+       for <notmuch@notmuchmail.org>; Wed,  7 Dec 2011 04:34:59 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id DV1ior2gkt+6 for <notmuch@notmuchmail.org>;\r
+       Wed,  7 Dec 2011 04:34:58 -0800 (PST)\r
+Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 850D2429E30\r
+       for <notmuch@notmuchmail.org>; Wed,  7 Dec 2011 04:34:57 -0800 (PST)\r
+Received: from zancas.localnet\r
+       (fctnnbsc36w-156034079193.pppoe-dynamic.High-Speed.nb.bellaliant.net\r
+       [156.34.79.193]) (authenticated bits=0)\r
+       by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id pB7CYqVf007120\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO);\r
+       Wed, 7 Dec 2011 08:34:53 -0400\r
+Received: from bremner by zancas.localnet with local (Exim 4.77)\r
+       (envelope-from <bremner@tethera.net>)\r
+       id 1RYGi4-0007mw-KR; Wed, 07 Dec 2011 08:34:52 -0400\r
+From: David Bremner <david@tethera.net>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH 2/4] notmuch-dump: convert to command-line-arguments\r
+Date: Wed,  7 Dec 2011 08:34:38 -0400\r
+Message-Id: <1323261280-29907-2-git-send-email-david@tethera.net>\r
+X-Mailer: git-send-email 1.7.7.3\r
+In-Reply-To: <1323261280-29907-1-git-send-email-david@tethera.net>\r
+References: <87iplso9c9.fsf@zancas.localnet>\r
+       <1323261280-29907-1-git-send-email-david@tethera.net>\r
+Cc: David Bremner <bremner@debian.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 07 Dec 2011 12:34:59 -0000\r
+\r
+From: David Bremner <bremner@debian.org>\r
+\r
+The output file is handled via positional arguments. There are\r
+currently no "normal" options.\r
+---\r
+ notmuch-dump.c |   31 +++++++++++++++++++------------\r
+ 1 files changed, 19 insertions(+), 12 deletions(-)\r
+\r
+diff --git a/notmuch-dump.c b/notmuch-dump.c\r
+index a490917..c568734 100644\r
+--- a/notmuch-dump.c\r
++++ b/notmuch-dump.c\r
+@@ -41,27 +41,34 @@ notmuch_dump_command (unused (void *ctx), int argc, char *argv[])\r
+     if (notmuch == NULL)\r
+       return 1;\r
+ \r
+-    argc--; argv++; /* skip subcommand argument */\r
++    char *output_file_name = NULL;\r
++    int opt_index;\r
+ \r
+-    if (argc && strcmp (argv[0], "--") != 0) {\r
++    notmuch_opt_desc_t options[] = {\r
++      { "out-file", 'o', NOTMUCH_OPT_POSITION, 0, &output_file_name },\r
++      { 0, 0, 0, 0, 0 }\r
++    };\r
++\r
++    opt_index = parse_arguments (argc, argv, options, 1);\r
++\r
++    if (opt_index < 0) {\r
++      /* diagnostics already printed */\r
++      exit(1);\r
++    }\r
++\r
++    if (output_file_name) {\r
+       fprintf (stderr, "Warning: the output file argument of dump is deprecated.\n");\r
+-      output = fopen (argv[0], "w");\r
++      output = fopen (output_file_name, "w");\r
+       if (output == NULL) {\r
+           fprintf (stderr, "Error opening %s for writing: %s\n",\r
+-                   argv[0], strerror (errno));\r
++                   output_file_name, strerror (errno));\r
+           return 1;\r
+       }\r
+-      argc--;\r
+-      argv++;\r
+     }\r
+ \r
+-    if (argc && strcmp (argv[0], "--") == 0){\r
+-      argc--;\r
+-      argv++;\r
+-    }\r
+ \r
+-    if (argc) {\r
+-      query_str = query_string_from_args (notmuch, argc, argv);\r
++    if (opt_index < argc) {\r
++      query_str = query_string_from_args (notmuch, argc-opt_index, argv+opt_index);\r
+       if (query_str == NULL) {\r
+           fprintf (stderr, "Out of memory.\n");\r
+           return 1;\r
+-- \r
+1.7.7.3\r
+\r