Re: [PATCH] _notmuch_message_index_file: unref (free) address lists from gmime.

diff --git a/ab/1ce4ecf65bf33d1555639525344a2dc5023aef b/ab/1ce4ecf65bf33d1555639525344a2dc5023aef
new file mode 100644 (file)
index 0000000..f911b5a
--- /dev/null
+++ b/ab/1ce4ecf65bf33d1555639525344a2dc5023aef
@@ -0,0 +1,106 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id D3491431FAF\r
+       for <notmuch@notmuchmail.org>; Mon, 10 Dec 2012 20:55:35 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 9WDbOVWpV-3P for <notmuch@notmuchmail.org>;\r
+       Mon, 10 Dec 2012 20:55:35 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 43222431FAE\r
+       for <notmuch@notmuchmail.org>; Mon, 10 Dec 2012 20:55:35 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 3487D10007E;\r
+       Tue, 11 Dec 2012 06:55:31 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: david@tethera.net, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] _notmuch_message_index_file: unref (free) address lists\r
+       from gmime.\r
+In-Reply-To: <1355196820-29734-1-git-send-email-david@tethera.net>\r
+References: <1355188740-6663-1-git-send-email-david@tethera.net>\r
+       <1355196820-29734-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.14+116~g29fcdb5 (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 11 Dec 2012 06:55:31 +0200\r
+Message-ID: <m27gopfarg.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: David Bremner <bremner@debian.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 11 Dec 2012 04:55:36 -0000\r
+\r
+On Tue, Dec 11 2012, david@tethera.net wrote:\r
+\r
+> From: David Bremner <bremner@debian.org>\r
+>\r
+> Apparently as of GMime 2.4, you don't need to call\r
+> internet_address_list_destroy anymore, but you still need to call\r
+> g_object_unref (from the GMime Changelog).\r
+>\r
+> On the medium performance corpus, valgrind shows "possibly lost"\r
+> leakage in "notmuch new" dropping from 7M to 300k.\r
+> ---\r
+\r
+LGTM.\r
+\r
+Tomi\r
+\r
+\r
+>  lib/index.cc |   12 +++++++++---\r
+>  1 file changed, 9 insertions(+), 3 deletions(-)\r
+>\r
+> diff --git a/lib/index.cc b/lib/index.cc\r
+> index da0e6ce..a2edd6d 100644\r
+> --- a/lib/index.cc\r
+> +++ b/lib/index.cc\r
+> @@ -484,12 +484,18 @@ mboxes is deprecated and may be removed in the future.\n", filename);\r
+>      }\r
+>  \r
+>      from = g_mime_message_get_sender (mime_message);\r
+> -    addresses = internet_address_list_parse_string (from);\r
+>  \r
+> -    _index_address_list (message, "from", addresses);\r
+> +    addresses = internet_address_list_parse_string (from);\r
+> +    if (addresses) {\r
+> +    _index_address_list (message, "from", addresses);\r
+> +    g_object_unref (addresses);\r
+> +    }\r
+>  \r
+>      addresses = g_mime_message_get_all_recipients (mime_message);\r
+> -    _index_address_list (message, "to", addresses);\r
+> +    if (addresses) {\r
+> +    _index_address_list (message, "to", addresses);\r
+> +    g_object_unref (addresses);\r
+> +    }\r
+>  \r
+>      subject = g_mime_message_get_subject (mime_message);\r
+>      _notmuch_message_gen_terms (message, "subject", subject);\r
+> -- \r
+> 1.7.10.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r