Re: [BUG/PATCH v2] emacs: Fix the References header in reply

diff --git a/a6/609cfa34551ea9ea811124f950cba8c4d47f79 b/a6/609cfa34551ea9ea811124f950cba8c4d47f79
new file mode 100644 (file)
index 0000000..aa1e917
--- /dev/null
+++ b/a6/609cfa34551ea9ea811124f950cba8c4d47f79
@@ -0,0 +1,117 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 48D2B431FAF\r
+       for <notmuch@notmuchmail.org>; Thu, 29 Mar 2012 10:37:13 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.29\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 5zsWe-9coJsv for <notmuch@notmuchmail.org>;\r
+       Thu, 29 Mar 2012 10:37:11 -0700 (PDT)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7C1F0431FAE\r
+       for <notmuch@notmuchmail.org>; Thu, 29 Mar 2012 10:37:11 -0700 (PDT)\r
+Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by earth-doxen-postvirus (Postfix) with ESMTP id 106B866E019B;\r
+       Thu, 29 Mar 2012 10:37:09 -0700 (PDT)\r
+X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new\r
+Received: from finestructure.net (DHCP-123-229.caltech.edu [131.215.123.229])\r
+       (Authenticated sender: jrollins)\r
+       by earth-doxen-submit (Postfix) with ESMTP id 900D366E012C;\r
+       Thu, 29 Mar 2012 10:37:05 -0700 (PDT)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id 5287D139; Thu, 29 Mar 2012 10:37:04 -0700 (PDT)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Adam Wolfe Gordon <awg+notmuch@xvx.ca>\r
+Subject: Re: [BUG/PATCH v2] emacs: Fix the References header in reply\r
+In-Reply-To:\r
+ <CAMoJFUsqkmQDh6apmu+VMp40E7zb6n+Bonhi37d+sN1ORV5bOA@mail.gmail.com>\r
+References: <1332991226-510-1-git-send-email-awg+notmuch@xvx.ca>\r
+       <1332996818-15700-1-git-send-email-awg+notmuch@xvx.ca>\r
+       <87aa2zjpmg.fsf@servo.finestructure.net>\r
+       <CAMoJFUsqkmQDh6apmu+VMp40E7zb6n+Bonhi37d+sN1ORV5bOA@mail.gmail.com>\r
+User-Agent: Notmuch/0.12+78~g127fa56 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 29 Mar 2012 10:37:01 -0700\r
+Message-ID: <87obrf48ci.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 29 Mar 2012 17:37:13 -0000\r
+\r
+--=-=-=\r
+\r
+On Thu, Mar 29 2012, Adam Wolfe Gordon <awg+notmuch@xvx.ca> wrote:\r
+> That's actually fixed by the new version [1]. As Austin mentioned in\r
+> his review, the order of message-header-format-alist determines the\r
+> order of the headers.\r
+>\r
+> [1] id:"1333038410-17927-3-git-send-email-awg+notmuch@xvx.ca"\r
+\r
+Awesome!  Thanks so much Adam!  I just tested it and it works great:\r
+solves the issue and the headers are in a nice order.  Thanks again for\r
+the quick fix.\r
+\r
+I see one tiny whitespace error, but overall the rest of the patches\r
+looks great, so I say it's not worth resubmitting.  LGTM.\r
+\r
+>> Given the various things that are being affected by this, it would\r
+>> probably be good to add a test for this as well.\r
+>\r
+> Yeah, I think a test would be good. This isn't caught by the existing\r
+> emacs reply tests because the References and User-Agent headers are\r
+> hidden by default. Is there a function in emacs to tell message-mode\r
+> to show all the headers, so we can verify that they're correct?\r
+\r
+There must be, since I am seeing the In-Reply-To and References headers,\r
+but I can't find what customization variable it is at the moment.  It\r
+looks like I am using message-required-headers:\r
+\r
+(message-required-headers ((optional . References) From)\r
+\r
+But looking through the plethora of message-mode options, I think there\r
+is probably multiple ways to set this.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.12 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJPdJ29AAoJEO00zqvie6q8zZsP/jF5SLMwSgEKUaz2V0y/jcD2\r
+6O/H71Fb2YSj5ArZppV5Y8CU2V/k5PSJwihxtlaRP8owy82t1AXhVhVQ6qzeZAXV\r
+zP65NHF3770+HNXLxO/mgdmxN6hy9ZEASo97fLbpD1uq8CFdnLJ10aG0nAP+MOIk\r
+z42XcK+iQOlEtkQOHpz0yw/ckyfu/v5I5EM4xYDNbpBt/Xx6M5Fmx6dWgy5Qh8Gq\r
+tM0CN2Fu8MJXUp7Qrdf7Ph/CvaqGCFBrPEw7WVBTgqZtcAgRYvpYv8N2yhV/knh+\r
+UkyQAXNJWZJQ5pqwVxqHKdJ+TYN8xOUFeIqlIVgYSf3uPVQHotwnBo8iCpub/iBp\r
+tCuqbd6epS5W2IpDys0OXgtPHgY+SBcGHAfA0fPhHgF4fwVXXBfbQbGW5Cq9Uj6y\r
+Og37H/rY400urnxY1XZlvyjaO3CMGGS9XNn6TyPGmNw89C/p+23iGcL9rY+5Nc0V\r
+K7Oa9ItBxXg7dbEb/aZFhycj4KJT0uDX8GoCWJkAJk8EzUceHYrVZw9AJbWhNbZt\r
+ukQ09D0S1CPGONia2jmnbnJiHc9BiY9fBkqnav94QUa1wEQx5rTRNDnCt12h142e\r
+F80N9YaDoDbuIyosuHpyBlmwHX5DKCMYtHiXEsKTfsmbj+7jGfreXoEn24YjgENZ\r
+x4qYps8u5/4zvdNqVpTu\r
+=ta7Y\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r