--- /dev/null
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 0FEF6429E25\r
+ for <notmuch@notmuchmail.org>; Tue, 29 Nov 2011 13:04:01 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id jhqC0Hd9ywYT for <notmuch@notmuchmail.org>;\r
+ Tue, 29 Nov 2011 13:03:57 -0800 (PST)\r
+Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com\r
+ [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 2FF82431FB6\r
+ for <notmuch@notmuchmail.org>; Tue, 29 Nov 2011 13:03:57 -0800 (PST)\r
+Received: by bkaq10 with SMTP id q10so11571469bka.26\r
+ for <notmuch@notmuchmail.org>; Tue, 29 Nov 2011 13:03:56 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+ h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+ :mime-version:content-type;\r
+ bh=qSfejVeexNAlzdgPo5G7Lc2RvCkroozjd4BlgaQ8QLI=;\r
+ b=RoG8PlyyfxVnkhcHx2Wvn0T8+WEPgdbC8J90bzb1IqugBBwongiNFoBukldnB+Pzav\r
+ SbaXUG6+DuBydy4+d4+6eXcuMPl9hGiANfSubY/DNceeMae86afb28T8dw4YWQC/bOjp\r
+ cgVNlX4YCf5Cr73Ibqgbu5aB0ce6o3z20tqG8=\r
+Received: by 10.205.123.16 with SMTP id gi16mr52029875bkc.41.1322600633987;\r
+ Tue, 29 Nov 2011 13:03:53 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+ by mx.google.com with ESMTPS id d2sm16204720bky.11.2011.11.29.13.03.50\r
+ (version=TLSv1/SSLv3 cipher=OTHER);\r
+ Tue, 29 Nov 2011 13:03:51 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, Tomi Ollila <tomi.ollila@iki.fi>,\r
+ notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/3] test: add functions to count how much times notmuch\r
+ was called\r
+In-Reply-To: <yf6mxbfxezr.fsf@taco2.nixu.fi>\r
+References: <1322271878-32614-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+ <1322450895-32523-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+ <1322450895-32523-2-git-send-email-dmitry.kurochkin@gmail.com>\r
+ <yf6aa7gj7w5.fsf@taco2.nixu.fi> <87hb1ovsz4.fsf@gmail.com>\r
+ <yf6mxbfxezr.fsf@taco2.nixu.fi>\r
+User-Agent: Notmuch/0.10+44~g067c44f (http://notmuchmail.org) Emacs/23.3.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Wed, 30 Nov 2011 01:03:27 +0400\r
+Message-ID: <87aa7evdy8.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 29 Nov 2011 21:04:01 -0000\r
+\r
+Hi Tomi.\r
+\r
+On Tue, 29 Nov 2011 14:58:00 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+> Hi Dmitry.\r
+> \r
+> On Tue, 29 Nov 2011 01:26:39 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
+> > Hi Tomi.\r
+> > \r
+> > On Mon, 28 Nov 2011 22:42:50 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+> > > On Mon, 28 Nov 2011 07:28:13 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
+> [ ... ]\r
+> > > > +# Creates a script that counts how much time it is executed and calls\r
+> > > > +# notmuch. $notmuch_counter_command is set to the path to the\r
+> > > > +# generated script. Use notmuch_counter_value() function to get the\r
+> > > > +# current counter value.\r
+> > > > +notmuch_counter_reset () {\r
+> > > > + notmuch_counter_command="$TMP_DIRECTORY/notmuch_counter"\r
+> > > > + if [ ! -x "$notmuch_counter_command" ]; then\r
+> > > > + notmuch_counter_state_path="$TMP_DIRECTORY/notmuch_counter.state"\r
+> > > > + cat >"$notmuch_counter_command" <<EOF || return\r
+> > > > +#!/bin/sh\r
+> > > > +\r
+> > > > +count=\$(cat "$notmuch_counter_state_path")\r
+> > > > +echo -n \$(expr \$count + 1) > "$notmuch_counter_state_path"\r
+> > > > +\r
+> > > > +exec notmuch "\$@"\r
+> > > > +EOF\r
+> > > > + chmod +x "$notmuch_counter_command" || return\r
+> > > > + fi\r
+> > > > +\r
+> > > > + echo -n 0 > "$notmuch_counter_state_path"\r
+> > > > +}\r
+> > > > +\r
+> > > > +# Returns the current notmuch counter value.\r
+> > > > +notmuch_counter_value () {\r
+> > > > + if [ -r "$notmuch_counter_state_path" ]; then\r
+> > > > + count=$(cat "$notmuch_counter_state_path")\r
+> > > > + else\r
+> > > > + count=0\r
+> > > > + fi\r
+> > > > + echo -n $count\r
+> > > > +}\r
+> > > > +\r
+> > > \r
+> > > Good work! It would be nice if the state file contained newline after\r
+> > > count number.\r
+> > \r
+> > I wonder why it is actually nice :) I do not have strong preference\r
+> > here. So a newline is added in v3. Also a newline is added to\r
+> > notmuch_counter_value() output for consistency.\r
+> \r
+> It is nice when I enter cat /path/to/notmuch_counter from command\r
+> line and shell prompt is not appended at the end of the file contents\r
+> (but on next line :)\r
+> \r
+> > \r
+> > > Also some optimizations could be done:\r
+> > > \r
+> > \r
+> > (Would be nice if you send a diff, or a human-friendly description of\r
+> > the changes.)\r
+> \r
+> Ok, I'll try to do this according to your wishes next time.\r
+> \r
+> > > cat >"$notmuch_counter_command" <<EOF || return\r
+> > > #!/bin/sh\r
+> > > \r
+> > > read count < "$notmuch_counter_state_path"\r
+> > \r
+> > Nice. Fixed in the new patch version.\r
+> > \r
+> > > echo \$((count + 1)) > "$notmuch_counter_state_path"\r
+> > > \r
+> > \r
+> > I do not think this is really an optimization. And I find expr more\r
+> > clear than using $(()). I always have troubles remembering "random\r
+> > special char syntax" (yeah, not a Perl fan :)), prefer human friendly\r
+> > words.\r
+> \r
+> The (posix) shell command language defines 'Arithmetic Expansion' in\r
+> \r
+> http://pubs.opengroup.org/onlinepubs/007908799/xcu/chap2.html#tag_001_006_004\r
+> \r
+> I.e. using format $(( expression )) makes shell doing the arithetic itself\r
+> instead of forking a process (or two!) to do so.\r
+> \r
+\r
+I though expr was a builtin. Now I agree that it is better to replace\r
+it with $(()), even though I still prefer the expr syntax.\r
+\r
+> Normally in this case it is not so big deal (and still it isn't, but...)\r
+> In this particular case the shell wrapper counting notmuch launches and\r
+> exec'ing it the wrapper could do this without fork(2)ing a single time\r
+> (i.e. keep the process count unchanged compared to execing notmuch\r
+> directly)\r
+> \r
+> Anyway, many opinions; as far as it works I'm fine with it :) \r
+> \r
+> Now that you feel relaxed, check the results of some further\r
+> experimentation ;) :\r
+> \r
+> excerpt from man strace:\r
+> \r
+> -ff If the -o filename option is in effect, each processes\r
+> trace is written to filename.pid where pid is the\r
+> numeric process id of each process.\r
+> \r
+> Executing rm -f forked.*; strace -ff -o forked bash -c 'echo $(( 5 + 5 ))' \r
+> \r
+> will output '10' and create just one 'forked.<pid>' file\r
+> \r
+> Executing rm -f forked.*; strace -ff -o forked bash -c 'echo $(expr 5 + 5)' \r
+> \r
+> output 10 as expected, but there is now *3* forked.<pid> files !\r
+> \r
+> bash does not optmize; it forks subshell to execute $(...) and then\r
+> there just works as usual (forks subshell to execute builtin expr))\r
+> \r
+> Executing rm -f forked.*; strace -ff -o forked bash -c 'echo $(exec expr 5 + 5)' \r
+> \r
+> (the added 'exec' takes off one fork -- just 2 forked.<pid> files appear).\r
+> \r
+> I did the same tests using dash, ksh & zsh on linux system, and every one\r
+> of these managed to optimize one fork out in the above 3 fork case.\r
+> \r
+\r
+Thanks for details.\r
+\r
+Regards,\r
+ Dmitry\r
+\r
+> \r
+> Tomi\r
projects / notmuch-archives.git / commitdiff