--- /dev/null
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 64519431FB6\r
+ for <notmuch@notmuchmail.org>; Sun, 27 Jul 2014 09:24:37 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id QVy2XywitfgS for <notmuch@notmuchmail.org>;\r
+ Sun, 27 Jul 2014 09:24:30 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-2.mit.edu (dmz-mailsec-scanner-2.mit.edu\r
+ [18.9.25.13])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id C5282431FAE\r
+ for <notmuch@notmuchmail.org>; Sun, 27 Jul 2014 09:24:30 -0700 (PDT)\r
+X-AuditID: 1209190d-f79c06d000002f07-02-53d527beb812\r
+Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
+ (using TLS with cipher AES256-SHA (256/256 bits))\r
+ (Client did not present a certificate)\r
+ by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP\r
+ id 24.5A.12039.EB725D35; Sun, 27 Jul 2014 12:24:30 -0400 (EDT)\r
+Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
+ by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id s6RGOSr6016595; \r
+ Sun, 27 Jul 2014 12:24:29 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+ (authenticated bits=0)\r
+ (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+ by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id s6RGORcp014954\r
+ (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
+ Sun, 27 Jul 2014 12:24:28 -0400\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
+ (envelope-from <amdragon@mit.edu>)\r
+ id 1XBRFK-00071D-NH; Sun, 27 Jul 2014 12:24:26 -0400\r
+Date: Sun, 27 Jul 2014 12:24:26 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Mark Walters <markwalters1009@gmail.com>\r
+Subject: Re: [PATCH 04/14] new: Don't report version after upgrade\r
+Message-ID: <20140727162426.GF13893@mit.edu>\r
+References: <1406433173-19169-1-git-send-email-amdragon@mit.edu>\r
+ <1406433173-19169-5-git-send-email-amdragon@mit.edu>\r
+ <87y4vfywmp.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <87y4vfywmp.fsf@qmul.ac.uk>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IR4hRV1t2nfjXYYP9jXovVc3ksrt+cyezA\r
+ 5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZSw79oCp4LRkxf0NB5kaGJeLdDFyckgImEhs\r
+ /b2ZHcIWk7hwbz1bFyMXh5DAbCaJFZPXsUA4Gxkl1lz/A+WcZpKYvXUdWIuQwBJGiS9PM0Fs\r
+ FgFVid2/m1lAbDYBDYlt+5czgtgiAjoStw8tAKtnFpCW+Pa7mQnEFhZwktg9fRVQnIODF6jm\r
+ 7vQoiPlTGSWmbn7HBlLDKyAocXLmExaIXi2JG/9eMoHUg8xZ/o8DJMwJtGr3+rVgJaICKhJT\r
+ Tm5jm8AoNAtJ9ywk3bMQuhcwMq9ilE3JrdLNTczMKU5N1i1OTszLSy3SNdLLzSzRS00p3cQI\r
+ DmpJ3h2M7w4qHWIU4GBU4uHNYLsSLMSaWFZcmXuIUZKDSUmUt0v1arAQX1J+SmVGYnFGfFFp\r
+ TmrxIUYJDmYlEd7Ct0DlvCmJlVWpRfkwKWkOFiVx3rfWVsFCAumJJanZqakFqUUwWRkODiUJ\r
+ 3vNqQEMFi1LTUyvSMnNKENJMHJwgw3mAhs8AWcxbXJCYW5yZDpE/xagoJc7bAdIsAJLIKM2D\r
+ 64UlnVeM4kCvCPOGglTxABMWXPcroMFMQINZ/C+DDC5JREhJNTB2NlQbPNi5OdJzrUhW4zwR\r
+ sxNlfHME2Na8XHR6Z9YboTVL4mrcGH+Ft7Jx/ZXeyrr9x5ENKbwL/z6bPTW3N2mGiraZiVuE\r
+ 4ZK4u+kbN13veiiWUBztxzNl0a9ih/CPGZEpL140BdfP0/3y3FaotJh7+1yFFutnJ12fq0af\r
+ kzyWuTKs7ETf92AlluKMREMt5qLiRACxHkqzFQMAAA==\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 27 Jul 2014 16:24:37 -0000\r
+\r
+Quoth Mark Walters on Jul 27 at 10:33 am:\r
+> On Sun, 27 Jul 2014, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> > The version number has always been pretty meaningless to the user and\r
+> > it's about to become even more meaningless with the introduction of\r
+> > "features". Hopefully, the database will remain on version 3 for some\r
+> > time to come; however, the introduction of new features over time in\r
+> > version 3 will necessitate upgrades within version 3. It would be\r
+> > confusing if we always tell the user they've been "upgraded to version\r
+> > 3". If the user wants to know what's new, they should read the news.\r
+> \r
+> Two thoughts on this: \r
+> \r
+> first, we could print the names of the new features here to make it\r
+> easier for the user to find them in NEWS. \r
+\r
+Interesting. Transparency is good, though I worry that this would\r
+expose the user to internal implementation details (certainly some\r
+features will translate to user-visible features, but others will be\r
+entirely internal to the library).\r
+\r
+> Secondly, would it be worth having something like notmuch\r
+> --database-version or similar which prints the features? If I understand\r
+> the series then notmuch clients don't necessarily need to upgrade the\r
+> database unless they want the new features. This means that knowing what\r
+> version they are running might not tell us which features they have\r
+> enabled (which could make debugging difficult)\r
+\r
+Good idea, though I'd be inclined to do it in a follow-up series just\r
+so this series doesn't get even longer. It won't be a problem for\r
+now: this series doesn't touch our current policy of unconditionally\r
+upgrading on notmuch new (a policy I think we should keep, though\r
+that's a separate discussion) so the notmuch version should still tell\r
+us the database version/features.\r
+\r
+> Best wishes\r
+> \r
+> Mark\r
+> \r
+> > ---\r
+> > notmuch-new.c | 3 +--\r
+> > test/T530-upgrade.sh | 2 +-\r
+> > 2 files changed, 2 insertions(+), 3 deletions(-)\r
+> >\r
+> > diff --git a/notmuch-new.c b/notmuch-new.c\r
+> > index d269c7c..b7590a8 100644\r
+> > --- a/notmuch-new.c\r
+> > +++ b/notmuch-new.c\r
+> > @@ -1023,8 +1023,7 @@ notmuch_new_command (notmuch_config_t *config, int argc, char *argv[])\r
+> > add_files_state.verbosity >= VERBOSITY_NORMAL ? upgrade_print_progress : NULL,\r
+> > &add_files_state);\r
+> > if (add_files_state.verbosity >= VERBOSITY_NORMAL)\r
+> > - printf ("Your notmuch database has now been upgraded to database format version %u.\n",\r
+> > - notmuch_database_get_version (notmuch));\r
+> > + printf ("Your notmuch database has now been upgraded.\n");\r
+> > }\r
+> > \r
+> > add_files_state.total_files = 0;\r
+> > diff --git a/test/T530-upgrade.sh b/test/T530-upgrade.sh\r
+> > index 7d5d5aa..c4c4ac8 100755\r
+> > --- a/test/T530-upgrade.sh\r
+> > +++ b/test/T530-upgrade.sh\r
+> > @@ -33,7 +33,7 @@ test_expect_equal "$output" "\\r
+> > Welcome to a new version of notmuch! Your database will now be upgraded.\r
+> > This process is safe to interrupt.\r
+> > Backing up tags to FILENAME\r
+> > -Your notmuch database has now been upgraded to database format version 2.\r
+> > +Your notmuch database has now been upgraded.\r
+> > No new mail."\r
+> > \r
+> > test_begin_subtest "tag backup matches pre-upgrade dump"\r
projects / notmuch-archives.git / commitdiff