Re: [PATCH] cli: factor out config handling code to get/set lists.

diff --git a/63/765c8f7eb483c9e063992b8da4693d9b862ce1 b/63/765c8f7eb483c9e063992b8da4693d9b862ce1
new file mode 100644 (file)
index 0000000..50f8a70
--- /dev/null
+++ b/63/765c8f7eb483c9e063992b8da4693d9b862ce1
@@ -0,0 +1,88 @@
+Return-Path: <pieter@praet.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 4A624429E26\r
+       for <notmuch@notmuchmail.org>; Thu, 12 Jan 2012 09:28:15 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id b3wGemkfGXEm for <notmuch@notmuchmail.org>;\r
+       Thu, 12 Jan 2012 09:28:14 -0800 (PST)\r
+Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com\r
+       [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 75675431FB6\r
+       for <notmuch@notmuchmail.org>; Thu, 12 Jan 2012 09:28:14 -0800 (PST)\r
+Received: by wibhr12 with SMTP id hr12so1517744wib.26\r
+       for <notmuch@notmuchmail.org>; Thu, 12 Jan 2012 09:28:13 -0800 (PST)\r
+Received: by 10.180.83.72 with SMTP id o8mr1939568wiy.22.1326389293356;\r
+       Thu, 12 Jan 2012 09:28:13 -0800 (PST)\r
+Received: from localhost ([109.131.126.209])\r
+       by mx.google.com with ESMTPS id fo18sm6510828wbb.12.2012.01.12.09.28.12\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Thu, 12 Jan 2012 09:28:12 -0800 (PST)\r
+From: Pieter Praet <pieter@praet.org>\r
+To: David Bremner <david@tethera.net>,\r
+       Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] cli: factor out config handling code to get/set lists.\r
+In-Reply-To: <87pqft8x4i.fsf@convex-new.cs.unb.ca>\r
+References: <87sjkstbiu.fsf@zancas.localnet>\r
+       <1323619671-14111-1-git-send-email-david@tethera.net>\r
+       <874nx76oxa.fsf@gmail.com> <87pqft8x4i.fsf@convex-new.cs.unb.ca>\r
+User-Agent: Notmuch/0.10.2+115~gadd29f6 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+Date: Thu, 12 Jan 2012 18:26:33 +0100\r
+Message-ID: <87y5tckf1y.fsf@praet.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 12 Jan 2012 17:28:15 -0000\r
+\r
+On Mon, 12 Dec 2011 14:26:21 -0400, David Bremner <david@tethera.net> wrote:\r
+> On Sun, 11 Dec 2011 20:41:53 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
+> > Hi David.\r
+> > \r
+> > On Sun, 11 Dec 2011 12:07:51 -0400, David Bremner <david@tethera.net> wrote:\r
+> > > From: David Bremner <bremner@debian.org>\r
+> > > \r
+> > > Two new internal routines are created _config_get_list and\r
+> > > _config_set_list; the notmuch_config_get_* functions that deal with\r
+> > > lists are simply wrappers for these functions.\r
+> \r
+> Updated version pushed. I'm not completely happy with _config_get_list's\r
+> weird API, but I don't have a better idea now.\r
+> \r
+> d\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
+\r
+Much cleaner!\r
+\r
+However... this would preferrably have been preceded by tests.\r
+\r
+Patch follows.\r
+\r
+\r
+Peace\r
+\r
+-- \r
+Pieter\r