--- /dev/null
+Return-Path: <felipe.contreras@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 5BB80431FAF\r
+ for <notmuch@notmuchmail.org>; Tue, 24 Apr 2012 03:30:13 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id QL+9fZrMqOaw for <notmuch@notmuchmail.org>;\r
+ Tue, 24 Apr 2012 03:30:12 -0700 (PDT)\r
+Received: from mail-ee0-f53.google.com (mail-ee0-f53.google.com\r
+ [74.125.83.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client\r
+ certificate requested) by olra.theworths.org (Postfix) with ESMTPS id\r
+ 7CC08431FAE for <notmuch@notmuchmail.org>; Tue, 24 Apr 2012 03:30:12 -0700\r
+ (PDT)\r
+Received: by eekb47 with SMTP id b47so223628eek.26\r
+ for <notmuch@notmuchmail.org>; Tue, 24 Apr 2012 03:30:11 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+ h=mime-version:in-reply-to:references:date:message-id:subject:from:to\r
+ :cc:content-type:content-transfer-encoding;\r
+ bh=Vig6HAsMBRXTl+T7ZiXCJXNXNwVSxOGSFe8qW7zXh+g=;\r
+ b=JhNO6ytWZoI9xgzeEkQkM/TVSvdSwdbxsOOloAJPbGsQWUe63SrssYmZn7u1SQHTTV\r
+ MePF6yBFE7KmHxncGe2cu5uyO7+CYqKgPN+ju4r9IjH6yoARe81TsAR/o9/ETOAPCbWJ\r
+ wL1HO9YNcJsI8vOV4OejZeB/zLS072G2/CFtyWlDzr9yzNBnnWY0JsQrFnYRpNW1dHk5\r
+ fP/lbrl0J+WJPrnXFOE1wj948WwPt8o+plHhoGNqTSIg8uFGRi+a6IAglO+EitV6gWG7\r
+ JohA98SYH5ZJ8IU1al/rp0uupiBULQS/Wmh5St5DbGLqxRwHddqo0zZfsgbGD9RTuWz9\r
+ 962g==\r
+MIME-Version: 1.0\r
+Received: by 10.14.50.74 with SMTP id y50mr1344928eeb.107.1335263411113; Tue,\r
+ 24 Apr 2012 03:30:11 -0700 (PDT)\r
+Received: by 10.213.103.18 with HTTP; Tue, 24 Apr 2012 03:30:11 -0700 (PDT)\r
+In-Reply-To: <20120424011528.GA12459@mit.edu>\r
+References: <1335185032-13075-1-git-send-email-felipe.contreras@gmail.com>\r
+ <CADv3eywAvyMuh3vWLwyuf0Ui_kskwp9875pGxCR1GTm7deN9Pg@mail.gmail.com>\r
+ <CAMP44s3SyU4WVV0_McHWseNL=jmMnAXO2EdZK4Xk-wrCHPVD8A@mail.gmail.com>\r
+ <CADv3eywb0tguYowTAK5Ag9YZ48zFZA0QJVNEj_cZcCpr-76Bbg@mail.gmail.com>\r
+ <CAMP44s0=m+PmVBdVytHaYujpaZu=2WH+1F_VoMzpfXH+SS_ZmQ@mail.gmail.com>\r
+ <CADv3eyxcu=2ZJ7GH3WULKMqe6FdmzhPtU6K9MLcCQ4m0cWmM7A@mail.gmail.com>\r
+ <CAMP44s2qmPWZk=1N8L1aOnDb7b81kthNB-Gj798wdwBdtbBjFQ@mail.gmail.com>\r
+ <20120424011528.GA12459@mit.edu>\r
+Date: Tue, 24 Apr 2012 13:30:11 +0300\r
+Message-ID:\r
+ <CAMP44s2HbqaMxELGUJKZDaJx_pH9A1gqEJdiNPmvPjgGv79+Ow@mail.gmail.com>\r
+Subject: Re: [PATCH] ruby: make sure the database is closed\r
+From: Felipe Contreras <felipe.contreras@gmail.com>\r
+To: Austin Clements <amdragon@mit.edu>\r
+Content-Type: text/plain; charset=UTF-8\r
+Content-Transfer-Encoding: quoted-printable\r
+Cc: Ali Polatel <alip@exherbo.org>, notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 24 Apr 2012 10:30:13 -0000\r
+\r
+On Tue, Apr 24, 2012 at 4:15 AM, Austin Clements <amdragon@mit.edu> wrote:\r
+> Quoth Felipe Contreras on Apr 24 at =C2=A03:45 am:\r
+>> On Tue, Apr 24, 2012 at 2:46 AM, Ali Polatel <alip@exherbo.org> wrote:\r
+>> > 2012/4/24 Felipe Contreras <felipe.contreras@gmail.com>:\r
+>>\r
+>> >> Personally I don't see why an object, like say a query would remain\r
+>> >> working correctly after the database is gone, either by calling\r
+>> >> .close() directly, or just loosing the pointer to the original object=\r
+.\r
+>> >> I don't think users would expect that, or, even if they somehow found\r
+>> >> it useful, that most likely would be very seldom, and hardly worth\r
+>> >> worrying about it.\r
+>> >\r
+>> > Working correctly is not expected but wouldn't it be more appropriate\r
+>> > to throw an exception rather than dumping core or printing on standard=\r
+ error?\r
+>>\r
+>> Sure, if that was possible.\r
+>>\r
+>> > I wonder whether we can make both work somehow.\r
+>> > Maybe by using talloc explicitly and keeping reference pointers?\r
+>> > I don't know whether it's worth bothering.\r
+>>\r
+>> Maybe, I don't see how, that's just not how C works. Maybe talloc does\r
+>> have some way to figure out if a pointer has been freed, but I doubt\r
+>> that, and I can't find it by grepping through the API.\r
+>>\r
+>> Another option would be hook into talloc's destructor so we know when\r
+>> an object is freed and taint it, but then we would be overriding\r
+>> notmuch's destructor, and there's no way around that (unless we tap\r
+>> into talloc's internal structures). A way to workaround that would be\r
+>> to modify notmuch's API so that we can specify a destructor for\r
+>> notmuch objects, but that would be tedious, and I doubt a lof people\r
+>> beside us would benefit from that.\r
+>\r
+> I believe (though I might be wrong) that bindings could simply\r
+> maintain their own talloc references to C objects returned by\r
+> libnotmuch to prevent them from being freed until the wrapper object\r
+> is garbage collected. =C2=A0This would require modifying all of the\r
+> library's _destroy functions to use talloc_find_parent_bytype and\r
+> talloc_unlink instead of simply calling talloc_free, but I don't think\r
+> this change would be particularly invasive and it certainly wouldn't\r
+> affect the library interface.\r
+\r
+That might work, but still, I don't see why this patch can't be applied.\r
+\r
+Cheers.\r
+\r
+--=20\r
+Felipe Contreras\r
projects / notmuch-archives.git / commitdiff