Re: Warning when GMime is parsing broken email addresses

diff --git a/f9/c0c2ed721d895ee98cad00f64cb8916ccd4fee b/f9/c0c2ed721d895ee98cad00f64cb8916ccd4fee
new file mode 100644 (file)
index 0000000..56d4544
--- /dev/null
+++ b/f9/c0c2ed721d895ee98cad00f64cb8916ccd4fee
@@ -0,0 +1,100 @@
+Return-Path: <pieter@praet.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1810C431FD0\r
+       for <notmuch@notmuchmail.org>; Wed, 27 Apr 2011 12:59:19 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id A4aTwZZjlrVZ for <notmuch@notmuchmail.org>;\r
+       Wed, 27 Apr 2011 12:59:16 -0700 (PDT)\r
+Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com\r
+ [74.125.82.45])       (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
+ certificate requested)        by olra.theworths.org (Postfix) with ESMTPS id\r
+ 83C19431FB5   for <notmuch@notmuchmail.org>; Wed, 27 Apr 2011 12:59:15 -0700\r
+ (PDT)\r
+Received: by wwi36 with SMTP id 36so1903391wwi.2\r
+       for <notmuch@notmuchmail.org>; Wed, 27 Apr 2011 12:59:12 -0700 (PDT)\r
+Received: by 10.227.149.142 with SMTP id t14mr2577577wbv.170.1303934352080;\r
+       Wed, 27 Apr 2011 12:59:12 -0700 (PDT)\r
+Received: from localhost (202.69-240-81.adsl-dyn.isp.belgacom.be\r
+       [81.240.69.202])\r
+       by mx.google.com with ESMTPS id b20sm663358wbb.67.2011.04.27.12.59.10\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Wed, 27 Apr 2011 12:59:11 -0700 (PDT)\r
+From: Pieter Praet <pieter@praet.org>\r
+To: Xavier Maillard <xma@gnu.org>, Carl Worth <cworth@cworth.org>,\r
+       Matthieu Lemerre <racin@free.fr>, notmuch@notmuchmail.org\r
+Subject: Re: Warning when GMime is parsing broken email addresses\r
+In-Reply-To: <m2y62vy7vy.fsf@gnu.org>\r
+References: <87ipzvk2xh.fsf@free.fr> <877hai3r82.fsf@yoom.home.cworth.org>\r
+       <m2y62vy7vy.fsf@gnu.org>\r
+User-Agent: Notmuch/0.5-98-g63c37b1 (http://notmuchmail.org) Emacs/23.1.50.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 27 Apr 2011 21:59:09 +0200\r
+Message-ID: <87r58n8nzm.fsf@praet.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 27 Apr 2011 19:59:19 -0000\r
+\r
+On Wed, 27 Apr 2011 18:30:09 +0200, Xavier Maillard <xavier@maillard.im> wrote:\r
+> On Mon, 25 Apr 2011 15:23:41 -0700, Carl Worth <cworth@cworth.org> wrote:\r
+> > On Wed, 17 Nov 2010 23:20:26 +0100, Matthieu Lemerre <racin@free.fr> wrote:\r
+> > > Maybe it would also be interesting to add a warning/assertion to check\r
+> > > that all email adresses added to the database are correct email\r
+> > > addresses? I.e. check that the `addr' variable in _index_address_mailbox\r
+> > > always has a @. This check is in fact already done using the function\r
+> > > strchr, but a bad value is explicitly ignored...\r
+> > \r
+> > Hmm... we could add a warning like that. But I don't know how useful it\r
+> > would actually be. (I, for one, am currently not seeing any warnings\r
+> > From "notmuch new"---maybe I should fix that...).\r
+> > \r
+> > Since GMime is fixed upstream (as of version 2.4.18) another option\r
+> > would be to simply make the notmuch build system require a sufficiently\r
+> > new version of GMime in order to build.\r
+> > \r
+> > What do you think?\r
+> \r
+> My vote goes to the latter. Cleaner and really simple solution.\r
+> \r
+> /Xavier\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
+\r
+I'd say both.\r
+\r
+Unfortunately, regressions are not uncommon, and regardless, it'd be\r
+nice to be notified when what we stuff in the db is not sane.\r
+\r
+It would however be a good idea IMHO to check email address more\r
+thorougly [1] than simply verifying whether an "@" is present.\r
+\r
+\r
+Peace\r
+\r
+-Pieter\r
+\r
+\r
+[1] http://www.regular-expressions.info/email.html\r
+\r