Re: [PATCH 1/4] Mailstore abstraction interface

diff --git a/27/af96e16fe9ddbd03d1ba5556ad144dbe1a3081 b/27/af96e16fe9ddbd03d1ba5556ad144dbe1a3081
new file mode 100644 (file)
index 0000000..605f6cc
--- /dev/null
+++ b/27/af96e16fe9ddbd03d1ba5556ad144dbe1a3081
@@ -0,0 +1,100 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 913BA4196F2\r
+       for <notmuch@notmuchmail.org>; Tue, 13 Apr 2010 10:53:15 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.89\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5\r
+       tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01]\r
+       autolearn=ham\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 9sDQMeyOUYS2; Tue, 13 Apr 2010 10:53:13 -0700 (PDT)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 22869431FC1;\r
+       Tue, 13 Apr 2010 10:53:13 -0700 (PDT)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+       id C44D55883A6; Tue, 13 Apr 2010 10:53:12 -0700 (PDT)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/4] Mailstore abstraction interface\r
+In-Reply-To: <1270737766-29237-2-git-send-email-sojkam1@fel.cvut.cz>\r
+References: <1270737766-29237-1-git-send-email-sojkam1@fel.cvut.cz>\r
+       <1270737766-29237-2-git-send-email-sojkam1@fel.cvut.cz>\r
+Date: Tue, 13 Apr 2010 10:53:12 -0700\r
+Message-ID: <87aat7kznb.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 13 Apr 2010 17:53:15 -0000\r
+\r
+--=-=-=\r
+\r
+On Thu,  8 Apr 2010 16:42:43 +0200, Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+> The goal of mailstore abstraction is to allow notmuch to store tags\r
+> together with email messages. The abstract interface is needed because\r
+> people want to use different ways of storing their emails. Currently,\r
+> there exists implementation for two types of mailstore - plain files\r
+> and maildir. It is expected that additional git-based mailstore will\r
+> be developed later.\r
+\r
+I don't agree with the approach being taken here.\r
+\r
+I don't think that the expectation of future need is a good basis for\r
+adding a level of abstraction now. This gives us current costs without\r
+benefit.\r
+\r
+Meanwhile, the two different mail stores that you are currently support\r
+("plain" and "maildir") aren't really different types. We do already\r
+have code within notmuch to detect whether any particular directory is a\r
+maildir, (with the heuristic of looking for child directories named\r
+"cur", "new", and "tmp"). So I think we can and should support both\r
+maildir and non-maildir mail storage just fine.\r
+\r
+The question of "once you have maildir storage, should you synchronize\r
+that tags" is quite separate. The answer there might be "yes", "no", or\r
+"let the user decide". But if it is configurable, then the configuration\r
+should be something like\r
+\r
+       [maildir]\r
+       synchronize_flags=yes\r
+\r
+rather than\r
+\r
+       [mailstore]\r
+       type=maildir\r
+\r
+This series is looking like one of the most complete approaches to\r
+maildir-flag synchronization, (and I like some of the motivation that\r
+leads to "notmuch cat"). But I think the mailstore abstraction is\r
+largely a distraction from the real features here.\r
+\r
+-Carl\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.10 (GNU/Linux)\r
+\r
+iD8DBQFLxK+I6JDdNq8qSWgRAlnQAJsE+t03y5AFUfgZG6lKv06s3KDKpQCfc0lD\r
+EDT6dQbukg07Hyto2SvvDBc=\r
+=TUnE\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r