Re: [PATCH] rewriting notmuch-search for structured output to make other output forma...

diff --git a/a3/2df895fccb20498cfed279261d6d6ced5190ab b/a3/2df895fccb20498cfed279261d6d6ced5190ab
new file mode 100644 (file)
index 0000000..6c78d1a
--- /dev/null
+++ b/a3/2df895fccb20498cfed279261d6d6ced5190ab
@@ -0,0 +1,104 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id A362F429E40\r
+       for <notmuch@notmuchmail.org>; Sat, 21 Jan 2012 15:13:10 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.29\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id G7hiKAxXkPRO for <notmuch@notmuchmail.org>;\r
+       Sat, 21 Jan 2012 15:13:09 -0800 (PST)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id 15EA7431FAF\r
+       for <notmuch@notmuchmail.org>; Sat, 21 Jan 2012 15:13:09 -0800 (PST)\r
+Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by fire-doxen-postvirus (Postfix) with ESMTP id 831772E50D9D;\r
+       Sat, 21 Jan 2012 15:13:08 -0800 (PST)\r
+X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new\r
+Received: from finestructure.net (cpe-76-174-137-84.socal.res.rr.com\r
+       [76.174.137.84]) (Authenticated sender: jrollins)\r
+       by fire-doxen-submit (Postfix) with ESMTP id B78172E50D9A;\r
+       Sat, 21 Jan 2012 15:13:05 -0800 (PST)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id 26A1235B; Sat, 21 Jan 2012 15:13:00 -0800 (PST)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Peter Feigl <craven@gmx.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] rewriting notmuch-search for structured output to make\r
+       other output formats easier\r
+In-Reply-To: <1327180568-30385-1-git-send-email-craven@gmx.net>\r
+References: <1327180568-30385-1-git-send-email-craven@gmx.net>\r
+User-Agent: Notmuch/0.11+92~g9b8f34f (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 21 Jan 2012 15:12:57 -0800\r
+Message-ID: <87k44klkee.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 21 Jan 2012 23:13:10 -0000\r
+\r
+--=-=-=\r
+\r
+On Sat, 21 Jan 2012 22:16:08 +0100, Peter Feigl <craven@gmx.net> wrote:\r
+> The output routines have been rewritten so that logical structure\r
+> (objects with key/value pairs, arrays, strings and numbers) are\r
+> written instead of ad-hoc printfs. This allows for easier adaptation\r
+> of other output formats, as only the routines that start/end an object\r
+> etc. have to be rewritten. The logic is the same for all formats.\r
+> The default text output is handled differently, special cases are\r
+> inserted at the proper places, as it differs too much from the\r
+> structured output.\r
+\r
+Hi, Peter.  Thanks for the contribution.\r
+\r
+There are a lot of changes in this patch so I think you need to think\r
+about how you can break this up into multiple smaller and more atomic\r
+patches.  In particular, the addition of the sexp output format needs to\r
+definitely be in a separate patch from the restructuring of the output\r
+formatting.  You also don't mention anywhere in the commit log that\r
+you've added this new output format.  You'll also need to include\r
+documentation and test suite updates.\r
+\r
+Thanks.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJPG0Z5AAoJEO00zqvie6q8MYwQALN/K1K3fEShbnvVIAoc1bfs\r
+RFiAz215k5bJkupcf8qY50PPKJRpMD4yY1KGsBhd59CdDRsXCylaN14PsZNQ6hxx\r
+4JnpX1HjjfEwIgCTUmWOyg8KKnmIyJx3BTWArqOR6mzfI1oLQnjO+jpFV6NwZRgm\r
+7U/xZadDt0AUcT66qJaZJ6LUJluKsmb7kJORrZL76QL+0lIACERMvtQaUekjdK93\r
+LsigOk0CqBtky6tN8em7SeXKUnE8GYoLPhYp6nVyonOfEba4inXZlvFSF0LilWkL\r
+gT9JeDIYA12CkNOgu3aDxLsHl0Mwd1S1L2wL98YojOQFHf1akL0M3s1aPawPFoXP\r
+OXuTi2jYwANXbTr7nrSV3+pVhBCkichNwBSL9uN1TB788ZyT3pYHYzRBsiM37cfm\r
+/Rsz2V/9ZI7Rb4I+OiWib3CFwBtMiEZ6yNPMoCHkom7jaYuESyVcX+KlGVlTrokN\r
+QUvI/F3lPfGS5kTAQeanhYYNu3En7bNH8VvxRI8Q0l8GP1JvGDo9HlY8unaYQ6a/\r
+LEKHw6+fagPpDIsIXD7gZAKF9GMA4dJNIzxSvaLJIgrOt620gKTTOwuMTrUtteok\r
+87CcwyR+T3QgEwwb+RWrNoh6o1wcQCJWyc82vhxagImBvkkkWdVU8YCm7oTTDkyz\r
+QSSxvJzNdd0gkDYYhMHc\r
+=CcT9\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r