--- /dev/null
+Return-Path: <tomi.ollila@nixu.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 3E7074074C9\r
+ for <notmuch@notmuchmail.org>; Fri, 6 Jan 2012 14:56:24 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+ autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id x79x299Cefvj for <notmuch@notmuchmail.org>;\r
+ Fri, 6 Jan 2012 14:56:23 -0800 (PST)\r
+Received: from mail-gw3.nixu.fi (mail-gw3.nixu.fi [193.209.237.7])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 5FF104074C7\r
+ for <notmuch@notmuchmail.org>; Fri, 6 Jan 2012 14:56:23 -0800 (PST)\r
+Received: from pps.filterd (mail-gw3 [127.0.0.1])\r
+ by mail-gw3.nixu.fi (8.14.4/8.14.4) with SMTP id q06MsCwY028833;\r
+ Sat, 7 Jan 2012 00:56:20 +0200\r
+Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])\r
+ by mail-gw3.nixu.fi with ESMTP id 114cs0xu8b-1\r
+ (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+ Sat, 07 Jan 2012 00:56:20 +0200\r
+Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])\r
+ by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id\r
+ q06MuJBe011453; Sat, 7 Jan 2012 00:56:19 +0200\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: Helpers for notmuch developers.\r
+In-Reply-To: <1325685678-12710-1-git-send-email-dme@dme.org>\r
+References: <1325685678-12710-1-git-send-email-dme@dme.org>\r
+User-Agent: Notmuch/0.10.2+157~g442d405 (http://notmuchmail.org) Emacs/23.3.1\r
+ (i686-pc-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sat, 07 Jan 2012 00:56:19 +0200\r
+Message-ID: <yf6sjjsigoc.fsf@taco2.nixu.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.5.7110,\r
+ 1.0.211, 0.0.0000 definitions=2012-01-05_05:2012-01-05, 2012-01-05,\r
+ 1970-01-01 signatures=0\r
+X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0\r
+ ipscore=0 suspectscore=0\r
+ phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0\r
+ reason=mlx\r
+ scancount=1 engine=6.0.2-1012030000 definitions=main-1201060286\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 06 Jan 2012 22:56:24 -0000\r
+\r
+On Wed, 4 Jan 2012 14:01:18 +0000, David Edmondson <dme@dme.org> wrote:\r
+> ---\r
+> \r
+> I've been using this for a few days and decided to share it to get\r
+> feedback. Reviewing patches can be tedious, so I tried to make things\r
+> a little simpler.\r
+> \r
+> To use this, load the file and then from `notmuch-show-mode' invoke\r
+> `notmuch-dev-show-review-patch'. It assumes that any open messages\r
+> contain patches and attempts to build a repository with the patches\r
+> applied.\r
+> \r
+> General management (i.e. keeping up to date) of the repository it uses\r
+> is your responsibility, as is cleaning out old branches. You can, of\r
+> course, just delete the temporary repository after using it - the code\r
+> will re-create it next time.\r
+> \r
+> If you have a slow network connection then a local copy of the main\r
+> repository can be specified by changing\r
+> `notmuch-dev-master-repository'.\r
+> \r
+> Comments?\r
+\r
+I think this is great. I've worked on something related but the emacs MUA\r
+"integration" makes patching simpler (My thing worked on shell and would\r
+require a 'recipe' file to describe HEAD commit and patch message id:s).\r
+\r
+What I've done differently is that I already have cloned notmuch repository\r
+somewhere which I attempt to keep up-to-date. For repository which I'm\r
+going to patch I first do:\r
+\r
+git clone --local --shared --no-checkout /path/to/notmuch/repo notmuch-dev-$USER\r
+git --git-dir notmuch-dev-$USER/.git' config --unset remote.origin.url\r
+cd notmuch-dev-$USER\r
+git checkout -b patched $commit\r
+\r
+I.e.\r
+\r
+1) I created a local repository clone, sharing objects without initial checkout.\r
+2) removed "remote" origin so accidental pushes are not possible\r
+3) checkout out tree from some commit (possible not remote HEAD) \r
+\r
+And this is done every time before new patchset is applied -- always on top\r
+of clean working directory.\r
+\r
+What do you think of this approach related to your way cloning the repo and\r
+then deleting/creating the branch. Just that developer may mess with the\r
+repository contents and then there is tedious working tree cleanup to be\r
+done (especially those who are not so fluent using git).\r
+\r
+\r
+Tomi\r
+\r
projects / notmuch-archives.git / commitdiff