Re: Last minute fixes to the go bindings
authorAustin Clements <amdragon@MIT.EDU>
Wed, 9 May 2012 18:07:00 +0000 (14:07 +2000)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:47:01 +0000 (09:47 -0800)
20/a1aa408f20fa2863a0b99b6a350ada38ee4512 [new file with mode: 0644]

diff --git a/20/a1aa408f20fa2863a0b99b6a350ada38ee4512 b/20/a1aa408f20fa2863a0b99b6a350ada38ee4512
new file mode 100644 (file)
index 0000000..2e228c4
--- /dev/null
@@ -0,0 +1,102 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id E27ED431FAF\r
+       for <notmuch@notmuchmail.org>; Wed,  9 May 2012 11:07:05 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id UP5X8U+VaiQh for <notmuch@notmuchmail.org>;\r
+       Wed,  9 May 2012 11:07:05 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU\r
+       [18.9.25.13])\r
+       by olra.theworths.org (Postfix) with ESMTP id 639F9431FAE\r
+       for <notmuch@notmuchmail.org>; Wed,  9 May 2012 11:07:05 -0700 (PDT)\r
+X-AuditID: 1209190d-b7fbf6d0000008ba-be-4faab2484dc6\r
+Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
+       by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id EB.FE.02234.842BAAF4; Wed,  9 May 2012 14:07:04 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q49I72eW030298; \r
+       Wed, 9 May 2012 14:07:03 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q49I71OB002180\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Wed, 9 May 2012 14:07:02 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1SSBHw-0006xR-P5; Wed, 09 May 2012 14:07:00 -0400\r
+Date: Wed, 9 May 2012 14:07:00 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Justus Winter <4winter@informatik.uni-hamburg.de>\r
+Subject: Re: Last minute fixes to the go bindings\r
+Message-ID: <20120509180700.GA11804@mit.edu>\r
+References:\r
+ <1336558988-6813-1-git-send-email-4winter@informatik.uni-hamburg.de>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To:\r
+ <1336558988-6813-1-git-send-email-4winter@informatik.uni-hamburg.de>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42IR4hRV1vXYtMrfYNNNNYvZrT+YLK7fnMns\r
+       wOQx8fxpNo9nq24xBzBFcdmkpOZklqUW6dslcGX8v7WcueAOW0XHlMXsDYyzWLsYOTkkBEwk\r
+       1v+Zyghhi0lcuLeeDcQWEtjHKLFjMVCcC8hezyix88FPFojECSaJx184IBJLGCXe7XzFDpJg\r
+       EVCRuLVkGdgkNgENiW37l4PZIgKmEhsePACrYRaQlvj2u5kJxBYWMJTYuO8T2BW8AjoSF7ZN\r
+       Z4VYECDR+mQ7M0RcUOLkzCcsEL1aEjf+vQTq5QCbs/wfB0iYUyBQ4sDjW2DlokAnTDm5jW0C\r
+       o9AsJN2zkHTPQuhewMi8ilE2JbdKNzcxM6c4NVm3ODkxLy+1SNdILzezRC81pXQTIzioJXl3\r
+       ML47qHSIUYCDUYmH92DjKn8h1sSy4srcQ4ySHExKoryi64FCfEn5KZUZicUZ8UWlOanFhxgl\r
+       OJiVRHjvrgLK8aYkVlalFuXDpKQ5WJTEeVW13vkJCaQnlqRmp6YWpBbBZGU4OJQkeBs2AjUK\r
+       FqWmp1akZeaUIKSZODhBhvMADd8FUsNbXJCYW5yZDpE/xajLMW/K1quMQix5+XmpUuK8NSBF\r
+       AiBFGaV5cHNgyegVozjQW8K8/SBVPMBEBjfpFdASJqAl0w6vBFlSkoiQkmpgPKbafEt1wQKd\r
+       Goeyp6X32RqUj9yrulPBsZXn+ofcgIwm3ulz+LMtbFnSp6bXmfysKi7mNo2TnTjtQUrS9Cfu\r
+       R0LLp02dNFHEoL/ub6dYXcSV+fPznnq6tNye379bZfrpVzZleaezKqacs2Q42xxxsSPkaQzn\r
+       3LlZG5251Z+nO+9+FhdsYeWrxFKckWioxVxUnAgA8+x7SCEDAAA=\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 09 May 2012 18:07:06 -0000\r
+\r
+LGTM.\r
+\r
+Quoth Justus Winter on May 09 at 12:23 pm:\r
+> Hi everyone :)\r
+> \r
+> this is a small patch series that I'd like to see included in 0.13.\r
+> \r
+> The first patch updates notmuch-addrlookup with respect to Austins\r
+> recent change of the notmuch_database_open function. This fixes the\r
+> compilation of the utility.\r
+> \r
+> The second patch fixes the values of all the STATUS_* constants. Turns\r
+> out all of them were set to zero by accident. This isn't a c style\r
+> enum, golang has the iota operator to do this kind of stuff. This\r
+> fixes the error handling for all the users of the go bindings.\r
+\r
+'Doh!  Is it possible to get the status values out of cgo, rather than\r
+depending on the list in libnotmuch and the list in Go being in the\r
+same order?\r
+\r
+> The third patch just brings the list of status constants up to date.\r
+> \r
+> Cheers,\r
+> Justus\r