Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equa...

diff --git a/14/55987def490d9805851d80fd46eaef3720740a b/14/55987def490d9805851d80fd46eaef3720740a
new file mode 100644 (file)
index 0000000..9b7333c
--- /dev/null
+++ b/14/55987def490d9805851d80fd46eaef3720740a
@@ -0,0 +1,94 @@
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5344B431FBD\r
+       for <notmuch@notmuchmail.org>; Thu,  2 Feb 2012 16:19:27 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.7\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.7 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id S6CQWrfGaWNC for <notmuch@notmuchmail.org>;\r
+       Thu,  2 Feb 2012 16:19:26 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+       [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 8FDAB431FAF\r
+       for <notmuch@notmuchmail.org>; Thu,  2 Feb 2012 16:19:26 -0800 (PST)\r
+Received: by bke11 with SMTP id 11so2968923bke.26\r
+       for <notmuch@notmuchmail.org>; Thu, 02 Feb 2012 16:19:25 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type;\r
+       bh=a7rSI/9bbAsJBRi0zzXmehXh14TPgMngJRA0gKpRE5Y=;\r
+       b=TTfvAWdBewD3Es3fm5Jc7GAaacNODIxcqY1sZwTbDRpgDjCKlYs6mEcHI46yqaQBKb\r
+       JjztniKIGMn+0E4UhAPUtWTFarjj6+3o0xl6qqfwgxkSH8UrGMLM0XyM/XKUVR6auJST\r
+       7ubyD2kJSG2oIrRa9ybl/s7UYUOt5YA9mlkOc=\r
+Received: by 10.204.133.201 with SMTP id g9mr2406841bkt.137.1328228364959;\r
+       Thu, 02 Feb 2012 16:19:24 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+       by mx.google.com with ESMTPS id 20sm11666300bkr.0.2012.02.02.16.19.23\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Thu, 02 Feb 2012 16:19:23 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>,\r
+ notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/2] test: add check for <expected> filename argument for\r
+       test_expect_equal_file\r
+In-Reply-To: <87zkd1p12c.fsf@servo.finestructure.net>\r
+References: <1328141050-30356-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <1328141050-30356-2-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <87zkd1p12c.fsf@servo.finestructure.net>\r
+User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Fri, 03 Feb 2012 04:18:09 +0400\r
+Message-ID: <87zkd0ixby.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 03 Feb 2012 00:19:27 -0000\r
+\r
+Hi Jameson.\r
+\r
+On Thu, 02 Feb 2012 10:00:59 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:\r
+> Hey, Dmitry.  I'm so sorry I sent my last email on your original patch\r
+> before I saw this new series.\r
+\r
+No problems.\r
+\r
+>  I do now like your original proposal\r
+> better, since it shows the diff based the names the caller provides,\r
+> which I now agree is probably the clearest and most robust solution.\r
+> The second patch in this series could still go through, though, no\r
+> matter what version of the change to test_expect_equal_file we go with.\r
+> \r
+\r
+Ok.  I am going to wait for some time (e.g. 2 days) for more opinions.\r
+Though, I doubt I would get any :) (And the problem is really minor, so\r
+it probably does not deserve much attention.)\r
+\r
+Currently, it seems that the original approach [1] wins.\r
+\r
+Regards,\r
+  Dmitry\r
+\r
+[1] id:"1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com"\r
+\r
+> jamie.\r