[PATCH v2 1/5] config: Fix free in 'config get' implementation.

diff --git a/37/ab8596157d058d6330c2b3c10c126f1ba2808d b/37/ab8596157d058d6330c2b3c10c126f1ba2808d
new file mode 100644 (file)
index 0000000..a3d4f68
--- /dev/null
+++ b/37/ab8596157d058d6330c2b3c10c126f1ba2808d
@@ -0,0 +1,85 @@
+Return-Path: <novalazy@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id C63C8431E64\r
+       for <notmuch@notmuchmail.org>; Fri, 30 Mar 2012 16:16:09 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id syEaFXsZaNUl for <notmuch@notmuchmail.org>;\r
+       Fri, 30 Mar 2012 16:16:09 -0700 (PDT)\r
+Received: from mail-pz0-f45.google.com (mail-pz0-f45.google.com\r
+       [209.85.210.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 5E3E6431FAE\r
+       for <notmuch@notmuchmail.org>; Fri, 30 Mar 2012 16:16:09 -0700 (PDT)\r
+Received: by dacx6 with SMTP id x6so56814dac.18\r
+       for <notmuch@notmuchmail.org>; Fri, 30 Mar 2012 16:16:08 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references;\r
+       bh=mkSjrE63V0UO6LxveJEQlNNV/Rp+LMoxf9IM3FkxXPs=;\r
+       b=BzuffVk9hhWeHRmoGISNCo97BbdKQR9vCT144s4EEUEPN8xxPVc0ahWQWlvA4vRl0B\r
+       lNsLdoPdVFTpZFguvm9FB6eRFWX5qkkQxsRXqaz/eKCkkJ0R32VGt/TD5mcKNcSEThTE\r
+       w8pRUqzYiVc/wWnPKTH2RX1I6RuZqzVfgNnvWLCSSmeqKqM4Y792/vbRUtpmhICHbj6p\r
+       5ycQW3n9EcwFNCScyOz+lfT0KnaKirO/itpeSET0WqTZ4rK2F1m5A+53rV0FwO64mPFP\r
+       RVC4GShPFQOWfwVYORWqWbWYKlxZJHrpaXEHo+QZRzu0KxrdIbZGiLnfjaCj5KWlHtna\r
+       H0rg==\r
+Received: by 10.68.194.198 with SMTP id hy6mr1491829pbc.0.1333149368598;\r
+       Fri, 30 Mar 2012 16:16:08 -0700 (PDT)\r
+Received: from localhost (215.42.233.220.static.exetel.com.au.\r
+       [220.233.42.215])\r
+       by mx.google.com with ESMTPS id v9sm490955pbn.17.2012.03.30.16.16.05\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Fri, 30 Mar 2012 16:16:07 -0700 (PDT)\r
+From: Peter Wang <novalazy@gmail.com>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH v2 1/5] config: Fix free in 'config get' implementation.\r
+Date: Sat, 31 Mar 2012 10:15:46 +1100\r
+Message-Id: <1333149350-22616-2-git-send-email-novalazy@gmail.com>\r
+X-Mailer: git-send-email 1.7.4.4\r
+In-Reply-To: <1333149350-22616-1-git-send-email-novalazy@gmail.com>\r
+References: <1332282698-7951-1-git-send-email-novalazy@gmail.com>\r
+       <1333149350-22616-1-git-send-email-novalazy@gmail.com>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 30 Mar 2012 23:16:09 -0000\r
+\r
+The array returned by g_key_file_get_string_list() should be freed with\r
+g_strfreev(), not free().\r
+---\r
+ notmuch-config.c |    2 +-\r
+ 1 files changed, 1 insertions(+), 1 deletions(-)\r
+\r
+diff --git a/notmuch-config.c b/notmuch-config.c\r
+index e9b2750..85fc774 100644\r
+--- a/notmuch-config.c\r
++++ b/notmuch-config.c\r
+@@ -751,7 +751,7 @@ notmuch_config_command_get (void *ctx, char *item)\r
+       for (i = 0; i < length; i++)\r
+           printf ("%s\n", value[i]);\r
+ \r
+-      free (value);\r
++      g_strfreev (value);\r
+     }\r
+ \r
+     notmuch_config_close (config);\r
+-- \r
+1.7.4.4\r
+\r