Re: bug report: Emacs notmuch-mode fails attachments with spaces

diff --git a/02/ebebc14e941e9296513cb513e28d54f52476d7 b/02/ebebc14e941e9296513cb513e28d54f52476d7
new file mode 100644 (file)
index 0000000..4750c68
--- /dev/null
+++ b/02/ebebc14e941e9296513cb513e28d54f52476d7
@@ -0,0 +1,164 @@
+Return-Path: <nils@dieweltistgarnichtso.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 0FE056DE1638\r
+ for <notmuch@notmuchmail.org>; Sat, 30 May 2015 18:01:45 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.722\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.722 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01,\r
+ RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id byOc80PpqNaL for <notmuch@notmuchmail.org>;\r
+ Sat, 30 May 2015 18:01:39 -0700 (PDT)\r
+X-Greylist: delayed 1156 seconds by postgrey-1.35 at arlo;\r
+ Sat, 30 May 2015 18:01:39 PDT\r
+Received: from mail.tiggerswelt.net (mail.tiggerswelt.net [94.186.151.130])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 300F56DE119C\r
+ for <notmuch@notmuchmail.org>; Sat, 30 May 2015 18:01:39 -0700 (PDT)\r
+Received: from localhost (f053141102.adsl.alicedsl.de [78.53.141.102])\r
+ (using TLSv1 with cipher AES128-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by mail.tiggerswelt.net (Postfix) with ESMTP id 03CFC2900;\r
+ Sun, 31 May 2015 02:46:18 +0200 (CEST)\r
+From: Nils Dagsson Moskopp <nils@dieweltistgarnichtso.net>\r
+To: David Edmondson <dme@dme.org>, Tomi Ollila <tomi.ollila@iki.fi>,\r
+ notmuch@notmuchmail.org\r
+Subject: Re: bug report: Emacs notmuch-mode fails attachments with spaces\r
+In-Reply-To: <cunh9ut650e.fsf@gargravarr.hh.sledj.net>\r
+References: <87twyurc78.fsf@dieweltistgarnichtso.net>\r
+ <m24mqu455x.fsf@guru.guru-group.fi> <8761b9pu11.fsf@dieweltistgarnichtso.net>\r
+ <cunh9ut650e.fsf@gargravarr.hh.sledj.net>\r
+User-Agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/23.4.1\r
+ (i486-pc-linux-gnu)\r
+Date: Sun, 31 May 2015 02:42:01 +0200\r
+Message-ID: <87zj4lbmsm.fsf@dieweltistgarnichtso.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+ micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 31 May 2015 01:01:45 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+David Edmondson <dme@dme.org> writes:\r
+\r
+> On Tue, Feb 10 2015, Nils Dagsson Moskopp wrote:\r
+>> Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+>>\r
+>>> On Mon, Feb 09 2015, Nils Dagsson Moskopp <nils@dieweltistgarnichtso.ne=\r
+t> wrote:\r
+>>>\r
+>>>> Dear notmuch developers,\r
+>>>>\r
+>>>>\r
+>>>> I use notmuch-mode for GNU Emacs for managing my email.\r
+>>>>\r
+>>>> I think I have found a bug in notmuch-mode: If I do =E2=80=9C.-v=E2=80=\r
+=9D on the line =E2=80=9C[\r
+>>>> 2015 _ Richtlinien.pdf: application/pdf ]=E2=80=9D, then notmuch will =\r
+open three\r
+>>>> windows of zathura (the PDF viewer I use).\r
+>>>>\r
+>>>> It seems to me that someone here either forgot quoting or decided to\r
+>>>> split filenames on spaces. I suggest that =E2=80=9C2015 _ Richtlinien.=\r
+pdf:\r
+>>>> application/pdf=E2=80=9D should be quoted in notmuch-show-view-part.\r
+>>>>\r
+>>>> Note that saving attachment (=E2=80=9C.-s=E2=80=9D, notmuch-show-save-=\r
+part) generally\r
+>>>> works even if the attachment file names have spaces. In case it matter=\r
+s,\r
+>>>> I normally use the rc(1) shell in Debian <http://tobold.org/article/rc=\r
+>.\r
+>>>\r
+>>> This code handles the saving and displaying in question (quick look hop=\r
+ i\r
+>>> am right :)\r
+>>>\r
+>>>    2282 (defun notmuch-show-save-part ()\r
+>>>    2283   "Save the MIME part containing point to a file."\r
+>>>    2284   (interactive)\r
+>>>    2285   (notmuch-show-apply-to-current-part-handle #'mm-save-part))\r
+>>>    2286=20\r
+>>>    2287 (defun notmuch-show-view-part ()\r
+>>>    2288   "View the MIME part containing point in an external viewer."\r
+>>>    2289   (interactive)\r
+>>>    2290   ;; Set mm-inlined-types to nil to force an external viewer\r
+>>>    2291   (let ((mm-inlined-types nil))\r
+>>>    2292     (notmuch-show-apply-to-current-part-handle #'mm-display-par=\r
+t)))\r
+>>>\r
+>>> SO, there is 2 options:\r
+>>>\r
+>>> 1) mm executes save part correctly but not display part\r
+>>\r
+>> It seems I cannot investigate this with my knowledge, as =E2=80=9CM-x\r
+>> find-function RET mm-display-part=E2=80=9D gives =E2=80=9CCan't find lib=\r
+rary\r
+>> /usr/share/emacs/23.4/lisp/gnus/mm-decode.el=E2=80=9D. Any ideas?\r
+>>\r
+>>> 2) there is (shell) wrapper program executing zathura which cannot hand=\r
+le\r
+>>>    arguments with spaces (there is plenty of examples of this!)\r
+>>>\r
+>>>\r
+>>> You could try to check how th external processes are executed by execut=\r
+ing:\r
+>>>\r
+>>> strace -f -e trace=3Dprocess emacs -f notmuch\r
+>>>\r
+>>> (emacs on X is preferable in this case ;)\r
+>>\r
+>> Thank you for that suggestion. It seems that there does happen both some\r
+>> (wrong) escaping and splitting at spaces. I can see the following trace:\r
+>>\r
+>> --- snib ---\r
+>> execve("/usr/bin/zathura", ["/usr/bin/zathura", "/tmp/emm.23178ut2/2015\=\r
+\", "_\\", "Richtlinien.pdf"] [/* 51 vars */]) =3D 0\r
+>> --- snab ---\r
+>>\r
+>> Somewhat unusually, it is preceeded by an invocation of the shell:\r
+>>\r
+>> --- sneb ---\r
+>> execve("/usr/bin/rc", ["/usr/bin/rc", "-c", "/usr/bin/zathura /tmp/emm.2=\r
+3178u"...], [/* 51 vars */] <unfinished ...>\r
+>\r
+> It would be useful to see the rest of this string ^^. Can you persuade\r
+> strace to show more please?\r
+\r
+I have no idea how. Do you?\r
+\r
+=2D-=20\r
+Nils Dagsson Moskopp // erlehmann\r
+<http://dieweltistgarnichtso.net>\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1\r
+\r
+iF4EAREIAAYFAlVqWNkACgkQZGjbY/Ag5QlhYwEAgzdhGhNqr9NbD23t/wWp2wQS\r
+Id4TvJlxg79cmYVkSfkBAKxXM0FBfKNLxCJ97ltJ6kYN9Nvnk5yXoQec8Ccv3Vj2\r
+=FJJZ\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r