Re: [PATCH 1/3] cli: add support for parsing multiple keyword arguments
authorDavid Bremner <david@tethera.net>
Fri, 19 Sep 2014 19:27:14 +0000 (21:27 +0200)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 18:04:35 +0000 (10:04 -0800)
d2/cf055a8a609a122d592ed23895350cf4d9ecfb [new file with mode: 0644]

diff --git a/d2/cf055a8a609a122d592ed23895350cf4d9ecfb b/d2/cf055a8a609a122d592ed23895350cf4d9ecfb
new file mode 100644 (file)
index 0000000..fe82141
--- /dev/null
@@ -0,0 +1,63 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 046ED431FBC\r
+       for <notmuch@notmuchmail.org>; Fri, 19 Sep 2014 12:27:26 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id OKoBCbLBj9Kn for <notmuch@notmuchmail.org>;\r
+       Fri, 19 Sep 2014 12:27:22 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 21645431FAE\r
+       for <notmuch@notmuchmail.org>; Fri, 19 Sep 2014 12:27:22 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1XV3pw-00073h-2d; Fri, 19 Sep 2014 16:27:20 -0300\r
+Received: (nullmailer pid 3928 invoked by uid 1000); Fri, 19 Sep 2014\r
+       19:27:14 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/3] cli: add support for parsing multiple keyword\r
+       arguments\r
+In-Reply-To: <1410008010-3770-1-git-send-email-jani@nikula.org>\r
+References: <1410008010-3770-1-git-send-email-jani@nikula.org>\r
+User-Agent: Notmuch/0.18.1+97~g56c48dc (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Fri, 19 Sep 2014 21:27:14 +0200\r
+Message-ID: <87mw9vbect.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 19 Sep 2014 19:27:26 -0000\r
+\r
+Jani Nikula <jani@nikula.org> writes:\r
+\r
+> This allows having multiple --foo=bar --foo=baz options on the command\r
+> line, with the corresponding values OR'd together.\r
+> ---\r
+\r
+This looks OK. In hindsight I guess we could have had only keyword_flags\r
+from the beginning, but I guess that would be pretty intrusive to change\r
+at this point.\r
+\r
+d\r