Re: [notmuch] [PATCH 2/3] notmuch.el: Add collapse all and expand all to notmuch...

diff --git a/04/9558f93f55c34062b5d7c8e3ad8fa927eba82f b/04/9558f93f55c34062b5d7c8e3ad8fa927eba82f
new file mode 100644 (file)
index 0000000..e01adaa
--- /dev/null
+++ b/04/9558f93f55c34062b5d7c8e3ad8fa927eba82f
@@ -0,0 +1,93 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 01F6C431FBD\r
+       for <notmuch@notmuchmail.org>; Fri,  5 Feb 2010 11:45:04 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.967\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.967 tagged_above=-999 required=5\r
+       tests=[ALL_TRUSTED=-1.8, AWL=0.018, BAYES_40=-0.185] autolearn=ham\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id BoEBXRFb54tO; Fri,  5 Feb 2010 11:45:03 -0800 (PST)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 48F45431FAE;\r
+       Fri,  5 Feb 2010 11:45:03 -0800 (PST)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+       id EFA46254181; Sat,  6 Feb 2010 08:45:02 +1300 (NZDT)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Kan-Ru Chen <kanru@kanru.info>, notmuch@notmuchmail.org\r
+In-Reply-To: <1259648253-31034-2-git-send-email-kanru@kanru.info>\r
+References: <1259648033-30653-1-git-send-email-kanru@kanru.info>\r
+       <1259648253-31034-2-git-send-email-kanru@kanru.info>\r
+Date: Fri, 05 Feb 2010 11:45:02 -0800\r
+Message-ID: <87aavnpiv5.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+Subject: Re: [notmuch] [PATCH 2/3] notmuch.el: Add collapse all and expand\r
+ all to notmuch-show\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 05 Feb 2010 19:45:04 -0000\r
+\r
+--=-=-=\r
+\r
+On Tue,  1 Dec 2009 14:17:32 +0800, Kan-Ru Chen <kanru@kanru.info> wrote:\r
+> These two functions behave like gmail's collapse all and expand all\r
+> commands. notmuch-show-collapse-all is bound to 'B' but\r
+> notmuch-show-expand-all has no keybindig because I thought it is not often\r
+> used.\r
+\r
+I haven't applied this one for a few reasons:\r
+\r
+1. I don't know what the functions are support to do.\r
+\r
+   The commit log says "behave like gmail" but I don't know what that\r
+   means personally. And the functions don't have any documentation\r
+   strings.\r
+\r
+   I assume that these functions are either showing or hiding all\r
+   message bodies in the current thread?\r
+\r
+2. You provided a binding for collapse, but not expand. I don't like\r
+   functionality which lets a user hide a bunch of data, and then not be\r
+   able to get it back---that's really annoying if the user hits the key\r
+   accidentally.\r
+\r
+   Personally, I think I'd be much more likely to use expand before\r
+   collapse, (for example, to easily see the context when a new message\r
+   arrives in a thread that I'd previously read so comes up collapsed by\r
+   default).\r
+\r
+Should we perhaps make something which temporarily makes all hidden\r
+messages visible but then toggles back to the previous subset of some\r
+show messages? Once again, I'm worried about providing trapdoor\r
+interfaces where the user can't get back to the previous state easily.\r
+\r
+-Carl\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.10 (GNU/Linux)\r
+\r
+iD8DBQFLbHU+6JDdNq8qSWgRAp6SAJ0e7W4wpcpzJBrvO7x1sRsx4E88kgCcCfXo\r
+QO47xgRvh0pvpsbBbFX5L2g=\r
+=WZ8d\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r