Re: [PATCH] emacs: Remove duplicate declaration of `notmuch-folders'

diff --git a/39/91efe49a5f97b5a133a91b3064e55faf0f1975 b/39/91efe49a5f97b5a133a91b3064e55faf0f1975
new file mode 100644 (file)
index 0000000..6db1da0
--- /dev/null
+++ b/39/91efe49a5f97b5a133a91b3064e55faf0f1975
@@ -0,0 +1,97 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 2F00B4196F0\r
+       for <notmuch@notmuchmail.org>; Mon, 26 Apr 2010 10:51:24 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.89\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5\r
+       tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01]\r
+       autolearn=ham\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 8ABRWiR2-K6T; Mon, 26 Apr 2010 10:51:23 -0700 (PDT)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 62D44431FC1;\r
+       Mon, 26 Apr 2010 10:51:23 -0700 (PDT)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+       id B3167568DEC; Mon, 26 Apr 2010 10:51:22 -0700 (PDT)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: dme@dme.org, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: Remove duplicate declaration of `notmuch-folders'\r
+In-Reply-To: <1272294583-18209-1-git-send-email-dme@dme.org>\r
+References: <1272294583-18209-1-git-send-email-dme@dme.org>\r
+User-Agent: Notmuch/0.2-202-g01ec4d3 (http://notmuchmail.org) Emacs/23.1.1\r
+       (i486-pc-linux-gnu)\r
+Date: Mon, 26 Apr 2010 10:51:22 -0700\r
+Message-ID: <874oiydrvp.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 26 Apr 2010 17:51:24 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Mon, 26 Apr 2010 16:09:43 +0100, dme@dme.org wrote:\r
+> From: David Edmondson <dme@dme.org>\r
+[no commit message]\r
+\r
+Thanks, David.\r
+\r
+Allow me the chance to try to convince you that *every* commit requires\r
+a sentence or two of justification, (beyond the one-line summary just\r
+stating "what" the patch does). There's *always* some utility to saying\r
+"why".\r
+\r
+Take this current patch which seems so simple. There were two\r
+declarations, so one had to go. What more could there be to say?\r
+\r
+For me, when reviewing this, I wondered "How did there come to be two\r
+different declarations?", and "Is this patch removing the right one?".\r
+So I had to go grep through the source to figure out what had happened.\r
+\r
+I could have avoided that if the commit had said something like:\r
+\r
+       This variable was moved from notmuch.el to notmuch-lib.el some time\r
+       ago, but the declaration in notmuch.el was left around. Clean\r
+       that up.\r
+\r
+[And I just pushed the patch with this added.]\r
+\r
+Whether or not that convinces you, perhaps you can humor me and always\r
+try to come up with something to say, even when it seems there's nothing\r
+possible to add. If nothing else, it can be a fun challenge. If you need\r
+more beyond that, you can try writing your commit message as a haiku.\r
+\r
+=2DCarl\r
+\r
+=2D-=20\r
+carl.d.worth@intel.com\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.10 (GNU/Linux)\r
+\r
+iD8DBQFL1dKa6JDdNq8qSWgRAlEZAJwIZkplMmDXqySGOM3ymp2F8ErgdQCfbNEj\r
+sthNcCwEq2KdRF7/J8eGHHc=\r
+=BF6j\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r