Re: [PATCH 2/2] tags_to_maildir_flags: Don't rename if no flags change

diff --git a/63/361b1290735bf6ae77a673c2e1c9435f79d091 b/63/361b1290735bf6ae77a673c2e1c9435f79d091
new file mode 100644 (file)
index 0000000..2a2e2b0
--- /dev/null
+++ b/63/361b1290735bf6ae77a673c2e1c9435f79d091
@@ -0,0 +1,94 @@
+Return-Path: <lrilling@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 3DA7B431FD0\r
+       for <notmuch@notmuchmail.org>; Tue, 12 Jul 2011 06:48:07 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.699\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001,\r
+       RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id ag3m++hEzGqd for <notmuch@notmuchmail.org>;\r
+       Tue, 12 Jul 2011 06:48:06 -0700 (PDT)\r
+Received: from mail-ew0-f53.google.com (mail-ew0-f53.google.com\r
+       [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id BD7AB431FB6\r
+       for <notmuch@notmuchmail.org>; Tue, 12 Jul 2011 06:48:05 -0700 (PDT)\r
+Received: by ewy8 with SMTP id 8so1741776ewy.26\r
+       for <notmuch@notmuchmail.org>; Tue, 12 Jul 2011 06:48:04 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+       h=sender:date:from:to:cc:subject:message-id:references:mime-version\r
+       :content-type:content-disposition:in-reply-to:user-agent;\r
+       bh=7HCwWVSb2fYfFtte3ALBWYkUpy7/Tod/IsnQr12JcIw=;\r
+       b=Id1WeTB+AafSkb4sHw4i8yflpwubJPN//m74o565rS2t1/TTrjjwYiaTkLV3xeNapP\r
+       YuwInclyaQCOEhVUqZ5sRzrRRhXlI5SYLf0Oso8PYhxSJLU6fQf+7Ln9om87ZYPwLGsq\r
+       c5h7qn2YGa2wEBER9RfQylrRHBNeV05qWgBDg=\r
+Received: by 10.213.8.4 with SMTP id f4mr1353313ebf.142.1310478484060;\r
+       Tue, 12 Jul 2011 06:48:04 -0700 (PDT)\r
+Received: from localdomain ([78.222.14.116])\r
+       by mx.google.com with ESMTPS id b9sm1533669een.42.2011.07.12.06.48.02\r
+       (version=SSLv3 cipher=OTHER); Tue, 12 Jul 2011 06:48:03 -0700 (PDT)\r
+Sender: Louis Rilling <lrilling@gmail.com>\r
+Date: Tue, 12 Jul 2011 15:47:56 +0200\r
+From: Louis Rilling <l.rilling@av7.net>\r
+To: Austin Clements <amdragon@MIT.EDU>\r
+Subject: Re: [PATCH 2/2] tags_to_maildir_flags: Don't rename if no flags\r
+ change\r
+Message-ID: <20110712134755.GA3279@localdomain>\r
+References: <87d3hzgemi.fsf@yoom.home.cworth.org>\r
+       <1310394978-11883-3-git-send-email-l.rilling@av7.net>\r
+       <20110711200712.GB25558@mit.edu>\r
+       <20110711223805.GC3583@localdomain>\r
+       <20110712000344.GD25558@mit.edu>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <20110712000344.GD25558@mit.edu>\r
+User-Agent: Mutt/1.5.20 (2009-06-14)\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 12 Jul 2011 13:48:07 -0000\r
+\r
+On 11/07/11 20:03 -0400, Austin Clements wrote:\r
+> > > The convention in notmuch is to use notmuch_bool_t, TRUE, and FALSE\r
+> > > (though, admittedly, I don't know why; avoiding C99-isms?)\r
+> > \r
+> > And bool is already used at another place in message.cc:\r
+> > \r
+> >    struct maildir_flag_tag {\r
+> >        char flag;\r
+> >        const char *tag;\r
+> >        bool inverse;\r
+> >    };\r
+> > \r
+> > IIUC it should be changed to notmuch_bool_t too.\r
+> \r
+> Yes, I suppose it should (something slipped by cworth's eagle-eyed\r
+> reviews!).  Though that appears to be the sole use of bool in all of\r
+> libnotmuch.\r
+\r
+I wonder if this is due to incompatible definitions of type bool in C99 and\r
+C++. In that case this is probably harmless since struct maildir_flag_tag is\r
+only visible from message.cc. Anyway, I'm sending a conversion patch together\r
+with the updated series to make it clearer for Carl.\r
+\r
+Thanks,\r
+\r
+Louis\r