Re: [Patch v2 09/17] tag-util.[ch]: New files for common tagging routines

diff --git a/2f/69cda897e8fc936ecd3e95a31ac6e382bc975f b/2f/69cda897e8fc936ecd3e95a31ac6e382bc975f
new file mode 100644 (file)
index 0000000..73b4366
--- /dev/null
+++ b/2f/69cda897e8fc936ecd3e95a31ac6e382bc975f
@@ -0,0 +1,92 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 27460431FAF\r
+       for <notmuch@notmuchmail.org>; Fri, 30 Nov 2012 20:30:05 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id yhd49qfCx-zl for <notmuch@notmuchmail.org>;\r
+       Fri, 30 Nov 2012 20:30:04 -0800 (PST)\r
+Received: from dmz-mailsec-scanner-4.mit.edu (DMZ-MAILSEC-SCANNER-4.MIT.EDU\r
+       [18.9.25.15])\r
+       by olra.theworths.org (Postfix) with ESMTP id A96C2431FAE\r
+       for <notmuch@notmuchmail.org>; Fri, 30 Nov 2012 20:30:04 -0800 (PST)\r
+X-AuditID: 1209190f-b7fec6d00000090d-b7-50b987cb85af\r
+Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
+       by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 8E.C8.02317.BC789B05; Fri, 30 Nov 2012 23:30:04 -0500 (EST)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id qB14U3SP015205; \r
+       Fri, 30 Nov 2012 23:30:03 -0500\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id qB14U1Bg021834\r
+       (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
+       Fri, 30 Nov 2012 23:30:02 -0500 (EST)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1TeeiG-0002DX-UY; Fri, 30 Nov 2012 23:30:01 -0500\r
+Date: Fri, 30 Nov 2012 23:30:00 -0500\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: David Bremner <david@tethera.net>\r
+Subject: Re: [Patch v2 09/17] tag-util.[ch]: New files for common tagging\r
+       routines\r
+Message-ID: <20121201043000.GC4681@mit.edu>\r
+References: <1353792017-31459-1-git-send-email-david@tethera.net>\r
+       <1353792017-31459-10-git-send-email-david@tethera.net>\r
+       <87vcctiauq.fsf@qmul.ac.uk> <87pq2wgd15.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <87pq2wgd15.fsf@zancas.localnet>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFuplleLIzCtJLcpLzFFi42IR4hRV1j3TvjPAYKKvxY3WbkaL1XN5LK7f\r
+       nMnswOyxc9Zddo9nq24xe2w59J45gDmKyyYlNSezLLVI3y6BK2PZkVtsBTNZK24d38nWwDiR\r
+       pYuRk0NCwESi4f9XZghbTOLCvfVsXYxcHEIC+xglTp15zQ7hbGCU+Lv4ISOEc5FJ4sHMZqiy\r
+       JYwSi3fdYQTpZxFQlbj35SAriM0moCGxbf9ysLgIUPzqtslsIDazgKvEjAu7mEBsYYEQiQmb\r
+       W8FsXgFtiVl77jNBDN3NKPFo3wNWiISgxMmZT1ggmrUkbvx7CVTEAWRLSyz/xwES5hTQlbg+\r
+       eRfYLlEBFYkpJ7exTWAUmoWkexaS7lkI3QsYmVcxyqbkVunmJmbmFKcm6xYnJ+blpRbpmujl\r
+       ZpbopaaUbmIEh7ok/w7GbweVDjEKcDAq8fAmPNwRIMSaWFZcmXuIUZKDSUmU90zbzgAhvqT8\r
+       lMqMxOKM+KLSnNTiQ4wSHMxKIryyn4DKeVMSK6tSi/JhUtIcLErivFdTbvoLCaQnlqRmp6YW\r
+       pBbBZGU4OJQkeBNAhgoWpaanVqRl5pQgpJk4OEGG8wAN5wWmBiHe4oLE3OLMdIj8KUZFKXHe\r
+       GyDNAiCJjNI8uF5YKnrFKA70ijDvO5AqHmAag+t+BTSYCWjwm2XbQQaXJCKkpBoYRerSHaNu\r
+       fTV0OjNFueu+RJRl8NOOAy3hARNicm/x/zOQ5xFbGjrtmIvaqh7VqjubWOvVMmNsf74u6fRt\r
+       +az46KXZVsacD8wVD8+9vy5064d8p/reY5bSTXpbzQtOqExbsfTlt5K8PdVX9kbucWxTXms/\r
+       ecrb3SuXOB7WmzJ1b63b4clJEtOylFiKMxINtZiLihMB39mc4CADAAA=\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 01 Dec 2012 04:30:05 -0000\r
+\r
+Quoth David Bremner on Nov 29 at  8:17 pm:\r
+> Mark Walters <markwalters1009@gmail.com> writes:\r
+> > I don't know how freeze/thaw work but does it matter that you don't thaw\r
+> > when there is an error?\r
+> \r
+> My interpretation is that by not thawing before we destroy the message,\r
+> we are aborting the transaction, since the freeze/thaw information is\r
+> stored in the message structure. It is documented as forbidden to call\r
+> thaw _more_ times than freeze, but less is not explicitely mentioned.\r
+\r
+Yes, this should work.  It smells a little hacky and I couldn't say if\r
+it was an intended use of the API, but it should work.  Perhaps we\r
+should document it.\r