Re: [PATCH] test: use `princ' instead of `message' calls in emacs tests

diff --git a/20/9f6323a7b9a15f70122a5e105b3315caa53250 b/20/9f6323a7b9a15f70122a5e105b3315caa53250
new file mode 100644 (file)
index 0000000..09edc47
--- /dev/null
+++ b/20/9f6323a7b9a15f70122a5e105b3315caa53250
@@ -0,0 +1,92 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 2E6BE431FD0\r
+       for <notmuch@notmuchmail.org>; Fri, 27 May 2011 16:12:31 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.01\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.01 tagged_above=-999 required=5\r
+       tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id qDmwVcnrDjwW for <notmuch@notmuchmail.org>;\r
+       Fri, 27 May 2011 16:12:30 -0700 (PDT)\r
+Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2])\r
+       by olra.theworths.org (Postfix) with ESMTP id B2971431FB6\r
+       for <notmuch@notmuchmail.org>; Fri, 27 May 2011 16:12:30 -0700 (PDT)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+       by arlo.cworth.org (Postfix) with ESMTP id 5F45B29A513;\r
+       Fri, 27 May 2011 16:12:29 -0700 (PDT)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+       id 5273E25417E; Fri, 27 May 2011 16:12:27 -0700 (PDT)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,\r
+       Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH] test: use `princ' instead of `message' calls in emacs\r
+       tests\r
+In-Reply-To: <1305008708-15610-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+References: <1305008708-15610-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1\r
+       (i486-pc-linux-gnu)\r
+Date: Fri, 27 May 2011 16:12:20 -0700\r
+Message-ID: <87tycfrb57.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 27 May 2011 23:12:31 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Tue, 10 May 2011 10:25:08 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmai=\r
+l.com> wrote:\r
+> The patch replaces all (message (buffer-string)) calls in emacs\r
+> tests with (princ (buffer-string)).  This avoids accidentally\r
+> interpreting '%' as format specifiers and makes code simpler\r
+> because we do not need to capture stderr.\r
+>=20\r
+> Also, the patch works around an Emacs (23.3+1-1 on current Debian\r
+> Unstable) segfault in "Ensure that emacs doesn't drop results"\r
+> test.\r
+\r
+Thanks so much for the fix! I hadn't noticed the segfault until the\r
+recent additional include of test-lib.el, (which of course shouldn't\r
+actually be changing anything), which seems to tickle the emacs bug a\r
+little more frequently for me at least.\r
+\r
+The segfault made it obvious that this was an emacs bug, but it was\r
+annoying to hit. It will be nice to have this fix in place.\r
+\r
+This change is pushed now.\r
+\r
+=2DCarl\r
+\r
+=2D-=20\r
+carl.d.worth@intel.com\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iEYEARECAAYFAk3gL9QACgkQ6JDdNq8qSWjoxgCgjsQyK7F4wTABYe4kTrhmi56g\r
+Q+kAmwTZGdwvPcOHCIwy7uVNIk0qT6Da\r
+=ZPtG\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r