Re: release-candidate/0.6

diff --git a/fd/25a3a2bcd1b2354fbe38da03cee9c541fb8a74 b/fd/25a3a2bcd1b2354fbe38da03cee9c541fb8a74
new file mode 100644 (file)
index 0000000..8b910ea
--- /dev/null
+++ b/fd/25a3a2bcd1b2354fbe38da03cee9c541fb8a74
@@ -0,0 +1,101 @@
+Return-Path: <pieter@praet.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 16A8B431FD0\r
+       for <notmuch@notmuchmail.org>; Thu, 12 May 2011 07:09:17 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id PR76l8IfmIRs for <notmuch@notmuchmail.org>;\r
+       Thu, 12 May 2011 07:09:13 -0700 (PDT)\r
+Received: from mail-wy0-f181.google.com (mail-wy0-f181.google.com\r
+       [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 4718E431FB6\r
+       for <notmuch@notmuchmail.org>; Thu, 12 May 2011 07:09:13 -0700 (PDT)\r
+Received: by wyi11 with SMTP id 11so1308579wyi.26\r
+       for <notmuch@notmuchmail.org>; Thu, 12 May 2011 07:09:11 -0700 (PDT)\r
+Received: by 10.216.71.136 with SMTP id r8mr1985690wed.0.1305209351804;\r
+       Thu, 12 May 2011 07:09:11 -0700 (PDT)\r
+Received: from localhost (188.152-240-81.adsl-dyn.isp.belgacom.be\r
+       [81.240.152.188])\r
+       by mx.google.com with ESMTPS id l24sm764619wbc.64.2011.05.12.07.09.10\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Thu, 12 May 2011 07:09:10 -0700 (PDT)\r
+From: Pieter Praet <pieter@praet.org>\r
+To: Austin Clements <amdragon@mit.edu>\r
+Subject: Re: release-candidate/0.6\r
+In-Reply-To: <BANLkTi=iz6F+1-WQ5KDno6N-MF=dQeTbEA@mail.gmail.com>\r
+References: <8762pn7gth.fsf@servo.factory.finestructure.net>\r
+       <87iptkfzwx.fsf@servo.factory.finestructure.net>\r
+       <877h9zokod.fsf@servo.factory.finestructure.net>\r
+       <878vuencm5.fsf@servo.factory.finestructure.net>\r
+       <878vuejym8.fsf@servo.factory.finestructure.net>\r
+       <87wrhw2jmm.fsf@praet.org>\r
+       <BANLkTi=iz6F+1-WQ5KDno6N-MF=dQeTbEA@mail.gmail.com>\r
+User-Agent: Notmuch/0.5-221-ga19d81a (http://notmuchmail.org) Emacs/23.1.50.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 12 May 2011 16:09:08 +0200\r
+Message-ID: <87zkms80zf.fsf@praet.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 12 May 2011 14:09:17 -0000\r
+\r
+On Thu, 12 May 2011 09:18:48 -0400, Austin Clements <amdragon@mit.edu> wrote:\r
+> On Thu, May 12, 2011 at 8:22 AM, Pieter Praet <pieter@praet.org> wrote:\r
+> > The atomicity tests were failing here because I didn't have GDB\r
+> > installed, so I've added it as a prereq.\r
+> \r
+> Sorry, I've had a patch to address that sitting around, but hadn't\r
+> sent it out (and I only fixed that one test).  I would suggest a\r
+> somewhat gentler approach than "error", though:\r
+> \r
+> if test_expect_success "prereq: gdb is present" "which gdb"; then\r
+>     test_set_prereq GDB\r
+> fi\r
+> \r
+> (Plus the two test-lib patches I just sent:\r
+> id:1305206080-17461-1-git-send-email-amdragon@mit.edu and\r
+> id:1305206110-17511-1-git-send-email-amdragon@mit.edu).\r
+> \r
+> "error" has the disadvantage that it doesn't get counted as a failed\r
+> test in the final tally (because, indeed, it's not a failed test) and\r
+> also that it immediately terminates the test script so it's not\r
+> actually using the prereq system (which is fine for the atomicity test\r
+> since all of the test cases depend on GDB, but the pattern I'm\r
+> proposing works for finer-grained prerequisites).  Plus, with the\r
+> above approach, if you don't have a prerequisite, the final tally\r
+> shows one failed test plus some number of skipped tests (and the total\r
+> number of tests never changes), which I would argue is cleaner.\r
+\r
+Much obliged for the correction!\r
+\r
+\r
+Peace\r
+\r
+\r
+[0] git://github.com/praet/notmuch.git\r
+    for-review/test-prereqs-v2\r
+    c9a785fc5c48db13\r
+\r
+-- \r
+Pieter\r