Re: [PATCH 1/3] emacs: add no-display arg to notmuch-hello-refresh-hook

diff --git a/e8/5d683eec8c849b486dd56c2218014937556cb1 b/e8/5d683eec8c849b486dd56c2218014937556cb1
new file mode 100644 (file)
index 0000000..1bf7036
--- /dev/null
+++ b/e8/5d683eec8c849b486dd56c2218014937556cb1
@@ -0,0 +1,97 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 3B0BB431E64\r
+       for <notmuch@notmuchmail.org>; Mon,  9 Jul 2012 18:49:50 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id HM9Lf74JFeUu for <notmuch@notmuchmail.org>;\r
+       Mon,  9 Jul 2012 18:49:49 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-4.mit.edu (DMZ-MAILSEC-SCANNER-4.MIT.EDU\r
+       [18.9.25.15])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8169C431FBF\r
+       for <notmuch@notmuchmail.org>; Mon,  9 Jul 2012 18:49:49 -0700 (PDT)\r
+X-AuditID: 1209190f-b7f306d0000008b4-85-4ffb8a3c72d2\r
+Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])\r
+       by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id AF.B7.02228.C3A8BFF4; Mon,  9 Jul 2012 21:49:48 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q6A1nmGC006944; \r
+       Mon, 9 Jul 2012 21:49:48 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q6A1nkYQ016560\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Mon, 9 Jul 2012 21:49:47 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1SoPaE-0002oy-B7; Mon, 09 Jul 2012 21:49:46 -0400\r
+Date: Mon, 9 Jul 2012 21:49:46 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Jani Nikula <jani@nikula.org>\r
+Subject: Re: [PATCH 1/3] emacs: add no-display arg to\r
+       notmuch-hello-refresh-hook\r
+Message-ID: <20120710014946.GB7332@mit.edu>\r
+References:\r
+ <37899e28dbf67e4620a53279a869be3174c02d6f.1339775602.git.jani@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To:\r
+ <37899e28dbf67e4620a53279a869be3174c02d6f.1339775602.git.jani@nikula.org>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IRYrdT17Xp+u1vMH+SjUXTdGeL6zdnMjsw\r
+       edy6/5rd49mqW8wBTFFcNimpOZllqUX6dglcGV37+hkL3rJVTG7tYGpgPM3axcjJISFgInFu\r
+       3wsWCFtM4sK99WwgtpDAPkaJnbeDuxi5gOz1jBLP189ghHBOMEms/v+AGcJZwijx7uUDJpAW\r
+       FgEViY/tvWBj2QQ0JLbtX84IYosIKEpsPrkfzGYWkJb49rsZrF5YIEii99ZBMJtXQFuifdle\r
+       qNWhEmd737FAxAUlTs58wgLRqyVx499LoHoOsDnL/3GAhDkFwiRebr7FDmKLAp0w5eQ2tgmM\r
+       QrOQdM9C0j0LoXsBI/MqRtmU3Crd3MTMnOLUZN3i5MS8vNQiXRO93MwSvdSU0k2MoKDmlOTf\r
+       wfjtoNIhRgEORiUe3k0sv/2FWBPLiitzDzFKcjApifIWdACF+JLyUyozEosz4otKc1KLDzFK\r
+       cDArifDecgXK8aYkVlalFuXDpKQ5WJTEea+m3PQXEkhPLEnNTk0tSC2CycpwcChJ8CZ1AjUK\r
+       FqWmp1akZeaUIKSZODhBhvMADe8BqeEtLkjMLc5Mh8ifYlSUEuctAUkIgCQySvPgemFJ5xWj\r
+       ONArwrylIFU8wIQF1/0KaDAT0OD2nl8gg0sSEVJSDYxJhgZxTyfnLvzhVsrgqsTBlm4z1b0/\r
+       PVqx6+lsMd/dqfHlB1gnte00bIh3K/Ttv5Bkft1vr85BvgP7Fq+Y/Fj9sn3dt5BTwjV3HzM9\r
+       eX3e5FeJ9so475UyRbl/ex4V2N0o4j4qWHI7dc5/uV38ep1rT/imh2RrOymfyEs9++J1XbSn\r
+       KNNGcyWW4oxEQy3mouJEAPMmG4wVAwAA\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 10 Jul 2012 01:49:50 -0000\r
+\r
+Quoth Jani Nikula on Jun 15 at  6:53 pm:\r
+> Add no-display arg to notmuch-hello-refresh-hook to allow each hook to\r
+> decide what is appropriate when no-display is t, which is typically\r
+> the case when called non-interactively. This is used by the following\r
+> patch.\r
+> \r
+> This breaks existing hooks people might have, which will now need to\r
+> accept the argument.\r
+> \r
+> Signed-off-by: Jani Nikula <jani@nikula.org>\r
+\r
+This seems like an overloaded use of no-display.  If I'm reading the\r
+code right, no-display indicates whether or not the notmuch-hello\r
+buffer should be switched to and seems like a workaround for some\r
+particular corner-case (I'm not even sure what).  This seems like a\r
+strange condition to predicate a hook on (but maybe I just don't\r
+understand).  What condition, abstractly speaking, is\r
+notmuch-hello-refresh-status-message trying to run under?\r