Re: [PATCH] Fix compilation warnings in test/smtp-dummy.c.

diff --git a/82/08333b3b07b1d63c4634ddac4dcc170e451a6a b/82/08333b3b07b1d63c4634ddac4dcc170e451a6a
new file mode 100644 (file)
index 0000000..73683b9
--- /dev/null
+++ b/82/08333b3b07b1d63c4634ddac4dcc170e451a6a
@@ -0,0 +1,97 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7656F429E25\r
+       for <notmuch@notmuchmail.org>; Tue, 21 Jun 2011 14:59:06 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.01\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.01 tagged_above=-999 required=5\r
+       tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id ucqo2mW4n6FO for <notmuch@notmuchmail.org>;\r
+       Tue, 21 Jun 2011 14:59:05 -0700 (PDT)\r
+Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2])\r
+       by olra.theworths.org (Postfix) with ESMTP id AD68A431FB6\r
+       for <notmuch@notmuchmail.org>; Tue, 21 Jun 2011 14:59:05 -0700 (PDT)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+       by arlo.cworth.org (Postfix) with ESMTP id 865DC29A4F5;\r
+       Tue, 21 Jun 2011 14:59:04 -0700 (PDT)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+       id 76050254157; Tue, 21 Jun 2011 14:59:04 -0700 (PDT)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] Fix compilation warnings in test/smtp-dummy.c.\r
+In-Reply-To: <1308220328-17995-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+References: <1308220328-17995-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1\r
+       (i486-pc-linux-gnu)\r
+Date: Tue, 21 Jun 2011 14:59:04 -0700\r
+Message-ID: <87r56methz.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 21 Jun 2011 21:59:06 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Thu, 16 Jun 2011 14:32:08 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmai=\r
+l.com> wrote:\r
+> * Remove unused variables in main(): buf, bytes and greeting.\r
+> * Replace return with no value in main() with exit(3).\r
+\r
+Thanks. I'd notice these occasionally when running the test suite and\r
+had meant for some time to fix them. But when doing my typical\r
+compilation within emacs, (with just "make"), I wouldn't get these\r
+warnings so I wasn't cleaning these in my typical work to make the\r
+compilation error/warning-free.\r
+\r
+I did follow up with a commit to prefer return (with a value) over\r
+exit(), which I applied throughout the main() function:\r
+\r
+commit b1aa676cca01ce0d907d220dc3c3a5142991c1cf\r
+Author: Carl Worth <cworth@cworth.org>\r
+Date:   Tue Jun 21 14:54:10 2011 -0700\r
+\r
+    smtp-dummy: Prefer return rather than exit() in main.\r
+=20=20=20=20\r
+    The main() function should be written as just another function with a\r
+    return value. This allows for more reliable code reuse. Imagine that\r
+    main() grows too large and needs to be factored into multiple\r
+    functions. At that point, exit() is probably the wrong thing, yet can\r
+    also be hard to notice as it's in less-frequently-tested exceptional\r
+    cases.\r
+\r
+\r
+=2DCarl\r
+\r
+=2D-=20\r
+carl.d.worth@intel.com\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iEYEARECAAYFAk4BFCgACgkQ6JDdNq8qSWjy3gCfdMiie3o2ug5hSzOjK11+1K2j\r
+iS4An33XAc/HV/MWqxmsB3CXai6e/zZX\r
+=KkGl\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r