Re: [PATCH 1/4] emacs: unify search mechanisms

diff --git a/16/2f5551597647731defc271a766e2fe90b49d44 b/16/2f5551597647731defc271a766e2fe90b49d44
new file mode 100644 (file)
index 0000000..26da430
--- /dev/null
+++ b/16/2f5551597647731defc271a766e2fe90b49d44
@@ -0,0 +1,107 @@
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 425F2429E5F\r
+       for <notmuch@notmuchmail.org>; Tue, 17 Jan 2012 11:36:13 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.7\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.7 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id kGWomz0uDeXJ for <notmuch@notmuchmail.org>;\r
+       Tue, 17 Jan 2012 11:36:12 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+       [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 7C222429E3B\r
+       for <notmuch@notmuchmail.org>; Tue, 17 Jan 2012 11:36:12 -0800 (PST)\r
+Received: by bkty12 with SMTP id y12so895924bkt.26\r
+       for <notmuch@notmuchmail.org>; Tue, 17 Jan 2012 11:36:11 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type;\r
+       bh=CSY35tTzg15ZpF/c4sMsupem+b2WV7x8zHN+iwv5PV8=;\r
+       b=dsHajYE0ZCc460pg3EEPksQS1Je/GYlF+j33GqL8hoBgbmfNF2e2rE/joBGbtftTGA\r
+       CJKZm1jY//JVAqIiZchkTxxX/D8ApZ+N5LawR6ZCiq9wVeHQABfBZli26YaOZAxusmnr\r
+       ZUMM7wQXej7SXE7mpfKzNzAG73MYpYeJSXJuA=\r
+Received: by 10.204.141.2 with SMTP id k2mr7431255bku.78.1326828971279;\r
+       Tue, 17 Jan 2012 11:36:11 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+       by mx.google.com with ESMTPS id ig13sm17069333bkc.9.2012.01.17.11.36.09\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Tue, 17 Jan 2012 11:36:09 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: Jani Nikula <jani@nikula.org>, David Edmondson <dme@dme.org>,\r
+       notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/4] emacs: unify search mechanisms\r
+In-Reply-To: <87boq3dein.fsf@nikula.org>\r
+References: <1324786495-14221-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <cunehuz5186.fsf@hotblack-desiato.hh.sledj.net>\r
+       <87ehuzvpul.fsf@gmail.com> <87boq3dein.fsf@nikula.org>\r
+User-Agent: Notmuch/0.11+73~g8a5402e (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 17 Jan 2012 23:35:14 +0400\r
+Message-ID: <87sjjew2a5.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 17 Jan 2012 19:36:13 -0000\r
+\r
+Hello.\r
+\r
+On Mon, 16 Jan 2012 12:21:20 +0000, Jani Nikula <jani@nikula.org> wrote:\r
+> On Mon, 16 Jan 2012 15:39:14 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
+> > On Mon, 16 Jan 2012 11:35:37 +0000, David Edmondson <dme@dme.org> wrote:\r
+> > > On Sun, 25 Dec 2011 08:14:52 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
+> > > > Before the change, there were two ways to do search in Emacs UI:\r
+> > > > search widget in notmuch-hello buffer and `notmuch-search'\r
+> > > > function bound to "s".  Internally, notmuch-hello search widget\r
+> > > > uses `notmuch-search' function.  But it uses widget field input\r
+> > > > instead of minibuffer.  Such duplication is a major issue for\r
+> > > > notmuch-hello usability: search interface is inconsistent and\r
+> > > > lacks features that are available in minibuffer (e.g. history and\r
+> > > > auto completion).  Some of these features may be relatively easy\r
+> > > > to implement for notmuch-hello search, others would be much more\r
+> > > > tricky.  So to avoid duplication, make UI more consistent, bring\r
+> > > > notmuch-hello search to feature parity with the minibuffer\r
+> > > > search, the patch replaces notmuch-hello search widget and with a\r
+> > > > button that works the same way as "s" key binding.\r
+> > > \r
+> > > Dmitry, if Daniel re-submits his patches to allow the construction of\r
+> > > `notmuch-hello' buffers to be configured, it seems that this patchset\r
+> > > would become unnecessary. Is that correct?\r
+> > \r
+> > Right.  We will just need to fix the 's' key binding.  Looking forward\r
+> > for that.\r
+> \r
+> Isn't (something like) this still needed to merge the search histories:\r
+> \r
+> id:"1324698436-8532-1-git-send-email-dmitry.kurochkin@gmail.com"\r
+> \r
+\r
+I have sent a new patch series implementing the changes [1].\r
+\r
+Regards,\r
+  Dmitry\r
+\r
+[1] id:1326828850-8519-1-git-send-email-dmitry.kurochkin@gmail.com\r
+\r
+> \r
+> Jani.\r