Re: [PATCH v2 1/3] Add 'compose' command

diff --git a/63/d714935f30c7d553cd0e71ad617f926066a737 b/63/d714935f30c7d553cd0e71ad617f926066a737
new file mode 100644 (file)
index 0000000..4c60870
--- /dev/null
+++ b/63/d714935f30c7d553cd0e71ad617f926066a737
@@ -0,0 +1,114 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 79C76431FB6\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Apr 2012 09:00:34 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 6gCDMd07H6lC for <notmuch@notmuchmail.org>;\r
+       Wed, 18 Apr 2012 09:00:30 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])\r
+       by olra.theworths.org (Postfix) with ESMTP id B63CF431FAE\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Apr 2012 09:00:29 -0700 (PDT)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id 9387568055; Wed, 18 Apr 2012 19:00:26 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Felipe Contreras <felipe.contreras@gmail.com>,\r
+       Jani Nikula <jani@nikula.org>\r
+Subject: Re: [PATCH v2 1/3] Add 'compose' command\r
+In-Reply-To:\r
+ <CAMP44s1117VXAOnURjFAeva93oiJsKKPji4awN_SoNFo0QvPPw@mail.gmail.com>\r
+References: <1334752753-23970-1-git-send-email-felipe.contreras@gmail.com>\r
+       <1334752753-23970-2-git-send-email-felipe.contreras@gmail.com>\r
+       <873981chpj.fsf@nikula.org>\r
+       <CAMP44s2Ukz=kDaPHYG+jzR3pDfZGP+6Ojqc4Xz5J8PxEd9fKcQ@mail.gmail.com>\r
+       <87vckxazq7.fsf@nikula.org>\r
+       <CAMP44s1117VXAOnURjFAeva93oiJsKKPji4awN_SoNFo0QvPPw@mail.gmail.com>\r
+User-Agent: Notmuch/0.12+113~gde05574 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 18 Apr 2012 19:00:26 +0300\r
+Message-ID: <m21unlc9np.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: Felipe Contreras <felipe.contreras@ngmail.com>, notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 18 Apr 2012 16:00:34 -0000\r
+\r
+On Wed, Apr 18 2012, Felipe Contreras <felipe.contreras@gmail.com> wrote:\r
+\r
+> On Wed, Apr 18, 2012 at 5:20 PM, Jani Nikula <jani@nikula.org> wrote:\r
+>> On Wed, 18 Apr 2012 16:34:30 +0300, Felipe Contreras <felipe.contreras@gmail.com> wrote:\r
+>>> On Wed, Apr 18, 2012 at 4:06 PM, Jani Nikula <jani@nikula.org> wrote:\r
+>>>\r
+>>> > Running "notmuch compose" more than once within a second would result in\r
+>>> > identical message ids for the messages, which is not a good idea. That's\r
+>>> > not likely in interactive use, but the notmuch cli is highly scriptable,\r
+>>> > so someone is bound to hit this.\r
+>>> >\r
+>>> > Some paranoid might also be worried about "leaking" the time you run\r
+>>> > "notmuch compose"... which may be different from the actual time you\r
+>>> > send the message.\r
+>>>\r
+>>> It's still better than the current situation; nothing. In any case,\r
+>>> people that have not needed this would not be affected; their UI would\r
+>>> override the Message-ID.\r
+>>>\r
+>>> So do you have a better suggestion for a Message-ID?\r
+>>\r
+>> The easy way would be to just use g_mime_utils_generate_message_id()\r
+>> [1]. It doesn't give you any control of the part before @, but I'm not\r
+>> sure if that really matters.\r
+>\r
+> This is what gmime does:\r
+> g_strdup_printf ("%lu.%lu.%lu@%s", (unsigned long int) time (NULL),\r
+> (unsigned long int) getpid (), count++, fqdn);\r
+>\r
+> Which actually has some of the issues you mentioned.\r
+>\r
+> I can do the same if you want (add pid and count). The advantage of\r
+> using our own format is that not only would it be more unique, but it\r
+> would not have "@fqdn".\r
+\r
+getpid() is good. I guess count is useless (always one). Now some ideas\r
+how to obfuscate time(NULL) (nonce + hash (crc32 good enough?) ?\r
+\r
+Tomi\r
+\r
+>\r
+>> Alternatively you can write your own according to e.g. [2]. Glib appears\r
+>> to have decent and portable support for pseudo random number\r
+>> generation. But why bother? I'd go with gmime.\r
+>\r
+> But gmime doesn't have anything random. I would actually prefer to\r
+> have something random though.\r
+\r
+\r
+\r
+>\r
+> -- \r
+> Felipe Contreras\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r