Re: [PATCH] configure: add workaround for systems without zlib.pc
authorDavid Bremner <david@tethera.net>
Sat, 14 Jun 2014 01:47:56 +0000 (22:47 +2100)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 18:03:12 +0000 (10:03 -0800)
15/ec7ed831a3ee6cba2d84b75a55cab578a811cb [new file with mode: 0644]

diff --git a/15/ec7ed831a3ee6cba2d84b75a55cab578a811cb b/15/ec7ed831a3ee6cba2d84b75a55cab578a811cb
new file mode 100644 (file)
index 0000000..ea92b9f
--- /dev/null
@@ -0,0 +1,85 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 165FF431FBC\r
+       for <notmuch@notmuchmail.org>; Fri, 13 Jun 2014 18:48:16 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 88M40-s7NvO7 for <notmuch@notmuchmail.org>;\r
+       Fri, 13 Jun 2014 18:48:06 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id AB0A1431FAF\r
+       for <notmuch@notmuchmail.org>; Fri, 13 Jun 2014 18:48:06 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1Wvd4a-0002qE-7M; Fri, 13 Jun 2014 22:48:00 -0300\r
+Received: (nullmailer pid 1968 invoked by uid 1000); Sat, 14 Jun 2014\r
+       01:47:56 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, Felipe Contreras\r
+       <felipe.contreras@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] configure: add workaround for systems without zlib.pc\r
+In-Reply-To: <m2wqdrqay8.fsf@guru.guru-group.fi>\r
+References: <1399864172-28227-1-git-send-email-felipe.contreras@gmail.com>\r
+       <m2wqdrqay8.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Fri, 13 Jun 2014 22:47:56 -0300\r
+Message-ID: <87ha3o5kj7.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 14 Jun 2014 01:48:16 -0000\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+>> +static const char *template =\r
+>> +   "prefix=/usr\n"\r
+>> +   "exec_prefix=${prefix}\n"\r
+>> +   "libdir=${exec_prefix}/lib\n"\r
+>> +   "\n"\r
+>> +   "Name: zlib\n"\r
+>> +   "Description: zlib compression library\n"\r
+>> +   "Version: %s\n"\r
+>> +   "Libs: -lz\n";\r
+>\r
+> The above is bit different what zlib.pc files have in e.g. Fedora 20 and\r
+> Ubuntu 14.04 machines: those have 'Requires: before Libs: (and Cflags:)'\r
+> But probably that is unnecessary (and just some sugar coating...?).\r
+>\r
+\r
+it seems consistent with the 'foo' example at\r
+\r
+   http://people.freedesktop.org/~dbn/pkg-config-guide.html#writing\r
+\r
+>\r
+> To be consistent what we do elsewhere:\r
+>\r
+>   PKG_CONFIG_PATH=${PKG_CONFIG_PATH:+$PKG_CONFIG_PATH:}compat &&\r
+>\r
+> i.e. don't add ':' in case $PKG_CONFIG_PATH is not defined or is empty string.\r
+\r
+What Tomi writes here sounds correct to me. I guess empty PKG_CONFIG_PATH is\r
+probably the most common case.\r
+\r
+d\r