Re: [PATCH 1/7] go: Use iota in enum bindings
authorSebastien Binet <binet@cern.ch>
Wed, 18 Jul 2012 20:36:48 +0000 (22:36 +0200)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:48:23 +0000 (09:48 -0800)
e7/37d96a31c886af6fe50b4efb0c3608da946890 [new file with mode: 0644]

diff --git a/e7/37d96a31c886af6fe50b4efb0c3608da946890 b/e7/37d96a31c886af6fe50b4efb0c3608da946890
new file mode 100644 (file)
index 0000000..b9ce7c0
--- /dev/null
@@ -0,0 +1,90 @@
+Return-Path: <sebastien.binet@cern.ch>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5A951431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Jul 2012 13:37:37 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -5\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-5 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_HI=-5] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 2FkNYtjj+dHJ for <notmuch@notmuchmail.org>;\r
+       Wed, 18 Jul 2012 13:37:36 -0700 (PDT)\r
+Received: from CERNMX32.cern.ch (cernmx32.cern.ch [137.138.144.178])\r
+       (using TLSv1 with cipher AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 88362431FAE\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Jul 2012 13:37:36 -0700 (PDT)\r
+Received: from CERNFE22.cern.ch (137.138.144.151) by cernmxgwlb2.cern.ch\r
+       (137.138.144.178) with Microsoft SMTP Server (TLS) id 14.2.283.3;\r
+       Wed, 18 Jul 2012 22:37:34 +0200\r
+Received: from localhost (134.158.88.68) by smtp.cern.ch (137.138.144.172)\r
+       with Microsoft SMTP Server (TLS) id 14.2.298.4;\r
+       Wed, 18 Jul 2012 22:37:34 +0200\r
+From: Sebastien Binet <binet@cern.ch>\r
+To: Austin Clements <amdragon@MIT.EDU>, Adrien Bustany <adrien@bustany.org>\r
+Subject: Re: [PATCH 1/7] go: Use iota in enum bindings\r
+In-Reply-To: <20120718201748.GS31670@mit.edu>\r
+References: <1342636475-16057-1-git-send-email-adrien@bustany.org>\r
+       <1342636475-16057-2-git-send-email-adrien@bustany.org>\r
+       <20120718201748.GS31670@mit.edu>\r
+User-Agent: Notmuch/0.13.2+77~g39beeb2 (http://notmuchmail.org) Emacs/24.1.1\r
+       (x86_64-unknown-linux-gnu)\r
+Date: Wed, 18 Jul 2012 22:36:48 +0200\r
+Message-ID: <87fw8ox0v3.fsf@cern.ch>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1;\r
+       protocol="application/pgp-signature"\r
+X-Originating-IP: [134.158.88.68]\r
+Keywords: CERN SpamKiller Note: -50\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 18 Jul 2012 20:37:37 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain\r
+\r
+Austin Clements <amdragon@MIT.EDU> writes:\r
+\r
+> Hah.  I guess nobody has tried to modify a notmuch database using the\r
+> Go bindings.\r
+>\r
+> Could this instead assign the constants to\r
+> C.NOTMUCH_DATABASE_MODE_READ_ONLY, etc, rather than duplicating their\r
+> values?  It would be nice to do that for the Status values as well\r
+> (which are correctly using iota, at least).\r
+\r
+yep.\r
+I have a few fixes like that in my repo:\r
+https://github.com/sbinet/notmuch/commits/dev/go-bindings/bindings/go/src/notmuch\r
+\r
+https://github.com/sbinet/notmuch/commit/38713de1b90a29b66b2a7f310065a3ffcf527d9b#L1L88\r
+\r
+-s\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v2.0.19 (GNU/Linux)\r
+\r
+iEYEARECAAYFAlAHHoEACgkQPj4AVbsZCCZRIwCfby8nRaaS5KH5dps8JkOqtFLZ\r
+xvEAnjFDHq1SD1dGQDWt4pAp94iSblmB\r
+=QfDt\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r