[PATCH v3 09/12] emacs: relax tag syntax check in `notmuch-tag' function
authorDmitry Kurochkin <dmitry.kurochkin@gmail.com>
Mon, 30 Jan 2012 05:34:01 +0000 (09:34 +0400)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:43:35 +0000 (09:43 -0800)
b7/65b41c4ef39d4263d561393ade85694d21caca [new file with mode: 0644]

diff --git a/b7/65b41c4ef39d4263d561393ade85694d21caca b/b7/65b41c4ef39d4263d561393ade85694d21caca
new file mode 100644 (file)
index 0000000..35f21b4
--- /dev/null
@@ -0,0 +1,85 @@
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5BAEE421192\r
+       for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 21:36:08 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id QONtkJAJeDxN for <notmuch@notmuchmail.org>;\r
+       Sun, 29 Jan 2012 21:36:07 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+       [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 8E2E8421166\r
+       for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 21:35:33 -0800 (PST)\r
+Received: by mail-bk0-f53.google.com with SMTP id 11so1052482bke.26\r
+       for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 21:35:33 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+       h=from:to:subject:date:message-id:x-mailer:in-reply-to:references;\r
+       bh=887hgYz7Xoetg5VdjB26vqceBsGKNEgogb8wZrkNq1I=;\r
+       b=s2Fs+V/RBD55mXgNq0XS5C2Ok33kStEGk7umCA5uOTOZ96ZduaglFRbj1ryxN+LsuI\r
+       rkGFPsE6pBSx4iWIEy8dszUYcOfceWLvtBLbJs95Fdql7PoS/7MJhkppl3TMDDYBWza3\r
+       UPY/fa0r7CDBQ7imFTak7tBzmPVoWBFRJdPg4=\r
+Received: by 10.204.152.88 with SMTP id f24mr7541814bkw.31.1327901733318;\r
+       Sun, 29 Jan 2012 21:35:33 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+       by mx.google.com with ESMTPS id x20sm19930970bka.9.2012.01.29.21.35.32\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Sun, 29 Jan 2012 21:35:32 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH v3 09/12] emacs: relax tag syntax check in `notmuch-tag'\r
+       function\r
+Date: Mon, 30 Jan 2012 09:34:01 +0400\r
+Message-Id: <1327901644-15799-10-git-send-email-dmitry.kurochkin@gmail.com>\r
+X-Mailer: git-send-email 1.7.8.3\r
+In-Reply-To: <1327901644-15799-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+References: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <1327901644-15799-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 30 Jan 2012 05:36:09 -0000\r
+\r
+The tag syntax check in `notmuch-tag' function was too strict and did\r
+not allow nmbug tags with "::".  Since the check is done for all\r
+tagging operations in Emacs UI, this basically means that no nmbug\r
+tags can be changed.  The patch relaxes the tag syntax check to allow\r
+any tag names that do not include whitespace characters.\r
+---\r
+ emacs/notmuch.el |    2 +-\r
+ 1 files changed, 1 insertions(+), 1 deletions(-)\r
+\r
+diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+index 0a3bd17..2332c42 100644\r
+--- a/emacs/notmuch.el\r
++++ b/emacs/notmuch.el\r
+@@ -556,7 +556,7 @@ notmuch-after-tag-hook will be run."\r
+   ;; Perform some validation\r
+   (when (null tags) (error "No tags given"))\r
+   (mapc (lambda (tag)\r
+-        (unless (string-match-p "^[-+][-+_.[:word:]]+$" tag)\r
++        (unless (string-match-p "^[-+]\\S-+$" tag)\r
+           (error "Tag must be of the form `+this_tag' or `-that_tag'")))\r
+       tags)\r
+   (run-hooks 'notmuch-before-tag-hook)\r
+-- \r
+1.7.8.3\r
+\r