[PATCH] Don't involve the shell in notmuch searches

diff --git a/6f/8708757b1cbdb8b69c4cdf2f33af9c73fc3702 b/6f/8708757b1cbdb8b69c4cdf2f33af9c73fc3702
new file mode 100644 (file)
index 0000000..56bb071
--- /dev/null
+++ b/6f/8708757b1cbdb8b69c4cdf2f33af9c73fc3702
@@ -0,0 +1,82 @@
+Return-Path: <davidben@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8FE264196F0\r
+       for <notmuch@notmuchmail.org>; Thu,  3 Jun 2010 17:29:48 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.8\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.8 tagged_above=-999 required=5 tests=[BAYES_50=0.8]\r
+       autolearn=ham\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id VPvcA0852iE9 for <notmuch@notmuchmail.org>;\r
+       Thu,  3 Jun 2010 17:29:38 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU\r
+       [18.7.68.35])\r
+       by olra.theworths.org (Postfix) with ESMTP id 54717431FC1\r
+       for <notmuch@notmuchmail.org>; Thu,  3 Jun 2010 17:29:38 -0700 (PDT)\r
+X-AuditID: 12074423-b7c0bae0000030f0-ed-4c0848f1ba27\r
+Received: from mailhub-auth-4.mit.edu (MAILHUB-AUTH-4.MIT.EDU [18.7.62.39])\r
+       by dmz-mailsec-scanner-6.mit.edu (Symantec Brightmail Gateway) with\r
+       SMTP id 1E.E8.12528.1F8480C4; Thu,  3 Jun 2010 20:29:37 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id o540TaSO028733\r
+       for <notmuch@notmuchmail.org>; Thu, 3 Jun 2010 20:29:36 -0400\r
+Received: from localhost.localdomain (ET-SIXTY.MIT.EDU [18.208.1.60])\r
+       (authenticated bits=0)\r
+       (User authenticated as davidben@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id o540TWgG011376\r
+       (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT)\r
+       for <notmuch@notmuchmail.org>; Thu, 3 Jun 2010 20:29:36 -0400 (EDT)\r
+From: David Benjamin <davidben@MIT.EDU>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH] Don't involve the shell in notmuch searches\r
+Date: Thu,  3 Jun 2010 20:29:32 -0400\r
+Message-Id: <1275611372-5810-1-git-send-email-davidben@mit.edu>\r
+X-Mailer: git-send-email 1.7.1.1.gee92\r
+X-Brightmail-Tracker: AAAAAA==\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 04 Jun 2010 00:29:48 -0000\r
+\r
+The shell isn't needed to interpret any of the arguments, so don't\r
+bother using it at all.\r
+\r
+Signed-off-by: David Benjamin <davidben@mit.edu>\r
+---\r
+ emacs/notmuch.el |    4 ++--\r
+ 1 files changed, 2 insertions(+), 2 deletions(-)\r
+\r
+diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+index 57e1140..874ccb9 100644\r
+--- a/emacs/notmuch.el\r
++++ b/emacs/notmuch.el\r
+@@ -710,10 +710,10 @@ The optional parameters are used as follows:\r
+       (erase-buffer)\r
+       (goto-char (point-min))\r
+       (save-excursion\r
+-      (let ((proc (start-process-shell-command\r
++      (let ((proc (start-process\r
+                    "notmuch-search" buffer notmuch-command "search"\r
+                    (if oldest-first "--sort=oldest-first" "--sort=newest-first")\r
+-                   (shell-quote-argument query))))\r
++                   query)))\r
+         (set-process-sentinel proc 'notmuch-search-process-sentinel)\r
+         (set-process-filter proc 'notmuch-search-process-filter))))\r
+     (run-hooks 'notmuch-search-hook)))\r
+-- \r
+1.7.1.1.gee92\r
+\r