Re: [BUG/PATCH v2 1/2] emacs: Fix header problem in reply for emacs 23.2

diff --git a/ab/7c2276bedd0e7bbf5ede0d7dcd52ff58b255e2 b/ab/7c2276bedd0e7bbf5ede0d7dcd52ff58b255e2
new file mode 100644 (file)
index 0000000..c5e1b26
--- /dev/null
+++ b/ab/7c2276bedd0e7bbf5ede0d7dcd52ff58b255e2
@@ -0,0 +1,105 @@
+Return-Path: <awg@xvx.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id F3B88431E82\r
+       for <notmuch@notmuchmail.org>; Sat, 31 Mar 2012 16:36:29 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 0JsRnXSaad2x for <notmuch@notmuchmail.org>;\r
+       Sat, 31 Mar 2012 16:36:29 -0700 (PDT)\r
+Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com\r
+       [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 2E262431FAF\r
+       for <notmuch@notmuchmail.org>; Sat, 31 Mar 2012 16:36:29 -0700 (PDT)\r
+Received: by lahc1 with SMTP id c1so2030783lah.26\r
+       for <notmuch@notmuchmail.org>; Sat, 31 Mar 2012 16:36:27 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=google.com; s=20120113;\r
+       h=mime-version:sender:x-originating-ip:in-reply-to:references:date\r
+       :x-google-sender-auth:message-id:subject:from:to:cc:content-type\r
+       :x-gm-message-state;\r
+       bh=6l1ZePoMfJXAxwz01Sv2AMEMb1au8wY70tLmPkiDP4E=;\r
+       b=niiFS0X0FLmTwZkyh5fmiOaufaQ5/2ZVobQMDgB9ryFlvZg+1oD0UAd3e8ENsgNm2S\r
+       e4qqx9MDU7GHYQ08CNsCCDB/Ggpii/ceIv9zV+gu5SI5v8g4lixeQaPMv5lSlhyxbFHR\r
+       EERpdA79/GsakS2JipPqHb/1kLvZvV1DGkIQWG19lEbvn5QyWpaOOGQPSI8TeAlmWm9W\r
+       n5z8O+vAzsm4P6V2zsZaHBNaxm6NQVYiw5qurUT5DMbQwzNy3Av3mIElk34eHCVN1c8j\r
+       0iWlWVi637ysTSJ1RvAxjZBS8ZziNvQRWX1pxKE97B/mqQCGIiG4W1B3RkVYdj8M+VhX\r
+       IoCg==\r
+MIME-Version: 1.0\r
+Received: by 10.152.148.234 with SMTP id tv10mr3782185lab.41.1333236987446;\r
+       Sat, 31 Mar 2012 16:36:27 -0700 (PDT)\r
+Sender: awg@xvx.ca\r
+Received: by 10.112.97.14 with HTTP; Sat, 31 Mar 2012 16:36:27 -0700 (PDT)\r
+X-Originating-IP: [96.52.216.56]\r
+In-Reply-To: <87k42116b2.fsf@qmul.ac.uk>\r
+References: <1333038410-17927-1-git-send-email-awg+notmuch@xvx.ca>\r
+       <1333038410-17927-2-git-send-email-awg+notmuch@xvx.ca>\r
+       <87k42116b2.fsf@qmul.ac.uk>\r
+Date: Sat, 31 Mar 2012 17:36:27 -0600\r
+X-Google-Sender-Auth: WSAoc8Fee72nCGPtNChxiF-S0u0\r
+Message-ID:\r
+ <CAMoJFUvMW1SCj843N5yj8LJJF=r-kSEe=Rvue=7x5Rwgm+A1pw@mail.gmail.com>\r
+Subject: Re: [BUG/PATCH v2 1/2] emacs: Fix header problem in reply for emacs\r
+       23.2\r
+From: Adam Wolfe Gordon <awg+notmuch@xvx.ca>\r
+To: Mark Walters <markwalters1009@gmail.com>\r
+Content-Type: text/plain; charset=ISO-8859-1\r
+X-Gm-Message-State:\r
+ ALoCoQmgh88oNhdnhZ0OdYuG/IE/dPQ0sVdFR786TlxZVSxAeiwd1TQayJOUeT8yiCbpmju12E/6\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 31 Mar 2012 23:36:30 -0000\r
+\r
+Hi Mark,\r
+\r
+On Sat, Mar 31, 2012 at 03:13, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> Secondly it seems a little odd that the second patch above changes the\r
+> header stuff from 'From to "From" and then this patch changes it back\r
+> again. This is probably only a matter of a tidy history but I have to\r
+> admit I am confused about why the reply from alternate address still\r
+> works (but it does seem to)\r
+\r
+Good question. These three bugs (alternate address, References header,\r
+double headers in 23.2) basically stem from two problems: poor\r
+interactions between notmuch and message.el, and inconsistency in\r
+using strings and symbols for header names.\r
+\r
+All the message.el functions usually assume symbols for header names,\r
+but when I was writing the new reply stuff I found it easier to use\r
+strings. In emacs 23.3, message.el is happy to accept strings. The\r
+alternate address bug was caused by the fact that we were using\r
+strings in one place and symbols in another, and 'From isn't equal to\r
+"From". Rather than changing everything to symbols, I just changed the\r
+one place we were using symbols to use strings.\r
+\r
+But, it turns out that emacs 23.2 isn't happy with strings, which\r
+caused the double headers bug. So I ended up converting everything to\r
+use symbols. Because we're now consistent in using symbols, and never\r
+pass strings to message.el, the alternate address bug is still fixed.\r
+\r
+All that's a long way of saying: the fix for emacs 23.2 should\r
+actually fix the alternate reply bug as well. This probably means I\r
+could drop the alternate reply bug patch, and rebase the other two\r
+onto master, and we'd still have all the bugs fixed. Is that\r
+preferable, to reduce the number of code changes in the history?\r
+\r
+-- Adam\r