Re: [PATCH v3 2/2] search: Support automatic tag exclusions

diff --git a/04/0a3926f382091a9c3b4e61767c5d702e6caa57 b/04/0a3926f382091a9c3b4e61767c5d702e6caa57
new file mode 100644 (file)
index 0000000..9d315dd
--- /dev/null
+++ b/04/0a3926f382091a9c3b4e61767c5d702e6caa57
@@ -0,0 +1,120 @@
+Return-Path: <pieter@praet.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 57A65429E54\r
+       for <notmuch@notmuchmail.org>; Sun, 22 Jan 2012 20:17:16 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id i9gTwIc+MhHE for <notmuch@notmuchmail.org>;\r
+       Sun, 22 Jan 2012 20:17:15 -0800 (PST)\r
+Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com\r
+       [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 8C73D429E40\r
+       for <notmuch@notmuchmail.org>; Sun, 22 Jan 2012 20:17:15 -0800 (PST)\r
+Received: by wibhi8 with SMTP id hi8so303278wib.26\r
+       for <notmuch@notmuchmail.org>; Sun, 22 Jan 2012 20:17:12 -0800 (PST)\r
+Received: by 10.180.94.97 with SMTP id db1mr10641843wib.16.1327292232854;\r
+       Sun, 22 Jan 2012 20:17:12 -0800 (PST)\r
+Received: from localhost ([109.131.95.182])\r
+       by mx.google.com with ESMTPS id em13sm10720314wid.7.2012.01.22.20.17.11\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Sun, 22 Jan 2012 20:17:11 -0800 (PST)\r
+From: Pieter Praet <pieter@praet.org>\r
+To: Xavier Maillard <xma@gnu.org>, Austin Clements <amdragon@MIT.EDU>\r
+Subject: Re: [PATCH v3 2/2] search: Support automatic tag exclusions\r
+In-Reply-To: <m2ty3n2xut.fsf@kcals.intra.maillard.im>\r
+References: <1326586654-16840-3-git-send-email-amdragon@mit.edu>\r
+       <1327000744-25463-1-git-send-email-pieter@praet.org>\r
+       <m2ty3n2xut.fsf@kcals.intra.maillard.im>\r
+User-Agent: Notmuch/0.11+101~g94bf862 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+Date: Mon, 23 Jan 2012 05:15:18 +0100\r
+Message-ID: <87ty3nawbt.fsf@praet.org>\r
+MIME-Version: 1.0\r
+X-Gm-Message-State:\r
+ ALoCoQmg8jOoz0TdP6EsrW7ZCUoBj7ghNb/iTQB82rwcj8LlizqbYOyOgz2aP/Judl7//4BbB1jK\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 23 Jan 2012 04:17:16 -0000\r
+\r
+On Sun, 22 Jan 2012 23:09:30 +0100, Xavier Maillard <xavier@maillard.im> wrote:\r
+> Hey Pieter,\r
+> \r
+\r
+Hi!\r
+\r
+> On Thu, 19 Jan 2012 20:19:00 +0100, Pieter Praet <pieter@praet.org> wrote:\r
+> > Nice feature!  I won't be using it myself, but I can imagine it being\r
+> > *very* useful for those who still feel the need to "delete" email :).\r
+> \r
+> Adding a 'deleted' tag does not mean there will be a delete/purge\r
+> process ;) (currently I got 5k messages with the tag deleted ;). \r
+> \r
+\r
+Very true, that's why I put quotes around "delete".\r
+\r
+Deleting email for real is *so* old-fashioned... :D ;)\r
+\r
+> > Nitpicking:\r
+> > \r
+> \r
+> [ ... ]\r
+> \r
+> >   So I'd like to suggest replacing all occurences of "auto_exclude_tags"\r
+> >   with "search_exclude_tags" (and simply "exclude_tags" in the args to\r
+> >   `_config_get_list' and `_config_set_list', of course).\r
+> \r
+> +1\r
+>  \r
+> >   Unfortunately, this would also partially invalidate your recent NEWS\r
+> >   submission [2].\r
+> > \r
+> > - If the 'search.exclude_tags' option is missing from the config file,\r
+> >   its value is automatically set to "deleted;spam;", which probably isn't\r
+> >   a sane default.  Luckily, you've already provided the solution [3].\r
+> \r
+> I am against doing something /unsafe/ in the user's back. If there is no\r
+> option set intentionnaly by the user, there is nothing notmuch should\r
+> do -i.e no exclusion -\r
+> \r
+\r
+Absolutely.  Actually, that's *exactly* what I meant.\r
+\r
+I thought that would be pretty clear, but perhaps it wasn't.\r
+I've reworded some of the commit messages, and will pay more\r
+attention to it in the future.\r
+\r
+> > - To make new users aware of the config option's existence, we should\r
+> >   prompt them to configure it during setup.\r
+> \r
+> +1\r
+> \r
+> /Xavier\r
+\r
+Thanks for your input!\r
+\r
+\r
+Peace\r
+\r
+-- \r
+Pieter\r