Re: [PATCH 1/2] moved _notmuch_get_list () and _notmuch_set_list () up in file

diff --git a/5f/1514c18651e3d66921556712102194bf173c9c b/5f/1514c18651e3d66921556712102194bf173c9c
new file mode 100644 (file)
index 0000000..1cbd177
--- /dev/null
+++ b/5f/1514c18651e3d66921556712102194bf173c9c
@@ -0,0 +1,110 @@
+Return-Path: <glasse@cs.rpi.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id B4842431FBC\r
+       for <notmuch@notmuchmail.org>; Fri, 27 Jan 2012 10:19:43 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.54\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.54 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       RCVD_IN_BL_SPAMCOP_NET=1.246, RCVD_IN_DNSWL_MED=-2.3,\r
+       RCVD_IN_SORBS_WEB=0.614] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 6z0MXmApR69f for <notmuch@notmuchmail.org>;\r
+       Fri, 27 Jan 2012 10:19:43 -0800 (PST)\r
+Received: from cliffclavin.cs.rpi.edu (cliffclavin.cs.rpi.edu\r
+ [128.113.126.25])     (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)       by olra.theworths.org (Postfix) with ESMTPS\r
+ id F3795431FAE        for <notmuch@notmuchmail.org>; Fri, 27 Jan 2012 10:19:42 -0800\r
+ (PST)\r
+X-Hash: SCtCte|aa3172f9bebf027dc1fd1da71bbc9c65535d1721|2496b17db9ee623b88d706c775242a92\r
+X-Countries: Cameroon, United States\r
+X-SMTP-From: accepted <glasse@cs.rpi.edu> [195.24.209.21] [195.24.209.21]\r
+       ([10.0.13.172]) {Cameroon}\r
+DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=cs.rpi.edu; h=\r
+       message-id:date:from:mime-version:to:cc:subject:references\r
+       :in-reply-to:content-type:content-transfer-encoding; s=default;\r
+       i=glasse@cs.rpi.edu; t=1327688376; x=1328293176; l=1165; bh=VUA\r
+       ICcnNUkSNKWMPCmp7o7v4dxM=; b=kXAVGN6iepKzgPGFQ2+EWsRWIWdmAIgvbAk\r
+       saeQnnd5/MPagAzi9EFi5rIbemMC2x+VmAaRTVmLn/k4sVet4J6trP8QfqVRp6IK\r
+       VPqUmo8BAa4c5Qb+fjFDHRlTZy+q7XjAKkwZgIK1W2rQQyqP554oS9dV8Qtd7HHe\r
+       39xBtR1U=\r
+DomainKey-Signature: a=rsa-sha1; c=nofws; d=cs.rpi.edu; h=message-id\r
+       :date:from:mime-version:to:cc:subject:references:in-reply-to\r
+       :content-type:content-transfer-encoding; q=dns; s=default; b=KIR\r
+       k5/TAfDi2Uhy2wlscof6WOQWEkk5z0viAL7e1srXgjVoDJeh9PCCmBhFCb81MP6k\r
+       xsp05pDXSKcLgKJsMOczBxaK+oOH+qQ/8uHFafwBqWt57Ymlbw4EOvDmN132AfzL\r
+       uT9agG4IMz3p1AFSkF6689hioe6ZOuVWqTjbUReY=\r
+X-Spam-Info: -2.7; ALL_TRUSTED,AWL,BAYES_00\r
+X-Spam-Scanned-By: cliffclavin.cs.rpi.edu using SpamAssassin 3.2.5 (hard limit\r
+       15)\r
+Authentication-Results: cliffclavin.cs.rpi.edu;\r
+       DKIM=neutral (none) header.from=glasse@cs.rpi.edu;\r
+       SPF=neutral (mfrom;\r
+       Mechanism '?all' matched) smtp.mail=glasse@cs.rpi.edu\r
+X-Auth-Passed: cliffclavin.cs.rpi.edu:q0RIJ6qf057776 Auth:glasse\r
+X-Virus-Scanned-By: cliffclavin.cs.rpi.edu\r
+Received: from [10.0.13.172] ([195.24.209.21]) (authenticated bits=0)\r
+       by cliffclavin.cs.rpi.edu (8.14.3/8.14.3) with ESMTP id q0RIJ6qf057776\r
+       (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);\r
+       Fri, 27 Jan 2012 13:19:31 -0500 (EST)\r
+       (envelope-from glasse@cs.rpi.edu)\r
+Message-ID: <4F22EA91.4020006@cs.rpi.edu>\r
+Date: Fri, 27 Jan 2012 13:18:57 -0500\r
+From: Ethan Glasser-Camp <glasse@cs.rpi.edu>\r
+User-Agent: Mozilla/5.0 (X11; Linux i686;\r
+       rv:8.0) Gecko/20111124 Thunderbird/8.0\r
+MIME-Version: 1.0\r
+To: Tomi Ollila <tomi.ollila@iki.fi>\r
+Subject: Re: [PATCH 1/2] moved _notmuch_get_list () and _notmuch_set_list\r
+       () up in file\r
+References: <8762g0sj6f.fsf@praet.org>\r
+       <1327572718-13411-1-git-send-email-tomi.ollila@iki.fi>\r
+       <87sjj2ipjh.fsf@nikula.org> <m2d3a5juj0.fsf@guru.guru-group.fi>\r
+In-Reply-To: <m2d3a5juj0.fsf@guru.guru-group.fi>\r
+Content-Type: text/plain; charset=ISO-8859-1; format=flowed\r
+Content-Transfer-Encoding: 7bit\r
+X-Scanned-By: MIMEDefang 2.67 on 128.113.126.25\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 27 Jan 2012 18:19:43 -0000\r
+\r
+On 01/27/2012 05:42 AM, Tomi Ollila wrote:\r
+> On Thu, 26 Jan 2012 13:03:46 +0000, Jani Nikula<jani@nikula.org>  wrote:\r
+>> On Thu, 26 Jan 2012 12:11:57 +0200, Tomi Ollila<tomi.ollila@iki.fi>  wrote:\r
+>>> Moved _notmuch_get_list () and _notmuch_set_list () to a location\r
+>>> in notmuch-config.c so that new functions that will be located\r
+>>> before the old location of those functions can also use these.\r
+>> Parse error. ;)\r
+>>\r
+>> You mean something along the lines of: "Move _notmuch_get_list () and\r
+>> _notmuch_set_list () earlier in the file to avoid forward declarations\r
+>> in further work. No functional changes."\r
+>>\r
+>> I'm sure native speakers can bikeshed that further. ;)\r
+> Ok, they haven't. I'n resubmit this alone with better commit\r
+> message -- I look the other after I have better time.\r
+\r
+As a native speaker, your new version is acceptable but I found "in \r
+further work" a little odd. (Depending on what you meant, I'd say "in \r
+upcoming patches".) The thing I found most confusing about the comment \r
+is that the functions aren't called _notmuch_get_list or \r
+_notmuch_set_list (instead they are _config_get_list and _config_set_list.)\r
+\r
+Ethan\r
+\r