Re: [PATCH 2/2] emacs: fix `notmuch-wash-region-to-button' to work at beginning of...

diff --git a/b2/16fcea1155886e9472b385100502da21ecb846 b/b2/16fcea1155886e9472b385100502da21ecb846
new file mode 100644 (file)
index 0000000..9bada47
--- /dev/null
+++ b/b2/16fcea1155886e9472b385100502da21ecb846
@@ -0,0 +1,73 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id D757C431E64\r
+       for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 06:11:01 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id kEzsPJhZedWo for <notmuch@notmuchmail.org>;\r
+       Mon, 30 Jan 2012 06:11:01 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])\r
+       by olra.theworths.org (Postfix) with ESMTP id 6E068431FBC\r
+       for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 06:11:01 -0800 (PST)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id AC7AD68056; Mon, 30 Jan 2012 16:11:03 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/2] emacs: fix `notmuch-wash-region-to-button' to work at\r
+       beginning of buffer\r
+In-Reply-To: <1327926286-16680-3-git-send-email-dmitry.kurochkin@gmail.com>\r
+References: <1327926286-16680-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <1327926286-16680-3-git-send-email-dmitry.kurochkin@gmail.com>\r
+User-Agent: Notmuch/0.11+129~g3b527ae (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 30 Jan 2012 16:11:03 +0200\r
+Message-ID: <m2bopl9t6w.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 30 Jan 2012 14:11:02 -0000\r
+\r
+On Mon, 30 Jan 2012 16:24:46 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
+> `Notmuch-wash-region-to-button' is the function that creates hidden\r
+> regions with buttons for signatures, citations and original messages.\r
+> Before the change, it did not work correctly if the to-be-hidden\r
+> region started at the beginning of a message: the visibility toggle\r
+> button was hidden as well.  The patch fixes this.  There are two parts\r
+> in the fix:\r
+> \r
+> * Use `insert-before-markers' instead of `insert' for creating the\r
+>   button, so that it does not get added to the hidden overlay.\r
+> \r
+> * Stop using PREFIX argument for adding a newline before the button.\r
+>   The newline should not be added before a button at the beginning of\r
+>   buffer.\r
+> \r
+> The corresponding test is fixed now.\r
+> ---\r
+\r
++1 -- for test and fix.\r
+\r
+\r
+Tomi\r