Re: [notmuch] [PATCH] Add install target for desktop files.

diff --git a/90/51fe7ca2be1fefde5f10f6d56b7b8b45018ec9 b/90/51fe7ca2be1fefde5f10f6d56b7b8b45018ec9
new file mode 100644 (file)
index 0000000..5e836b1
--- /dev/null
+++ b/90/51fe7ca2be1fefde5f10f6d56b7b8b45018ec9
@@ -0,0 +1,61 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 9CC9D431FBF;\r
+       Sun, 22 Nov 2009 20:35:08 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id CgWJq-42yES0; Sun, 22 Nov 2009 20:35:07 -0800 (PST)\r
+Received: from cworth.org (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 63ADE431FAE;\r
+       Sun, 22 Nov 2009 20:35:07 -0800 (PST)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: "Jeffrey C. Ollie" <jeff@ocjtech.us>, Not Much Mail\r
+       <notmuch@notmuchmail.org>\r
+In-Reply-To: <1258924631-17326-1-git-send-email-jeff@ocjtech.us>\r
+References: <1258924631-17326-1-git-send-email-jeff@ocjtech.us>\r
+Date: Mon, 23 Nov 2009 05:34:53 +0100\r
+Message-ID: <87ljhxg8pe.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Subject: Re: [notmuch] [PATCH] Add install target for desktop files.\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.12\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 23 Nov 2009 04:35:08 -0000\r
+\r
+On Sun, 22 Nov 2009 15:17:11 -0600, "Jeffrey C. Ollie" <jeff@ocjtech.us> wrote:\r
+> Add an install target that uses desktop-file-install to install the\r
+> desktop file in the appropriate location.  The location of the install\r
+> can be modified by changing the desktop_dir variable.\r
+\r
+Hi Jeffrey,\r
+\r
+I suppose if we're going to have a .desktop file it only makes sense to\r
+install it. A couple of questions:\r
+\r
+> +install-desktop:\r
+> +    install -d $(DESTDIR)$(desktop_dir)\r
+> +    desktop-file-install --mode 0644 --dir $(DESTDIR)$(desktop_dir) notmuch.desktop\r
+\r
+What does desktop-file-install do for us here? Anything that we couldn't\r
+do with just "install"? I'm just wanting to be careful that we don't\r
+break "make install" for people who may not even want this file.\r
+\r
+If we really do need to install it with desktop-file-install, we could\r
+do a configure check for that program, of course.\r
+\r
+Thanks,\r
+\r
+-Carl\r